From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: charles@aurox.ch (Charles A. Roelli) Newsgroups: gmane.emacs.bugs Subject: bug#32917: 27.0.50; read-hide-char documentation Date: Tue, 02 Oct 2018 21:47:32 +0200 Message-ID: Reply-To: charles@aurox.ch NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1538509386 20563 195.159.176.226 (2 Oct 2018 19:43:06 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 2 Oct 2018 19:43:06 +0000 (UTC) To: 32917@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 02 21:43:02 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g7QZP-00058l-Mb for geb-bug-gnu-emacs@m.gmane.org; Tue, 02 Oct 2018 21:43:01 +0200 Original-Received: from localhost ([::1]:45328 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g7QbW-0005GT-Bf for geb-bug-gnu-emacs@m.gmane.org; Tue, 02 Oct 2018 15:45:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49741) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g7QbP-0005FV-Ga for bug-gnu-emacs@gnu.org; Tue, 02 Oct 2018 15:45:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g7QbO-0001OF-Oq for bug-gnu-emacs@gnu.org; Tue, 02 Oct 2018 15:45:03 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58624) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g7QbO-0001O8-JD for bug-gnu-emacs@gnu.org; Tue, 02 Oct 2018 15:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1g7QbO-0001gR-Bl for bug-gnu-emacs@gnu.org; Tue, 02 Oct 2018 15:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: charles@aurox.ch (Charles A. Roelli) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Oct 2018 19:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 32917 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.15385094806420 (code B ref -1); Tue, 02 Oct 2018 19:45:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 2 Oct 2018 19:44:40 +0000 Original-Received: from localhost ([127.0.0.1]:34649 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g7Qb1-0001fU-TQ for submit@debbugs.gnu.org; Tue, 02 Oct 2018 15:44:40 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:40021) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g7Qaz-0001fG-AK for submit@debbugs.gnu.org; Tue, 02 Oct 2018 15:44:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g7Qat-0001I5-AI for submit@debbugs.gnu.org; Tue, 02 Oct 2018 15:44:31 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:34098) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g7Qas-0001Hr-Nm for submit@debbugs.gnu.org; Tue, 02 Oct 2018 15:44:31 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49630) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g7Qar-0004vZ-P3 for bug-gnu-emacs@gnu.org; Tue, 02 Oct 2018 15:44:30 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g7Qaq-0001HT-Su for bug-gnu-emacs@gnu.org; Tue, 02 Oct 2018 15:44:29 -0400 Original-Received: from sinyavsky.aurox.ch ([2a03:2040:2:1b::1]:41972) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g7Qaq-0001FZ-Ia for bug-gnu-emacs@gnu.org; Tue, 02 Oct 2018 15:44:28 -0400 Original-Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id 6B18D22870 for ; Tue, 2 Oct 2018 19:48:17 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= content-transfer-encoding:content-type:content-type:mime-version :reply-to:subject:subject:to:from:from:message-id:date:date; s= dkim; t=1538509696; x=1539373697; bh=6pzKzRTCCAFiCglLO4+PbEJn0Yc OiABcjP2WHn5QyTM=; b=hj9JHuNBjYf6OdLFgtBbnTH/k8+CYvqD2Bo3Wde604I 6wt64RLcgRRWQ0XSVVj9UmxkhDaWZAw6kIhywb8EDPuX74uPKBSAVu031j1KDFt7 AyVirfpugNQ4laC62y6Jne71bRjBGIYYKvPaNileMVfa182IMUc6VpVLZnmsDch4 = X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Original-Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id MULr-jT9W4Gr for ; Tue, 2 Oct 2018 19:48:16 +0000 (UTC) Original-Received: from gray (unknown [IPv6:2a02:1205:c693:2d60:c62c:3ff:fe30:b864]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id 96DA1226F4 for ; Tue, 2 Oct 2018 19:48:16 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:150906 Archived-At: read-hide-char is a variable defined in =E2=80=98C source code=E2=80=99= . Its value is nil Documentation: Whether to hide input characters in noninteractive mode. It must be a character, which will be used to mask the input characters. This variable should never be set globally. First, the scope of 'read-hide-char' seems wider than what the documentation claims (for example, it is used in read-passwd, interactively -- not just in "noninteractive mode"). Second, it can clearly also be nil instead of a character. Here's a suggested change for emacs-26: diff --git a/src/minibuf.c b/src/minibuf.c index 691fad0..f1bde91 100644 --- a/src/minibuf.c +++ b/src/minibuf.c @@ -2107,8 +2107,11 @@ properties. */); =20 DEFVAR_LISP ("read-hide-char", Vread_hide_char, doc: /* Whether to hide input characters in noninteractive mode. -It must be a character, which will be used to mask the input -characters. This variable should never be set globally. */); +If non-nil, it must be a character, which will be used to mask the +input characters. This variable should never be set globally. + +This variable also overrides the default character that `read-passwd' +uses to hide passwords. */); Vread_hide_char =3D Qnil; =20 defsubr (&Sactive_minibuffer_window);