unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#53251: 28.0.90; [PATCH] GNU ELPA: Add margin to 'pre' element
@ 2022-01-14 11:58 Y. E. via Bug reports for GNU Emacs, the Swiss army knife of text editors
  2022-01-23 12:31 ` Philip Kaludercic
  0 siblings, 1 reply; 3+ messages in thread
From: Y. E. via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2022-01-14 11:58 UTC (permalink / raw)
  To: 53251

[-- Attachment #1: Type: text/plain, Size: 489 bytes --]

Minor style change to improve packages 'Full Description' output. Few of
the influenced pages:

- http://elpa.gnu.org/packages/cape.html
- http://elpa.gnu.org/packages/consult.html
- http://elpa.gnu.org/packages/corfu.html
- http://elpa.gnu.org/packages/csharp-mode.html
- http://elpa.gnu.org/packages/devdocs.html
- http://elpa.gnu.org/packages/embark.html
- http://elpa.gnu.org/packages/embark-consult.html

Among the pages I checked (many but not all), none was influenced
negatively.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Add margin-bottom to pre --]
[-- Type: text/x-patch, Size: 531 bytes --]

From 3689fce340c4255f7a82f4607fa64e1488a3a08f Mon Sep 17 00:00:00 2001
From: YugaEgo <yet@ego.team>
Date: Fri, 14 Jan 2022 13:41:39 +0200
Subject: [PATCH] * html/layout.css (pre): Add margin-bottom

---
 html/layout.css | 1 +
 1 file changed, 1 insertion(+)

diff --git a/html/layout.css b/html/layout.css
index 48f9aa5fc7..96589cee1c 100644
--- a/html/layout.css
+++ b/html/layout.css
@@ -119,6 +119,7 @@ pre {
   padding: 1em;
   border: 1px solid #dadada;
   overflow-y: auto;
+  margin-bottom: 2em;
 }
 
 pre .kw {
-- 
2.34.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#53251: 28.0.90; [PATCH] GNU ELPA: Add margin to 'pre' element
  2022-01-14 11:58 bug#53251: 28.0.90; [PATCH] GNU ELPA: Add margin to 'pre' element Y. E. via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2022-01-23 12:31 ` Philip Kaludercic
  2022-01-24 16:20   ` Y. E. via Bug reports for GNU Emacs, the Swiss army knife of text editors
  0 siblings, 1 reply; 3+ messages in thread
From: Philip Kaludercic @ 2022-01-23 12:31 UTC (permalink / raw)
  To: Y. E.; +Cc: 53251

Y. E. <yet@ego.team> writes:

> Minor style change to improve packages 'Full Description' output. Few of
> the influenced pages:
>
> - http://elpa.gnu.org/packages/cape.html
> - http://elpa.gnu.org/packages/consult.html
> - http://elpa.gnu.org/packages/corfu.html
> - http://elpa.gnu.org/packages/csharp-mode.html
> - http://elpa.gnu.org/packages/devdocs.html
> - http://elpa.gnu.org/packages/embark.html
> - http://elpa.gnu.org/packages/embark-consult.html
>
> Among the pages I checked (many but not all), none was influenced
> negatively.

All these packages use org-mode READMEs, that are converted to HTML,
right?  To avoid unintended side-effects, it might be better to only
apply this to "pre.src", not all "pre" blocks.

-- 
	Philip Kaludercic





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#53251: 28.0.90; [PATCH] GNU ELPA: Add margin to 'pre' element
  2022-01-23 12:31 ` Philip Kaludercic
@ 2022-01-24 16:20   ` Y. E. via Bug reports for GNU Emacs, the Swiss army knife of text editors
  0 siblings, 0 replies; 3+ messages in thread
From: Y. E. via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2022-01-24 16:20 UTC (permalink / raw)
  To: Philip Kaludercic; +Cc: yet, 53251

[-- Attachment #1: Type: text/plain, Size: 862 bytes --]

Philip Kaludercic <philipk@posteo.net> writes:

> Y. E. <yet@ego.team> writes:
>
>> Minor style change to improve packages 'Full Description' output. Few of
>> the influenced pages:
>>
>> - http://elpa.gnu.org/packages/cape.html
>> - http://elpa.gnu.org/packages/consult.html
>> - http://elpa.gnu.org/packages/corfu.html
>> - http://elpa.gnu.org/packages/csharp-mode.html
>> - http://elpa.gnu.org/packages/devdocs.html
>> - http://elpa.gnu.org/packages/embark.html
>> - http://elpa.gnu.org/packages/embark-consult.html
>>
>> Among the pages I checked (many but not all), none was influenced
>> negatively.
>
> All these packages use org-mode READMEs, that are converted to HTML,
> right?  To avoid unintended side-effects, it might be better to only
> apply this to "pre.src", not all "pre" blocks.

Sounds good to me. I'm attaching the patch with this change.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Add margin-bottom to pre.src --]
[-- Type: text/x-patch, Size: 531 bytes --]

From 060945150ef443d6bea00a28376b08da7f8340ac Mon Sep 17 00:00:00 2001
From: YugaEgo <yet@ego.team>
Date: Mon, 24 Jan 2022 18:17:06 +0200
Subject: [PATCH] * html/layout.css (pre.src): Add margin-bottom

---
 html/layout.css | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/html/layout.css b/html/layout.css
index 48f9aa5fc7..963d19d6d6 100644
--- a/html/layout.css
+++ b/html/layout.css
@@ -126,6 +126,10 @@ pre .kw {
   color: #4f0f71;
 }
 
+pre.src {
+  margin-bottom: 2em;
+}
+
 p {
   margin-bottom: 2em;
 }
-- 
2.34.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-01-24 16:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-14 11:58 bug#53251: 28.0.90; [PATCH] GNU ELPA: Add margin to 'pre' element Y. E. via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-23 12:31 ` Philip Kaludercic
2022-01-24 16:20   ` Y. E. via Bug reports for GNU Emacs, the Swiss army knife of text editors

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).