unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Gerd Möllmann" <gerd.moellmann@gmail.com>
To: "João Távora" <joaotavora@gmail.com>
Cc: 65518@debbugs.gnu.org
Subject: bug#65518: 30.0.50; [FR Eglot] Completions over all workspace symbols
Date: Sun, 27 Aug 2023 07:56:43 +0200	[thread overview]
Message-ID: <m2ttslgh9g.fsf@Mini.fritz.box> (raw)
In-Reply-To: <877cphcpe4.fsf@gmail.com> ("João Távora"'s message of "Sun, 27 Aug 2023 01:14:43 +0100")

João Távora <joaotavora@gmail.com> writes:

> João Távora <joaotavora@gmail.com> writes:
>
>> If you want a comparative analysis to lsp-mode, to increase
>> the chances that this is addressed, I'd also need to know exactly
>> how you set it up.  As far as I understand, lsp-mode doesn't
>> do miracles, it uses the same LSP interfaces available to Eglot
>> (in this case, more than likely `symbol/workspace`, which I've
>> already described).
>
> Out of curiosity, I've had a look at lsp-mode.el.  It does not use
> 'symbol/workspace', rather 'textDocument/documentSymbol'.  So C-u
> M-. provides a complete list of symbols upfront.  But -- crucially --
> that list is limited to contain symbols for the current document only .
>
> So, at first glance, I'd say it's lsp-mode who is missing (lots and lots
> of) symbols.
>
> In contrast, Eglot's C-u M-. reaches all the symbols in the whole
> project, a much better implementation of 'xref-find-deinitions' IMNSHO.
> In a large project, like LLVM, using Eglot in combination with something
> like `M-x fido-vertical-mode` gives you an interactive incremental
> completion interface that is able reach millions of symbols across in
> thousands of C++ files.

Interesting.  Maybe I never noticed this because Emacs' C files include
so much that I got the impression that that was everything.

Thanks for testing this!

I guess we can close this request, then.  I'll see if can use etags, or
something, for that use-case.  Or just live with it.

Thanks!





  reply	other threads:[~2023-08-27  5:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-25  6:44 bug#65518: 30.0.50; [FR Eglot] Completions over all workspace symbols Gerd Möllmann
2023-08-25  9:22 ` João Távora
2023-08-26  5:09   ` Gerd Möllmann
2023-08-26  8:57     ` João Távora
2023-08-27  0:14       ` João Távora
2023-08-27  5:56         ` Gerd Möllmann [this message]
2023-08-27  6:06           ` João Távora
2023-08-27  6:38             ` Gerd Möllmann
2023-08-28  0:19   ` Dmitry Gutov
2023-08-28 11:10     ` Gerd Möllmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2ttslgh9g.fsf@Mini.fritz.box \
    --to=gerd.moellmann@gmail.com \
    --cc=65518@debbugs.gnu.org \
    --cc=joaotavora@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).