From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Detlev Zundel Newsgroups: gmane.emacs.bugs Subject: bug#18337: 24.4.50; apropos fails on "scroll" Date: Thu, 11 Sep 2014 10:42:12 +0200 Message-ID: References: <8669c0bb-347f-4b61-8202-562182aeba7f@default> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1410425017 32491 80.91.229.3 (11 Sep 2014 08:43:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 11 Sep 2014 08:43:37 +0000 (UTC) Cc: Dmitry Antipov , 18337@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Sep 11 10:43:30 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XRzyM-0004FG-5l for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 Sep 2014 10:43:22 +0200 Original-Received: from localhost ([::1]:34929 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRzyL-0004Kj-Rg for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 Sep 2014 04:43:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35101) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRzy9-0004H1-8K for bug-gnu-emacs@gnu.org; Thu, 11 Sep 2014 04:43:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XRzy2-0003Jf-FZ for bug-gnu-emacs@gnu.org; Thu, 11 Sep 2014 04:43:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45688) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRzy2-0003Jb-Cg for bug-gnu-emacs@gnu.org; Thu, 11 Sep 2014 04:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XRzy1-0005Hq-Sp for bug-gnu-emacs@gnu.org; Thu, 11 Sep 2014 04:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Detlev Zundel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Sep 2014 08:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18337 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 18337-submit@debbugs.gnu.org id=B18337.141042493920268 (code B ref 18337); Thu, 11 Sep 2014 08:43:01 +0000 Original-Received: (at 18337) by debbugs.gnu.org; 11 Sep 2014 08:42:19 +0000 Original-Received: from localhost ([127.0.0.1]:37252 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XRzxK-0005Gp-Nh for submit@debbugs.gnu.org; Thu, 11 Sep 2014 04:42:19 -0400 Original-Received: from mailout1.hostsharing.net ([83.223.95.204]:55451) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XRzxH-0005Gf-3m for 18337@debbugs.gnu.org; Thu, 11 Sep 2014 04:42:16 -0400 Original-Received: from h07.hostsharing.net (h07.hostsharing.net [83.223.95.26]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mailout1.hostsharing.net (Postfix) with ESMTPS id AF3AE6D732; Thu, 11 Sep 2014 10:42:13 +0200 (CEST) Original-Received: from deepthought (HSI-KBW-046-005-253-032.hsi8.kabel-badenwuerttemberg.de [46.5.253.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by h07.hostsharing.net (Postfix) with ESMTPSA id 9B39560A041F; Thu, 11 Sep 2014 10:42:13 +0200 (CEST) Original-Received: from dzu by deepthought with local (Exim 4.84) (envelope-from ) id 1XRzxF-0005hL-1t; Thu, 11 Sep 2014 10:42:13 +0200 In-Reply-To: (Detlev Zundel's message of "Fri, 29 Aug 2014 15:13:15 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:93260 Archived-At: --=-=-= Content-Type: text/plain Hi, > Hi Stefan, > > [added Dmitry on CC as the changelog seems to make a connection to the > problem at hand] > >>> (when (setq properties (symbol-plist 'vertical-scroll-bar)) >>> (setq doc (list (car properties))) >>> (while (setq properties (cdr (cdr properties))) >>> (setq doc (cons (car properties) doc))) >>> (nreverse doc)) >> >>> => (0 event-symbol-element-mask event-symbol-elements >>> modifier-cache variable-documentation) >> >>> Applying 'symbol-name to that list then yields the error. >> >> Note that, while convention is to use a symbol for property names, that >> is not the only valid choice. 0 is a valid property name (tho an odd >> one, arguably). > > I think in this case it actually caught an error though. > >> So while this 0 should probably be changed the mapconcat code that burps >> on it should probably be changed not to assume that only symbols will >> be used as property names. > > Looking deeper, it turns out that the 0 results from this: > > buffer.c:5473 > > DEFSYM (Qvertical_scroll_bar, "vertical-scroll-bar"); > Fput (Qvertical_scroll_bar, Qchoice, list4 (Qnil, Qt, Qleft, Qright)); > DEFSYM (Qhorizontal_scroll_bar, "horizontal-scroll-bar"); > > DEFSYM (Qfraction, "fraction"); > Fput (Qfraction, Qrange, Fcons (make_float (0.0), make_float (1.0))); > > DEFSYM (Qoverwrite_mode, "overwrite-mode"); > Fput (Qoverwrite_mode, Qchoice, > list3 (Qnil, intern ("overwrite-mode-textual"), > intern ("overwrite-mode-binary"))); > > As far as I can tell, it should thus really be 'choice. Actually both > vertical-scroll-bar and overwrite-mode have the problem: > > (symbol-plist 'vertical-scroll-bar) > > => (0 (nil t left right) event-symbol-element-mask (vertical-scroll-bar 0) event-symbol-elements (vertical-scroll-bar) modifier-cache ((0 . vertical-scroll-bar)) variable-documentation 374228) > > (symbol-plist 'overwrite-mode) > > => (0 (nil overwrite-mode-textual overwrite-mode-binary) event-symbol-element-mask (overwrite-mode 0) event-symbol-elements (overwrite-mode) modifier-cache ((0 . overwrite-mode)) :minor-mode-function binary-overwrite-mode variable-documentation 370277) > > The changelog mentions this > > 2014-07-16 Dmitry Antipov > > More precise control over values of some buffer-local variables. > * keyboard.c (Qvertical_scroll_bar): > * frame.c (Qleft, Qright): Move to ... > * buffer.c (Qleft, Qright, Qvertical_scroll_bar): ... here. > * buffer.c (Qchoice, Qrange, Qoverwrite_mode, Qfraction): New symbols. > (syms_of_buffer): DEFSYM all of the above, attach special properties. > Use special symbols to DEFVAR_PER_BUFFER overwrite-mode, > vertical-scroll-bar, scroll-up-aggressively > and scroll-down-aggressively. > > Dmitry, do you know why the construct for choice fails? The attached patch fixes the problem for me as the plist now looks like this: (symbol-plist 'vertical-scroll-bar) => (choice (nil t left right) event-symbol-element-mask (vertical-scroll-bar 0) event-symbol-elements (vertical-scroll-bar) modifier-cache ((0 . vertical-scroll-bar)) variable-documentation 374812) Cheers Detlev -- The 82558 B-step and later generation devices do not maintain a link in D3 if PME is disabled or if the device does not have power. -- Intel documentation --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-src-buffer.c-syms_of_buffer-Add-forgotten-Qchoice-DE.patch >From 5294eb80883abc3fb06805f972693664b294079f Mon Sep 17 00:00:00 2001 From: Detlev Zundel Date: Thu, 11 Sep 2014 10:37:54 +0200 Subject: [PATCH] * src/buffer.c (syms_of_buffer): Add forgotten Qchoice DEFSYM --- src/ChangeLog | 4 ++++ src/buffer.c | 1 + 2 files changed, 5 insertions(+) diff --git a/src/ChangeLog b/src/ChangeLog index e20072d..393fbe7 100644 --- a/src/ChangeLog +++ b/src/ChangeLog @@ -1,3 +1,7 @@ +2014-09-11 Detlev Zundel + + * buffer.c (syms_of_buffer): Add forgotten Qchoice DEFSYM + 2014-09-03 Martin Rudalics * buffer.c (scroll-bar-height): Fix typo in doc-string. diff --git a/src/buffer.c b/src/buffer.c index 45e614f..dd1e205 100644 --- a/src/buffer.c +++ b/src/buffer.c @@ -5386,6 +5386,7 @@ syms_of_buffer (void) staticpro (&Qpermanent_local); staticpro (&Qkill_buffer_hook); + DEFSYM (Qchoice, "choice"); DEFSYM (Qleft, "left"); DEFSYM (Qright, "right"); DEFSYM (Qrange, "range"); -- 2.1.0 --=-=-=--