* bug#32917: 27.0.50; read-hide-char documentation
@ 2018-10-02 19:47 Charles A. Roelli
2018-10-03 2:38 ` Eli Zaretskii
0 siblings, 1 reply; 3+ messages in thread
From: Charles A. Roelli @ 2018-10-02 19:47 UTC (permalink / raw)
To: 32917
read-hide-char is a variable defined in ‘C source code’.
Its value is nil
Documentation:
Whether to hide input characters in noninteractive mode.
It must be a character, which will be used to mask the input
characters. This variable should never be set globally.
First, the scope of 'read-hide-char' seems wider than what the
documentation claims (for example, it is used in read-passwd,
interactively -- not just in "noninteractive mode").
Second, it can clearly also be nil instead of a character.
Here's a suggested change for emacs-26:
diff --git a/src/minibuf.c b/src/minibuf.c
index 691fad0..f1bde91 100644
--- a/src/minibuf.c
+++ b/src/minibuf.c
@@ -2107,8 +2107,11 @@ properties. */);
DEFVAR_LISP ("read-hide-char", Vread_hide_char,
doc: /* Whether to hide input characters in noninteractive mode.
-It must be a character, which will be used to mask the input
-characters. This variable should never be set globally. */);
+If non-nil, it must be a character, which will be used to mask the
+input characters. This variable should never be set globally.
+
+This variable also overrides the default character that `read-passwd'
+uses to hide passwords. */);
Vread_hide_char = Qnil;
defsubr (&Sactive_minibuffer_window);
^ permalink raw reply related [flat|nested] 3+ messages in thread* bug#32917: 27.0.50; read-hide-char documentation
2018-10-02 19:47 bug#32917: 27.0.50; read-hide-char documentation Charles A. Roelli
@ 2018-10-03 2:38 ` Eli Zaretskii
2018-10-03 18:08 ` Charles A. Roelli
0 siblings, 1 reply; 3+ messages in thread
From: Eli Zaretskii @ 2018-10-03 2:38 UTC (permalink / raw)
To: charles; +Cc: 32917
> Date: Tue, 02 Oct 2018 21:47:32 +0200
> From: charles@aurox.ch (Charles A. Roelli)
>
> Here's a suggested change for emacs-26:
>
> diff --git a/src/minibuf.c b/src/minibuf.c
> index 691fad0..f1bde91 100644
> --- a/src/minibuf.c
> +++ b/src/minibuf.c
> @@ -2107,8 +2107,11 @@ properties. */);
>
> DEFVAR_LISP ("read-hide-char", Vread_hide_char,
> doc: /* Whether to hide input characters in noninteractive mode.
> -It must be a character, which will be used to mask the input
> -characters. This variable should never be set globally. */);
> +If non-nil, it must be a character, which will be used to mask the
> +input characters. This variable should never be set globally.
> +
> +This variable also overrides the default character that `read-passwd'
> +uses to hide passwords. */);
This is OK, thanks. Please also add an index entry for read-hide-char
in the ELisp manual, where read-passwd is described, because every
variable mentioned in the manual must be indexed.
^ permalink raw reply [flat|nested] 3+ messages in thread* bug#32917: 27.0.50; read-hide-char documentation
2018-10-03 2:38 ` Eli Zaretskii
@ 2018-10-03 18:08 ` Charles A. Roelli
0 siblings, 0 replies; 3+ messages in thread
From: Charles A. Roelli @ 2018-10-03 18:08 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 32917
tags 32917 fixed
close 32917 26.2
> Date: Wed, 03 Oct 2018 05:38:42 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> CC: 32917@debbugs.gnu.org
>
> > Date: Tue, 02 Oct 2018 21:47:32 +0200
> > From: charles@aurox.ch (Charles A. Roelli)
> >
> > Here's a suggested change for emacs-26:
> >
> > diff --git a/src/minibuf.c b/src/minibuf.c
> > index 691fad0..f1bde91 100644
> > --- a/src/minibuf.c
> > +++ b/src/minibuf.c
> > @@ -2107,8 +2107,11 @@ properties. */);
> >
> > DEFVAR_LISP ("read-hide-char", Vread_hide_char,
> > doc: /* Whether to hide input characters in noninteractive mode.
> > -It must be a character, which will be used to mask the input
> > -characters. This variable should never be set globally. */);
> > +If non-nil, it must be a character, which will be used to mask the
> > +input characters. This variable should never be set globally.
> > +
> > +This variable also overrides the default character that `read-passwd'
> > +uses to hide passwords. */);
>
> This is OK, thanks. Please also add an index entry for read-hide-char
> in the ELisp manual, where read-passwd is described, because every
> variable mentioned in the manual must be indexed.
Thanks, this is now done.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-03 18:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-02 19:47 bug#32917: 27.0.50; read-hide-char documentation Charles A. Roelli
2018-10-03 2:38 ` Eli Zaretskii
2018-10-03 18:08 ` Charles A. Roelli
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).