From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Filipp Gunbin Newsgroups: gmane.emacs.bugs Subject: bug#33154: 27.0.50; create_process on Darwin should not invoke setsid() after vfork() [PATCH] Date: Tue, 06 Nov 2018 16:46:06 +0300 Message-ID: References: <8237cee2-9e65-4093-8077-a458cf58c911@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1541511907 25489 195.159.176.226 (6 Nov 2018 13:45:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 6 Nov 2018 13:45:07 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (darwin) Cc: Alan Third , 33154@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 06 14:45:03 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gK1fB-0006Ro-2K for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Nov 2018 14:45:01 +0100 Original-Received: from localhost ([::1]:41224 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gK1hH-00077n-ER for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Nov 2018 08:47:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39788) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gK1hB-00077X-EA for bug-gnu-emacs@gnu.org; Tue, 06 Nov 2018 08:47:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gK1h8-0001mU-5n for bug-gnu-emacs@gnu.org; Tue, 06 Nov 2018 08:47:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60127) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gK1h8-0001lK-1A for bug-gnu-emacs@gnu.org; Tue, 06 Nov 2018 08:47:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gK1h7-0006W0-R5 for bug-gnu-emacs@gnu.org; Tue, 06 Nov 2018 08:47:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Filipp Gunbin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Nov 2018 13:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33154 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 33154-submit@debbugs.gnu.org id=B33154.154151197924995 (code B ref 33154); Tue, 06 Nov 2018 13:47:01 +0000 Original-Received: (at 33154) by debbugs.gnu.org; 6 Nov 2018 13:46:19 +0000 Original-Received: from localhost ([127.0.0.1]:36151 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gK1gQ-0006V5-HL for submit@debbugs.gnu.org; Tue, 06 Nov 2018 08:46:18 -0500 Original-Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:55133) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gK1gO-0006Un-Gv for 33154@debbugs.gnu.org; Tue, 06 Nov 2018 08:46:17 -0500 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 64A0FFD3; Tue, 6 Nov 2018 08:46:10 -0500 (EST) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 06 Nov 2018 08:46:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type:content-transfer-encoding; s=fm1; bh= JvnhMbaVKIFaDty6D1ssKwtxuIZz3d6OnmUZZ7/3Kek=; b=JarOPOpWnE5FY+Yt qHAu4JUBiCsbtPzqXsag6Tp7t0VXh2LGbY1WvLScvFAJ2PTPGf+r3Nw5g1qbd0hz iLOH7bjTmCAyQbSzJjnENvmn7fF4wrIWzwVzgByTWROMEftHeQRjzdK5dBs0d38w jFbLXIpQz2Z3U/CC2/0j3hqtaCDL5T05838oskurqX2jWigLC6vUFh3uUk0NUidM 7sg0g/d0x9CkpGG9HDMX/I5Y1L+uovMPtCG1H448C8P122AvYOW7fKMKOg8Zawg3 w/bss4oBcW0QgTG0S/rjczFDm8raqCKAjXGT1r7OTmUrcVlR0xb0ehnNTW8Gnr6o WnrkCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=JvnhMbaVKIFaDty6D1ssKwtxuIZz3d6OnmUZZ7/3K ek=; b=nEHIGn72G5NAVc6sdagg1Yn5ODX5C742KKYcms6EnYORBvgxEKZXzQmL/ l67MwcubxFQGJR4WaJIodCEPL2JxOSj30TqOt0ubfCTIjbSEI5Mmdlu6ldJHJYtZ 7cYo7X3Ki9KptGjS3h/AJHgvZDEg8sFQnzaO7/HaPud7PS3NRZr0Z+T2NtVd+bFE jo32pVQu+xQvgbBJhyf/fS1oIOp7rfA70wDtVE7NxF57230f62lSliMLq1FZSF+8 YWOfwt/jt64gIseZqwt7nwSaxNNfYHehGvewG5tkXdco8OFiwmT/8X8DBDGusmvM qHYKj/oIBLbu7RMASYZhP/lqaXCGA== X-ME-Sender: X-ME-Proxy: Original-Received: from fgunbin.playteam.ru (unknown [95.161.147.10]) by mail.messagingengine.com (Postfix) with ESMTPA id B558A102E0; Tue, 6 Nov 2018 08:46:08 -0500 (EST) In-Reply-To: <8237cee2-9e65-4093-8077-a458cf58c911@cs.ucla.edu> (Paul Eggert's message of "Mon, 5 Nov 2018 09:28:27 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152101 Archived-At: On 05/11/2018 09:28 -0800, Paul Eggert wrote: >> The main block of this code looks identical to the BSD specific code >> just underneath (#ifdef TIOCNOTTY), is there a reason we can=E2=80=99t r= euse >> that? > > I don't see why not. Proposed patch attached; please give it a try as > I don't use macOS. Paul, thanks for the patch. I'm seeing some problems with my fix - specifically, with sudo run as async shell command: "sudo: no tty present and no askpass program specified" and with tramp when trying to connect to anything via ssh: Permission denied, please try again. Permission denied, please try again. Received disconnect from port 22:2: Too many authentication failures Disconnected from port 22 I didn't have time to look into it. When I handle it, I'll try your patch also and will write back. Filipp