From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrii Kolomoiets Newsgroups: gmane.emacs.bugs Subject: bug#43464: 28.0.50; vc: Error calling vc-revert for repo root Date: Wed, 07 Oct 2020 16:16:13 +0300 Message-ID: References: <0b1c72d0-f8fb-a256-1563-1c43296c8edb@yandex.ru> <11761d79-1893-fdf3-843d-bea4a026fc7f@yandex.ru> <7b4d0bcf-c622-b2db-34d6-e587fe516f8d@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14287"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (darwin) Cc: 43464@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 07 15:17:19 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kQ9Jm-0003cH-IZ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 07 Oct 2020 15:17:18 +0200 Original-Received: from localhost ([::1]:44554 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kQ9Jl-0003Dl-G7 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 07 Oct 2020 09:17:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53968) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQ9JW-0003DT-JU for bug-gnu-emacs@gnu.org; Wed, 07 Oct 2020 09:17:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44037) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kQ9JW-0003We-4u for bug-gnu-emacs@gnu.org; Wed, 07 Oct 2020 09:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kQ9JV-0000eW-Vw for bug-gnu-emacs@gnu.org; Wed, 07 Oct 2020 09:17:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrii Kolomoiets Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 07 Oct 2020 13:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43464 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 43464-submit@debbugs.gnu.org id=B43464.16020765862463 (code B ref 43464); Wed, 07 Oct 2020 13:17:01 +0000 Original-Received: (at 43464) by debbugs.gnu.org; 7 Oct 2020 13:16:26 +0000 Original-Received: from localhost ([127.0.0.1]:55583 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQ9Iw-0000de-8Z for submit@debbugs.gnu.org; Wed, 07 Oct 2020 09:16:26 -0400 Original-Received: from mail-lj1-f175.google.com ([209.85.208.175]:36494) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQ9Is-0000dN-Og for 43464@debbugs.gnu.org; Wed, 07 Oct 2020 09:16:24 -0400 Original-Received: by mail-lj1-f175.google.com with SMTP id r24so1938560ljm.3 for <43464@debbugs.gnu.org>; Wed, 07 Oct 2020 06:16:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=6RRfqsbIa6PVU+u4Gqsgz20ccLTx+1rqs5I59wfEsII=; b=dwL9IeTPnNIvmf7egV9jEacJITF3j1rBf/2hHAIVP5DTtWjLj4E3VqG1qjqrrrf6Lt YQm97doO/FDaKdNhL7XQY3Wr72OvdAkdY0ej3Ej/haxYDE6G9hUhZkAsbFyVdCoVYdC/ /KqadcFmwQOd6FIQktVPM1FIu3Y0UDJiY5/bwce/4MgeVqFsEnQD9IDJbKidxuAYqEGr bsKOTfkChpj1/F7Y7CEmm9UZpU/OKsisDqI2BfjrmHE7v6yQ1CfP9lfraevGD/Iqvjjl pvrELXGAcTYVG99HBewx/jzOf6K9v33ZHKi2E7m1nu6FGxP7q9eDY0YwVKSa331uXdag zu4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=6RRfqsbIa6PVU+u4Gqsgz20ccLTx+1rqs5I59wfEsII=; b=iYAmTTyiTadQYWJPYzIqDY1xs3p0jcdtvqvwPFxJwrzmj8m/G9rDVY8WqC7QJsNA1l 33TEE8zBn0m1+ZSda4eCtlg8ZuKamF1f8nCF7DqqiNRsQehK6HPUJX5aYB6ODSLme2/n 64R2+xhmGE4BuUuWR5k3qWCHQR4VYbZanXTAwyP+1ew5jxDtkyl065cOy0j1Y+fjwc96 16Jok/x5UlS9Uk6Wc/DHyEAwTgDexAYd5qSWzdbs5so/IP5Jix1QIK6QzpEygt/iDa6q lzwdtWLLOmcV7nYz0Q0jnf3+CmLZTUKlm0euYIDiLyQFSoLZKsZ/PfVtOFIc97LkDuW+ Sxvg== X-Gm-Message-State: AOAM532HXUGf/+JmHjIJAZfPTtLubqXnANE45xU/JYguj17vj5Nyilvz KLnRkuR/gOinKJitfwsnnyLaWCvJpLA= X-Google-Smtp-Source: ABdhPJx+8H2PN9retDDWNfBb0BMEf6r/DWG0/7Y3BsKZICEZiJI4hNSFMXvcv+SfxKDDQbL/sBnJwA== X-Received: by 2002:a05:651c:327:: with SMTP id b7mr1125484ljp.140.1602076576166; Wed, 07 Oct 2020 06:16:16 -0700 (PDT) Original-Received: from muffinmac ([91.206.110.168]) by smtp.gmail.com with ESMTPSA id q11sm331241lfc.309.2020.10.07.06.16.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Oct 2020 06:16:15 -0700 (PDT) In-Reply-To: (Dmitry Gutov's message of "Mon, 5 Oct 2020 13:19:19 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:190024 Archived-At: Dmitry Gutov writes: > On 05.10.2020 09:02, Andrii Kolomoiets wrote: >> Dmitry Gutov writes: >> >>> Where is that vc-backend called from, in our scenario? >> It's called from 'vc-call'. The 'vc-revert-file' used it twice >> to call the 'make-version-backups-p' and the 'revert' backend functions. > > Then a change in vc-revert-file could be sufficient. Can you please advice me what this change should look like? Get rid of calling 'vc-call'? In this case the function 'vc-version-backup-file' must be changed as well. >>> Could we make do with changing that code to use vc-responsible-backend >>> instead of vc-backend instead? If it's not a function called >>> frequently. >> I went a little different way and made the 'vc-backend' return >> correct >> backend for directories. In case you missed it somehow here is the link >> to the message: >> https://lists.gnu.org/archive/html/bug-gnu-emacs/2020-09/msg02508.html > > Like I explained, it will create a cache entry that is never invalidated. In what way VC backend for directory could be changed? Like 'rm -rf .hg && git init'? We can make the 'vc-backend' function to ignore cached backend for directories. Though I think it's not efficient.