From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrii Kolomoiets Newsgroups: gmane.emacs.bugs Subject: bug#43464: 28.0.50; vc: Error calling vc-revert for repo root Date: Sun, 11 Oct 2020 23:28:08 +0300 Message-ID: References: <0b1c72d0-f8fb-a256-1563-1c43296c8edb@yandex.ru> <11761d79-1893-fdf3-843d-bea4a026fc7f@yandex.ru> <7b4d0bcf-c622-b2db-34d6-e587fe516f8d@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29506"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (darwin) Cc: 43464@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 11 22:29:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kRhxu-0007ai-4S for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 11 Oct 2020 22:29:10 +0200 Original-Received: from localhost ([::1]:42508 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kRhxt-0005eZ-6g for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 11 Oct 2020 16:29:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56144) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kRhxm-0005eB-T8 for bug-gnu-emacs@gnu.org; Sun, 11 Oct 2020 16:29:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57812) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kRhxm-0004dP-K3 for bug-gnu-emacs@gnu.org; Sun, 11 Oct 2020 16:29:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kRhxm-0001qY-HW for bug-gnu-emacs@gnu.org; Sun, 11 Oct 2020 16:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrii Kolomoiets Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Oct 2020 20:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43464 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 43464-submit@debbugs.gnu.org id=B43464.16024480997051 (code B ref 43464); Sun, 11 Oct 2020 20:29:02 +0000 Original-Received: (at 43464) by debbugs.gnu.org; 11 Oct 2020 20:28:19 +0000 Original-Received: from localhost ([127.0.0.1]:41125 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kRhx5-0001pe-HL for submit@debbugs.gnu.org; Sun, 11 Oct 2020 16:28:19 -0400 Original-Received: from mail-lj1-f182.google.com ([209.85.208.182]:46981) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kRhx3-0001pS-Qj for 43464@debbugs.gnu.org; Sun, 11 Oct 2020 16:28:18 -0400 Original-Received: by mail-lj1-f182.google.com with SMTP id c21so14840725ljn.13 for <43464@debbugs.gnu.org>; Sun, 11 Oct 2020 13:28:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=if/+BSOS1wmVyuomsGPC6whY39/vBqwHxq7hvAVvs40=; b=sW//BHo2gNLzZ5POP6t4mzYoQoSwl5Mmw4LK6xo2kbHYsyNFNEf8sHlW1O+/xrEdhG CBF7tU49ksYKBpdIb8T4tKL1SLLOG9q6UP6Ar2TN2zaZueFqn957q+kV2Mwfh7F7K9Ad zhrB+b3V+7Wt3TN+qbBXbMru8Ov7iX5M+j4cdy12toYfliNNq2DE4prKkjXbkcUIw1nN DYlPnmJuUYD3vqTMOVRVVvlRrHMDx2LVgqyogGc0PN17Ix9FbbaIfJqPQo2aeX9MfU0m 9L6cyfR/jwdaEpRgjm/R0YfYB6kPtXfr8pvLiGIkoDbRgRwY73sDHNh9eGavXshcPZkC L/vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=if/+BSOS1wmVyuomsGPC6whY39/vBqwHxq7hvAVvs40=; b=neGACkm97SKUYkQjWCpMnV+SoRC2eTMCC015ieXqQbM0avlczgHOp+kUsvz8qQdFx9 mtTMoPmHv14CBzAQtqG7bAMoaEBahMM42Pnqp3bduR2ZKxBodgxMpz3md+SeHW1790CJ Bdka3Y8ZvoM1uNofB6n7FFJNsofXxQM0FIYD/BVgjvLcXRSldZ9vAPLeT77y+Wm5jmbP Bw1Qi5UUW0+7nztD0e1z0xCv7UakuXjlP5fr0SsPRinl4Hn1jkYmpDgv5YbGlprCL2k8 ImE4NlC0DiPkoxGN9zlBVdL55tk1ZALCiWKCUxB18xUhgRKOf/LN4FbfjGZIJVHAaLF5 fuug== X-Gm-Message-State: AOAM5307QT13tf+1B2fAM0aM09eYeI2lbdHqtMAmosW6+wpXIB/3m0hQ Num3woKJU2Ai9Zr59CvsCc3hz3LMcUc= X-Google-Smtp-Source: ABdhPJwdn0WvvBPyt/tpxR9iR791uPIvPMZjZgKS3q2S+xbOdZ4hXznOslaqF2hhw5oJhhof+RKqsA== X-Received: by 2002:a05:651c:1190:: with SMTP id w16mr8894324ljo.36.1602448091410; Sun, 11 Oct 2020 13:28:11 -0700 (PDT) Original-Received: from muffinmac ([91.206.110.168]) by smtp.gmail.com with ESMTPSA id t19sm3172992ljk.67.2020.10.11.13.28.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Oct 2020 13:28:10 -0700 (PDT) In-Reply-To: (Dmitry Gutov's message of "Thu, 8 Oct 2020 01:47:29 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:190289 Archived-At: Dmitry Gutov writes: >> Can you please advice me what this change should look like? Get rid >> of calling 'vc-call'? > > Yes. How about the attached patch? Small fix: THEN and ELSE blocks of the '(if dir...' should be swapped. Does those kind of changes should be applied to any function that uses 'vc-call' and can be called on dirs? Is there any reason to use 'vc-backend' at all? 'vc-responsible-backend' will call 'vc-backend' on a file that is not a directory. >> In this case the function 'vc-version-backup-file' >> must be changed as well. > > Does it actually make sense to use it on a directory? Looks like it make sense for CVS backend. Take a look at 'vc-cvs-stay-local-p'. > Something like that. Or 'git init' inside a subdirectory. Not a > frequent occurrence, but if we start using directories and files > interchangeably in more places, we are likely to start caching other > properties on them, too. So it's better to use a different function to > detect which backend a directory belongs to. In this case `vc-call` must use that function, right? > Also, your patch makes vc-registered work on directories. How is that? 'vc-registered' is still returns nil for directories. The changes affects only the side effect of it.