From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Matt Armstrong Newsgroups: gmane.emacs.bugs Subject: bug#46396: 27.1.90; Ediff's non-focused diff section, background too light in --reverse Date: Wed, 10 Feb 2021 12:28:34 -0800 Message-ID: References: <87blcs2f9q.fsf@mail.linkov.net> <87wnvfwwfg.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34447"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (darwin) Cc: 46396@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 10 21:29:37 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l9w7F-0008qt-NU for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Feb 2021 21:29:37 +0100 Original-Received: from localhost ([::1]:42088 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9w7E-0001Zy-Oz for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Feb 2021 15:29:36 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36172) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9w6g-0001Yv-89 for bug-gnu-emacs@gnu.org; Wed, 10 Feb 2021 15:29:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45744) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l9w6f-0003t4-Vv for bug-gnu-emacs@gnu.org; Wed, 10 Feb 2021 15:29:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l9w6f-0000i6-SX for bug-gnu-emacs@gnu.org; Wed, 10 Feb 2021 15:29:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Matt Armstrong Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Feb 2021 20:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46396 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 46396-submit@debbugs.gnu.org id=B46396.16129889312691 (code B ref 46396); Wed, 10 Feb 2021 20:29:01 +0000 Original-Received: (at 46396) by debbugs.gnu.org; 10 Feb 2021 20:28:51 +0000 Original-Received: from localhost ([127.0.0.1]:57290 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9w6V-0000hL-A6 for submit@debbugs.gnu.org; Wed, 10 Feb 2021 15:28:51 -0500 Original-Received: from relay4-d.mail.gandi.net ([217.70.183.196]:40533) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9w6R-0000gj-Ez for 46396@debbugs.gnu.org; Wed, 10 Feb 2021 15:28:50 -0500 X-Originating-IP: 24.113.169.116 Original-Received: from matts-mbp-2016.lan (24-113-169-116.wavecable.com [24.113.169.116]) (Authenticated sender: matt@rfc20.org) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 45326E0004; Wed, 10 Feb 2021 20:28:38 +0000 (UTC) In-Reply-To: <87wnvfwwfg.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 10 Feb 2021 21:39:35 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:199797 Archived-At: Juri Linkov writes: [...] >> The issues I see with ediff-current-* faces are arguably a tangent to >> this bug. Perhaps those faces could use :distant-foreground as well, for >> similar reasons? > > I'm not sure if it's possible to find such default colors that would > work well for all standard themes. But there is no need to use > :distant-foreground in themes, because the authors of themes can find > the right combination of the default/ediff colors and adjust their themes > accordingly. > >> As for the background colors possibly being quite similar to the theme's >> background, I'm not sure what to do about that. > > Implementing something like :distant-background is less important than > :distant-foreground, because :distant-foreground is important to > make the text readable, while :distant-background would only help > making the background color differ from the default background color. Thanks again for the fix. Yes, I have long wondered if the experience of making and using themes could be better. Today it seems like the best course of action is to customize all known faces in your theme, at least if you'd like it to look great in all cases. Otherwise the appearance is a bit of a gamble.