From: Filipp Gunbin <fgunbin@fastmail.fm>
To: Alan Third <alan@idiocy.org>
Cc: nisoni@algon.dk, stefan@marxist.se, 51321@debbugs.gnu.org,
mardani29@yahoo.es, larsi@gnus.org
Subject: bug#51321: 29.0.50; date in modelines
Date: Tue, 02 Nov 2021 04:10:18 +0300 [thread overview]
Message-ID: <m2sfwfz7k5.fsf@fastmail.fm> (raw)
In-Reply-To: <YYBZcIRB4SJlvqsv@idiocy.org> (Alan Third's message of "Mon, 1 Nov 2021 21:17:36 +0000")
On 01/11/2021 21:17 +0000, Alan Third wrote:
> On Mon, Nov 01, 2021 at 04:34:58PM +0200, Eli Zaretskii wrote:
>> > From: Filipp Gunbin <fgunbin@fastmail.fm>
>> > Cc: alan@idiocy.org, larsi@gnus.org, nisoni@algon.dk, stefan@marxist.se,
>> > 51321@debbugs.gnu.org, mardani29@yahoo.es
>> > Date: Mon, 01 Nov 2021 17:21:36 +0300
>> >
>> > >> So maybe we should check that the locale is valid before setting it...
>> > >
>> > > "Valid" in what sense? Is that locale not installed on your system,
>> > > or are you saying that it cannot exist?
>> >
>> > I think in the sense of 'locale -a | grep ru' in this case:
>> >
>> > ru_RU.ISO8859-5
>> > ru_RU.CP866
>> > ru_RU.CP1251
>> > ru_RU.UTF-8
>> > ru_RU.KOI8-R
>> > ru_RU
>> >
>> > Maybe it could exist, but it doesn't on macOS.
>> >
>> > > (And why does the warning come from Bash when it was Emacs who sets
>> > > the locale?)
>> >
>> > Forgot to tell - this output shows up when running shell command from
>> > emacs (M-! or similar).
>>
>> Hmm... actually, why do we call setenv instead of calling setlocale
>> directly? Doesn't macOS support setlocale? AFAIU, calling setlocale
>> would then only affect Emacs itself, not its sub-processes.
>
> The point of this is to affect Emacs's sub-processes.
>
> I know almost nothing about the locale, but from reading the man pages
> I can't understand why we need to set LC_ALL when we're already
> setting LANG. Isn't LANG the fallback if LC_ALL isn't set?
>
> Anyway, I think we can use setlocale to test if the locale string is
> valid, but I don't know if there are any other problems with that.
> Would we want to reset it after testing?
>
> I suppose it might also be preferable to not even try doing this if
> Emacs was run from a terminal since the original problem really only
> manifests when Emacs is run from the GUI.
>
> Fillip, can you please try this:
>
[..]
I see Daniel is saying that perhaps his patch should be reverted, so
please let me know if you still want me to test this.
next prev parent reply other threads:[~2021-11-02 1:10 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 15:24 bug#51321: 29.0.50; date in modelines Niels Søndergaard
2021-10-21 17:00 ` Eli Zaretskii
2021-10-21 18:09 ` Niels Søndergaard
2021-10-21 18:13 ` Niels Søndergaard
2021-10-21 18:18 ` Eli Zaretskii
2021-10-22 1:37 ` Niels Søndergaard
2021-10-22 6:34 ` Eli Zaretskii
2021-10-22 13:27 ` Niels Søndergaard
2021-10-22 14:11 ` Eli Zaretskii
2021-10-23 12:16 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-23 12:23 ` Eli Zaretskii
2021-10-23 12:52 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-23 16:00 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-30 15:41 ` Stefan Kangas
2021-10-30 18:09 ` Alan Third
2021-10-31 9:06 ` Eli Zaretskii
2021-10-31 10:14 ` Alan Third
2021-10-31 13:01 ` Eli Zaretskii
2021-11-01 13:04 ` Filipp Gunbin
2021-11-01 13:33 ` Eli Zaretskii
2021-11-01 14:21 ` Filipp Gunbin
2021-11-01 14:34 ` Eli Zaretskii
2021-11-01 14:45 ` Filipp Gunbin
2021-11-01 21:17 ` Alan Third
2021-11-01 22:17 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-02 3:40 ` Niels Søndergaard
2021-11-02 16:10 ` Filipp Gunbin
2021-11-02 18:22 ` Stefan Kangas
2021-11-09 7:52 ` Stefan Kangas
2021-11-09 14:13 ` Filipp Gunbin
2022-09-10 5:09 ` Lars Ingebrigtsen
2021-11-02 1:10 ` Filipp Gunbin [this message]
2021-10-23 12:34 ` Niels Søndergaard
2021-10-23 12:55 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-23 12:58 ` Niels Søndergaard
2021-10-22 14:40 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2sfwfz7k5.fsf@fastmail.fm \
--to=fgunbin@fastmail.fm \
--cc=51321@debbugs.gnu.org \
--cc=alan@idiocy.org \
--cc=larsi@gnus.org \
--cc=mardani29@yahoo.es \
--cc=nisoni@algon.dk \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).