From: "Gerd Möllmann" <gerd.moellmann@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 71763@debbugs.gnu.org, Daniel Pettersson <daniel@dpettersson.net>
Subject: bug#71763: [PATCH] Inconsistency in bitmap overlay drawing for macOS
Date: Sun, 27 Oct 2024 14:23:49 +0100 [thread overview]
Message-ID: <m2sesh65ne.fsf@gmail.com> (raw)
In-Reply-To: <86ttcx92k7.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 27 Oct 2024 14:02:16 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Daniel Pettersson <daniel@dpettersson.net>
>> Cc: 71763@debbugs.gnu.org
>> Date: Sun, 27 Oct 2024 11:26:50 +0100
>>
>> Eli Zaretskii <eliz@gnu.org> writes:
>>
>> > Can some macOS expert please review the proposed patch?
>> Seems like they are hard to come by.
>>
>> I have been using this patch since I reported the bug, how can I help
>> move this along?
>
> Thanks, but maybe Gerd (CCed) will agree to look at this?
The struct draw_fringe_bitmap_params is not documented very well, so
I've looked at fringe.c for what its overlay_p member means. I landed in
draw_fringe_bitmap_1, where draw_fringe_bitmap_params::overlay_p is set
if that function is called with an overlay parameter that fits some
criterion, which one can try to figure out in its caller
draw_fringe_bitmap. It apparently has something to do with drawing a
cursor in a fringe, and then also drawing an overlay arrow.
Didn't even know until a few minutes ago that the cursor can land in
the fringe. And I'm wondering if that ever happens in the left fringe,
and/or if the overlay arrow appears only on the left. Questions upon
questions, as usual.
Anyway. Assuming that I read the code correctly, that we are drawing a
cursor and overlay arrow on top of each other, then I think Daniel's
patch makes sense, because drawing the overlay arrow should not clear
under it and erase what was drawn for the cursor before.
That's about what I could find out. NS should do something different if
overlay_p is set or not, I think that's for sure. And if Daniel says it
works, that's goog enough for me I guess.
next prev parent reply other threads:[~2024-10-27 13:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-24 22:04 bug#71763: [PATCH] Inconsistency in bitmap overlay drawing for macOS Daniel Pettersson
2024-06-27 9:35 ` Eli Zaretskii
2024-10-27 10:26 ` Daniel Pettersson
2024-10-27 12:02 ` Eli Zaretskii
2024-10-27 13:23 ` Gerd Möllmann [this message]
2024-10-27 13:41 ` Eli Zaretskii
2024-10-27 14:03 ` Gerd Möllmann
2024-10-29 19:59 ` Daniel Pettersson
2024-10-30 7:11 ` Gerd Möllmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2sesh65ne.fsf@gmail.com \
--to=gerd.moellmann@gmail.com \
--cc=71763@debbugs.gnu.org \
--cc=daniel@dpettersson.net \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).