From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nikolaj Schumacher Newsgroups: gmane.emacs.bugs Subject: bug#2993: 23.0.92; posn-col-row wrong with line-spacing in terminals Date: Tue, 14 Apr 2009 14:12:12 +0200 Message-ID: References: <834owro4ha.fsf@gnu.org> Reply-To: Nikolaj Schumacher , 2993@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1239711853 21295 80.91.229.12 (14 Apr 2009 12:24:13 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 14 Apr 2009 12:24:13 +0000 (UTC) Cc: 2993@emacsbugs.donarmstrong.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 14 14:25:31 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Lthhi-0002Lh-Oc for geb-bug-gnu-emacs@m.gmane.org; Tue, 14 Apr 2009 14:25:31 +0200 Original-Received: from localhost ([127.0.0.1]:42128 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LthgK-0008Rj-0h for geb-bug-gnu-emacs@m.gmane.org; Tue, 14 Apr 2009 08:24:04 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LthgD-0008RC-Oy for bug-gnu-emacs@gnu.org; Tue, 14 Apr 2009 08:23:57 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lthg9-0008Qd-QH for bug-gnu-emacs@gnu.org; Tue, 14 Apr 2009 08:23:57 -0400 Original-Received: from [199.232.76.173] (port=56324 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lthg9-0008QS-J0 for bug-gnu-emacs@gnu.org; Tue, 14 Apr 2009 08:23:53 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:51413) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Lthg8-0006QW-V4 for bug-gnu-emacs@gnu.org; Tue, 14 Apr 2009 08:23:53 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n3ECNo1H011528; Tue, 14 Apr 2009 05:23:50 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n3ECK2Io010242; Tue, 14 Apr 2009 05:20:02 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Nikolaj Schumacher Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Tue, 14 Apr 2009 12:20:02 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 2993 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 2993-submit@emacsbugs.donarmstrong.com id=B2993.12397111398690 (code B ref 2993); Tue, 14 Apr 2009 12:20:02 +0000 Original-Received: (at 2993) by emacsbugs.donarmstrong.com; 14 Apr 2009 12:12:19 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from dd18200.kasserver.com (dd18200.kasserver.com [85.13.138.168]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n3ECCG5a008684 for <2993@emacsbugs.donarmstrong.com>; Tue, 14 Apr 2009 05:12:17 -0700 Original-Received: from thursday (f051167223.adsl.alicedsl.de [78.51.167.223]) by dd18200.kasserver.com (Postfix) with ESMTP id 5A132180296D1; Tue, 14 Apr 2009 14:12:16 +0200 (CEST) In-Reply-To: <834owro4ha.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 14 Apr 2009 14:32:33 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.92 (darwin) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Tue, 14 Apr 2009 08:23:57 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:27163 Archived-At: Eli Zaretskii wrote: >> posn-col-row uses the `line-spacing' value in terminals. According to the >> doc `line-spacing' only has an effect in window systems. > > You mean, on graphic displays. Yes. If that wording is inaccurate, it should also be fixed in the doc for `line-spacing', which says: "The space is measured in pixels, and put below lines on window systems." > Please use `display-graphic-p' rather than assuming that if > `window-system' is non-nil, the display is necessarily a graphic one. > At least one Emacs configuration violates this assumption. I see. --- a/lisp/subr.el +++ b/lisp/subr.el @@ -933,8 +933,10 @@ and `event-end' functions." (x (/ (car pair) (frame-char-width frame))) (y (/ (cdr pair) (+ (frame-char-height frame) (or (frame-parameter frame 'line-spacing) - ;; FIXME: Why the `default'? - (default-value 'line-spacing) + (when (display-graphic-p + (frame-terminal frame)) + ;; FIXME: Why the `default'? + (default-value 'line-spacing)) 0))))) (cons x y)))))) regards, Nikolaj Schumacher