unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: Alan Third <alan@idiocy.org>
Cc: Tak Kunihiro <tkk@misasa.okayama-u.ac.jp>, 34710@debbugs.gnu.org
Subject: bug#34710: the mode line flicks on set-window-vscroll
Date: Wed, 06 Mar 2019 10:13:21 +0100	[thread overview]
Message-ID: <m2r2bkweku.fsf@gmail.com> (raw)
In-Reply-To: <20190306080622.GA22588@breton.holly.idiocy.org> (Alan Third's message of "Wed, 6 Mar 2019 08:06:22 +0000")

Alan Third <alan@idiocy.org> writes:

> On Tue, Mar 05, 2019 at 06:09:41PM +0100, Robert Pluim wrote:
>> Robert Pluim <rpluim@gmail.com> writes:
>> 
>> > so not 4k, and I normally run with multiple non-maximized frames (but
>> > my testing was with a single default frame).
>> 
>> So Iʼve decided that this was all down to key-repeat rate. I had that
>> set to maximum already, but I went into system preferences, set it
>> lower, exited emacs, set it back, and now emacs with your patch is OK.
>
> Good to know, but still sounds like performance could be improved.
>
> And I still can’t replicate it. Perhaps it’s a combination of multiple
> factors.
>
> Can you try this patch and see if it improves anything, please?
>
> modified   src/nsterm.m
> @@ -1168,7 +1168,6 @@ static NSRect constrain_frame_rect(NSRect frameRect, bool isFullscreen)
>  
>  #ifdef NS_IMPL_COCOA
>    [NSGraphicsContext setCurrentContext:nil];
> -  [view display];
>  #else
>    block_input ();
>  
> It’s possible this will cause it to drop frames and make things worse.

That makes no perceptible difference in my not-too-accurate test,
which is scrolling my org-file using C-n from top to bottom: ≅ 17
seconds in both cases.

Robert





  reply	other threads:[~2019-03-06  9:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-02 10:25 bug#34710: the mode line flicks on set-window-vscroll Tak Kunihiro
2019-03-02 20:10 ` Alan Third
2019-03-03  4:15   ` Tak Kunihiro
2019-03-04  9:06   ` Robert Pluim
2019-03-04 19:25     ` Alan Third
2019-03-04 21:07       ` Robert Pluim
2019-03-04 22:45         ` Alan Third
2019-03-05  9:06           ` Robert Pluim
2019-03-05 17:09             ` Robert Pluim
2019-03-06  8:06               ` Alan Third
2019-03-06  9:13                 ` Robert Pluim [this message]
2019-03-07  0:25 ` Tak Kunihiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2r2bkweku.fsf@gmail.com \
    --to=rpluim@gmail.com \
    --cc=34710@debbugs.gnu.org \
    --cc=alan@idiocy.org \
    --cc=tkk@misasa.okayama-u.ac.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).