From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#36166: 27.0.50; Crash visiting HELLO when fringe-mode is disabled Date: Tue, 11 Jun 2019 17:32:50 +0200 Message-ID: References: <83ftog9ozy.fsf@gnu.org> <838su89nh1.fsf@gnu.org> <837e9s9m8o.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="227879"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36166@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 11 17:44:23 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1haiwf-000x7e-LO for geb-bug-gnu-emacs@m.gmane.org; Tue, 11 Jun 2019 17:44:21 +0200 Original-Received: from localhost ([::1]:60416 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1haiwe-0000tc-HA for geb-bug-gnu-emacs@m.gmane.org; Tue, 11 Jun 2019 11:44:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60013) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hailn-0000lA-R4 for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2019 11:33:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hailk-0003Z7-0H for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2019 11:33:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46482) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1haili-0003Xe-5G for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2019 11:33:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hailh-0007rv-Vq for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2019 11:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Jun 2019 15:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36166 X-GNU-PR-Package: emacs Original-Received: via spool by 36166-submit@debbugs.gnu.org id=B36166.156026718030240 (code B ref 36166); Tue, 11 Jun 2019 15:33:01 +0000 Original-Received: (at 36166) by debbugs.gnu.org; 11 Jun 2019 15:33:00 +0000 Original-Received: from localhost ([127.0.0.1]:60026 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hailg-0007rf-5i for submit@debbugs.gnu.org; Tue, 11 Jun 2019 11:33:00 -0400 Original-Received: from mail-ed1-f42.google.com ([209.85.208.42]:35718) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1haile-0007rT-IJ for 36166@debbugs.gnu.org; Tue, 11 Jun 2019 11:32:59 -0400 Original-Received: by mail-ed1-f42.google.com with SMTP id p26so16703263edr.2 for <36166@debbugs.gnu.org>; Tue, 11 Jun 2019 08:32:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=U3EEEE0bHYaQpM8F5kUWULyzw43mhAW3CFqgl6gNaWg=; b=pdg7lpcGB65lZfEY4LgPNPi8Abg7kmcWaAz7C6+DER8jtjjkrNFQWGa7AgcDEM5h+Z W4JsABpI1pTg5IsFhUFil9KRQojLEIj6zQymkoZ9L6SF7nxeSmwu+K3AAu1bbBNDAgXn 5hBzUcSTjkivLRgxl7T0jhRp04y1iNoARDSwMw/LyMp6toenF9kMooF+YbQRYexEW+IQ BJYDQgrYZVM32jw+o18jmMfwUZk3MoDg/gbEDM81sKV+VInKqDwJ7R4czErGkqO5jLr0 Jf0C9mwLdQWmyWW5wOzK01K+kHk6DQ29A4RUkbSnbGpGQaEYt/s05CE/MgmjkHKn2Hn+ ogQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=U3EEEE0bHYaQpM8F5kUWULyzw43mhAW3CFqgl6gNaWg=; b=Fmn6IkVX17xJqf2sS4sTSjrTpopQEG+t/atbUkFL+zysEDWlsihfDQpfF4e0kp2UzR GQbxWXd2Gm1ybP9Jg8kBSmGMzD6j6p+tH2NWrnCqAJWH8pcWygDZ3NfG+2Ov6kqaicFO KlmwGY4wrDpjN+yhMVu7pY1ndUAPDGQ/oyTJy1MDzE+QCHr4hJbHu+zV+q8LixS/0bWV 66r5mkNj9bkU5gBMPV2aVUwaS/R34uKvgaLKE6da5+jWWlrIHhh/sMUldHvCVwWnr725 q21Eb1rd80eBCcT8Od2CLOw69ThAy9/lJuUPp/8/DssMuG9VfYlhHS32q95+iO2CF9+Q 6OlQ== X-Gm-Message-State: APjAAAV3XRytd5jBEVPZ6sWbEDnnJhsOOU36GHGPlmq5pmtitslQs/0r vzYfxO98C5xBKJGl1+HmL8q66/lJTes= X-Google-Smtp-Source: APXvYqyrhbDrmqN4/hwfeR56A8JT/qQmJJuzkMibXrM2UMLxAm8WpN3+UnX1RL/ykuKEb3rTI7+O5Q== X-Received: by 2002:a17:906:db:: with SMTP id 27mr9166172eji.153.1560267172126; Tue, 11 Jun 2019 08:32:52 -0700 (PDT) Original-Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id w50sm3782362edb.60.2019.06.11.08.32.50 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 11 Jun 2019 08:32:51 -0700 (PDT) In-Reply-To: <837e9s9m8o.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 11 Jun 2019 18:26:31 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160379 Archived-At: >>>>> On Tue, 11 Jun 2019 18:26:31 +0300, Eli Zaretskii said: >> From: Robert Pluim >> Cc: 36166@debbugs.gnu.org >> Date: Tue, 11 Jun 2019 17:17:40 +0200 >>=20 Eli> I think the important part is the test of s->font_not_found_p. Can Eli> you see whether it's zero in the crash case? >>=20 >> Yes, it=CA=BCs 0. Eli> Thanks. So I think this: Eli> if (EQ (font->driver->type, Qns)) Eli> should be amended like this: Eli> if (!s->font_not_found_p && EQ (font->driver->type, Qns)) Are you sure? if font_not_found_p =3D=3D 0, then this condition will be true, and font =3D=3D NULL here, so we get a crash. Robert