From: Robert Pluim <rpluim@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 36166@debbugs.gnu.org
Subject: bug#36166: 27.0.50; Crash visiting HELLO when fringe-mode is disabled
Date: Tue, 11 Jun 2019 17:32:50 +0200 [thread overview]
Message-ID: <m2r280w319.fsf@gmail.com> (raw)
In-Reply-To: <837e9s9m8o.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 11 Jun 2019 18:26:31 +0300")
>>>>> On Tue, 11 Jun 2019 18:26:31 +0300, Eli Zaretskii <eliz@gnu.org> said:
>> From: Robert Pluim <rpluim@gmail.com>
>> Cc: 36166@debbugs.gnu.org
>> Date: Tue, 11 Jun 2019 17:17:40 +0200
>>
Eli> I think the important part is the test of s->font_not_found_p. Can
Eli> you see whether it's zero in the crash case?
>>
>> Yes, itʼs 0.
Eli> Thanks. So I think this:
Eli> if (EQ (font->driver->type, Qns))
Eli> should be amended like this:
Eli> if (!s->font_not_found_p && EQ (font->driver->type, Qns))
Are you sure? if font_not_found_p == 0, then this condition will be
true, and font == NULL here, so we get a crash.
Robert
next prev parent reply other threads:[~2019-06-11 15:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 8:15 bug#36166: 27.0.50; Crash visiting HELLO when fringe-mode is disabled Robert Pluim
2019-06-11 14:26 ` Eli Zaretskii
2019-06-11 14:51 ` Robert Pluim
2019-06-11 14:59 ` Eli Zaretskii
2019-06-11 15:17 ` Robert Pluim
2019-06-11 15:26 ` Eli Zaretskii
2019-06-11 15:32 ` Robert Pluim [this message]
2019-06-11 15:53 ` Eli Zaretskii
2022-01-29 14:52 ` Lars Ingebrigtsen
2022-01-30 15:01 ` Robert Pluim
2022-01-30 16:09 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2r280w319.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=36166@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).