From: "Gerd Möllmann" <gerd.moellmann@gmail.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 50629@debbugs.gnu.org, Mike Kupfer <mkupfer@alum.berkeley.edu>
Subject: bug#50629: 28.0.50; hard to debug an uncaught error with ert
Date: Fri, 26 Aug 2022 15:52:47 +0200 [thread overview]
Message-ID: <m2r113qfgw.fsf@Mini.fritz.box> (raw)
In-Reply-To: <87pmgncjvg.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 26 Aug 2022 13:41:23 +0200")
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Mike Kupfer <mkupfer@alum.berkeley.edu> writes:
>
>> Knowing that error "bar" was raised is helpful, but in a more realistic
>> test scenario, it can take some time to figure out where the error was
>> raised. Setting debug-on-error to t doesn't help (does ert hijack the
>> normal error handling mechanisms?).
>
> (I'm going through old bug reports that unfortunately weren't resolved
> at the time.)
>
> I'm not that familiar with ert internals, but yes, I think that's
> basically what ert does -- it hijacks the error/debug reporting system
> to implement the `should' macros.
>
> I've briefly poked at this now, but without any success in getting
> better backtraces for actual errors (which would indeed be very nice to
> have).
>
> Anybody more familiar with ert.el know how this can be achieved?
Not exactly this, I guess, but maybe as source of an idea?
diff --git a/lisp/emacs-lisp/ert.el b/lisp/emacs-lisp/ert.el
index 047b0069bb..1ffa0b5929 100644
--- a/lisp/emacs-lisp/ert.el
+++ b/lisp/emacs-lisp/ert.el
@@ -1495,6 +1495,8 @@ ert-run-tests-batch
(let ((print-escape-newlines t)
(print-level ert-batch-print-level)
(print-length ert-batch-print-length))
+ (ert--pp-with-indentation-and-newline
+ (ert-test-result-with-condition-should-forms result))
(ert--pp-with-indentation-and-newline
(ert-test-result-with-condition-condition result)))
(goto-char (1- (point-max)))
leads to output
Test f condition:
(((should
(equal 42
(foo)))
:form
(signal void-function
(bar))))
(void-function bar)
next prev parent reply other threads:[~2022-08-26 13:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 23:28 bug#50629: 28.0.50; hard to debug an uncaught error with ert Mike Kupfer
2022-08-26 11:41 ` Lars Ingebrigtsen
2022-08-26 13:52 ` Gerd Möllmann [this message]
2022-08-27 13:20 ` Lars Ingebrigtsen
2022-08-27 13:44 ` Gerd Möllmann
2022-08-27 13:52 ` Lars Ingebrigtsen
2022-08-27 14:06 ` Gerd Möllmann
2022-08-27 14:29 ` Lars Ingebrigtsen
2022-08-27 14:38 ` Mike Kupfer
2022-08-27 14:40 ` Lars Ingebrigtsen
2022-08-27 15:13 ` Gerd Möllmann
2022-08-28 1:21 ` Ihor Radchenko
2022-08-28 9:27 ` Gerd Möllmann
2022-08-28 10:03 ` Lars Ingebrigtsen
2022-08-28 10:31 ` Gerd Möllmann
2022-08-28 10:43 ` Gerd Möllmann
2022-08-28 12:25 ` Gerd Möllmann
2022-08-29 14:46 ` Lars Ingebrigtsen
2022-08-29 15:20 ` Gerd Möllmann
2022-08-29 15:28 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2r113qfgw.fsf@Mini.fritz.box \
--to=gerd.moellmann@gmail.com \
--cc=50629@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=mkupfer@alum.berkeley.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).