From: George Huebner <george@feyor.sh>
To: 72104@debbugs.gnu.org
Subject: bug#72104: [PATCH] xwidget: Fix xwidget-at misinterpreting non-xwidget text-properties
Date: Sun, 14 Jul 2024 02:19:23 -0500 [thread overview]
Message-ID: <m2r0bw30g4.fsf@feyor.sh> (raw)
[-- Attachment #1: Type: text/plain, Size: 1300 bytes --]
Tags: patch
xwidget-at assumes the text-property at `point-min` either doesn't
exist or is an xwidget, and can improperly access fields. This
patch just returns nil if the text-property isn't an xwidget.
This is definitely an edge case; I use a package called org-modern
where headlines are formatted with text-properties, which is how I
found the bug:
Debugger entered--Lisp error: (wrong-type-argument listp #("◉" 0 1
(face org-modern-symbol)))
xwidget-at(1)
xwidget-webkit-current-session()
In GNU Emacs 29.1 (build 1, aarch64-apple-darwin23.4.0, Carbon
Version
170 AppKit 2487.5)
Windowing system distributor 'Apple Inc.', version 14.4.0
System Description: macOS 14.4
Configured using:
'configure
--prefix=/nix/store/ismv7jzf3hcqziq5bpjfs54zd4qfjjn7-emacs-mac-macport-29.1
--disable-build-details --with-modules --without-gif
--without-jpeg
--without-png --without-tiff --without-x --without-xpm
'--enable-mac-app=$$out/Applications' --with-gnutls --with-mac
--with-xml2 --without-ns --with-compress-install
--with-toolkit-scroll-bars --with-native-compilation
--without-imagemagick --with-mailutils --without-small-ja-dic
--with-tree-sitter --without-xinput2 --without-xwidgets
--without-dbus
--without-selinux --with-xwidgets'
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-xwidget-Fix-xwidget-at-misinterpreting-non-xwidget-t.patch --]
[-- Type: text/patch, Size: 909 bytes --]
From 48a662563bc6e7c5bc63dc63da4e0c36909b6cc2 Mon Sep 17 00:00:00 2001
From: George Huebner <george@feyor.sh>
Date: Sun, 14 Jul 2024 01:46:07 -0500
Subject: [PATCH] xwidget: Fix xwidget-at misinterpreting non-xwidget
text-properties
xwidget-open wrongly assumes the the text-property at min-position is an
xwidget, if it exists; the fix is just returning nil if the
text-property isn't an xwidget.
---
lisp/xwidget.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/xwidget.el b/lisp/xwidget.el
index bf5987d..c5a84db 100644
--- a/lisp/xwidget.el
+++ b/lisp/xwidget.el
@@ -81,7 +81,7 @@ This returns the result of `make-xwidget'."
(defun xwidget-at (pos)
"Return xwidget at POS."
(let* ((disp (get-text-property pos 'display))
- (xw (car (cdr (cdr disp)))))
+ (xw (ignore-errors (car (cdr (cdr disp))))))
(when (xwidget-live-p xw) xw)))
--
2.44.1
reply other threads:[~2024-07-14 7:19 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2r0bw30g4.fsf@feyor.sh \
--to=george@feyor.sh \
--cc=72104@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).