From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Gemini Lasswell Newsgroups: gmane.emacs.bugs Subject: bug#24700: 26.0.50; unimplemented cl-defstruct slot option :type used in Emacs source code Date: Sat, 15 Oct 2016 14:05:53 -0700 Message-ID: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1476565646 22266 195.159.176.226 (15 Oct 2016 21:07:26 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 15 Oct 2016 21:07:26 +0000 (UTC) To: 24700@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Oct 15 23:07:23 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bvWAf-0003QX-5C for geb-bug-gnu-emacs@m.gmane.org; Sat, 15 Oct 2016 23:07:09 +0200 Original-Received: from localhost ([::1]:53244 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bvWAh-0003uj-8n for geb-bug-gnu-emacs@m.gmane.org; Sat, 15 Oct 2016 17:07:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49524) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bvWAb-0003ue-FW for bug-gnu-emacs@gnu.org; Sat, 15 Oct 2016 17:07:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bvWAY-0007wD-9O for bug-gnu-emacs@gnu.org; Sat, 15 Oct 2016 17:07:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54758) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1bvWAY-0007w7-5a for bug-gnu-emacs@gnu.org; Sat, 15 Oct 2016 17:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bvWAX-0002b2-TR for bug-gnu-emacs@gnu.org; Sat, 15 Oct 2016 17:07:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gemini Lasswell Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Oct 2016 21:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 24700 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.14765656029953 (code B ref -1); Sat, 15 Oct 2016 21:07:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 15 Oct 2016 21:06:42 +0000 Original-Received: from localhost ([127.0.0.1]:60948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bvWAE-0002aT-BU for submit@debbugs.gnu.org; Sat, 15 Oct 2016 17:06:42 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:58503) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bvWAC-0002aF-0T for submit@debbugs.gnu.org; Sat, 15 Oct 2016 17:06:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bvWA5-0007ky-TI for submit@debbugs.gnu.org; Sat, 15 Oct 2016 17:06:34 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:44492) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bvWA5-0007ks-QV for submit@debbugs.gnu.org; Sat, 15 Oct 2016 17:06:33 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49468) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bvWA4-0003uM-MI for bug-gnu-emacs@gnu.org; Sat, 15 Oct 2016 17:06:33 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bvWA1-0007jq-Hp for bug-gnu-emacs@gnu.org; Sat, 15 Oct 2016 17:06:32 -0400 Original-Received: from aibo.runbox.com ([91.220.196.211]:53866) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bvWA1-0007it-71 for bug-gnu-emacs@gnu.org; Sat, 15 Oct 2016 17:06:29 -0400 Original-Received: from [10.9.9.213] (helo=mailfront13.runbox.com) by bars.runbox.com with esmtp (Exim 4.71) (envelope-from ) id 1bvW9z-0007UY-4A for bug-gnu-emacs@gnu.org; Sat, 15 Oct 2016 23:06:27 +0200 Original-Received: from c-24-22-244-161.hsd1.wa.comcast.net ([24.22.244.161] helo=rainbow.local) by mailfront13.runbox.com with esmtpsa (uid:179284 ) (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) id 1bvW9c-0004iY-Gi for bug-gnu-emacs@gnu.org; Sat, 15 Oct 2016 23:06:04 +0200 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:124527 Archived-At: The only slot option implemented in Emacs Lisp for cl-defstruct is :read-only, according to the documentation. However there exists code in the Emacs source tree which uses the :type option as in Common Lisp. My (possibly incomplete) search found it in the following files: emacs-lisp/cl-generic.el emacs-lisp/cl-preloaded.el emacs-lisp/eieio-core.el emacs-lisp/ert.el erc/erc-backend.el gnus/nnmaildir.el The code for cl-defstruct ignores any keyword other than :read-only, but the problem is that since :type is not included in the edebug spec for cl-defstruct's slot options, edebug and testcover give errors when asked to instrument these files. To reproduce: 1. emacs -Q 2. M-x edebug-all-defs RET 3. C-x C-f lisp/emacs-lisp/cl-generic.el RET 4. M-x eval-buffer RET In GNU Emacs 26.0.50.2 (x86_64-apple-darwin15.6.0, NS appkit-1404.47 Version 10.11.6 (Build 15G1004)) of 2016-10-14 built on rainbow.local Windowing system distributor 'Apple', version 10.3.1404 Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Edebugging all definitions is on. edebug-syntax-error: Invalid read syntax: "Failed matching", ("cl-defstruct" [&or symbolp (gate symbolp &rest [&or symbolp (&or [":conc-name" symbolp] [":constructor" symbolp &optional cl-lambda-list] [":copier" symbolp] [":predicate" symbolp] [":include" symbolp &rest sexp] [":print-function" sexp] [":type" symbolp] [":named"] [":initial-offset" natnump])])] [&optional stringp] &rest &or symbolp (symbolp def-form &optional ":read-only" sexp)) Configured using: 'configure --with-ns' Configured features: JPEG RSVG IMAGEMAGICK NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Emacs-Lisp Minor modes in effect: diff-auto-refine-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message subr-x puny dired dired-loaddefs format-spec rfc822 mml mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils cl-macs vc-git diff-mode easy-mmode map seq byte-opt gv bytecomp byte-compile cl-extra help-mode cconv edebug easymenu cl-loaddefs pcase cl-lib time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/ns-win ns-win ucs-normalize term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote kqueue cocoa ns multi-tty make-network-process emacs) Memory information: ((conses 16 214195 19525) (symbols 48 21023 0) (miscs 40 46 192) (strings 32 21113 4927) (string-bytes 1 657659) (vectors 16 35806) (vector-slots 8 677585 4828) (floats 8 183 222) (intervals 56 396 16) (buffers 976 12))