From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Toon Claes Newsgroups: gmane.emacs.bugs Subject: bug#26298: 26.0.50; Gnus fails to sign mail with PGP Date: Sat, 14 Apr 2018 08:52:18 +0200 Message-ID: References: <871sod1zmz.fsf@users.sourceforge.net> <87h92cp9dh.fsf@wilson.bronger.org> <87vaflk79l.fsf@users.sourceforge.net> <871sflwg82.fsf@mouse.gnus.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Trace: blaine.gmane.org 1523688672 4295 195.159.176.226 (14 Apr 2018 06:51:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 14 Apr 2018 06:51:12 +0000 (UTC) Cc: 26298@debbugs.gnu.org, Noam Postavsky , Torsten Bronger To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 14 08:51:07 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f7F1e-00011H-F3 for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Apr 2018 08:51:06 +0200 Original-Received: from localhost ([::1]:37667 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f7F3l-0005vF-5c for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Apr 2018 02:53:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59760) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f7F3b-0005uL-VH for bug-gnu-emacs@gnu.org; Sat, 14 Apr 2018 02:53:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f7F3Y-00087Z-BG for bug-gnu-emacs@gnu.org; Sat, 14 Apr 2018 02:53:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43400) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f7F3Y-000876-3M for bug-gnu-emacs@gnu.org; Sat, 14 Apr 2018 02:53:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f7F3W-0004Zk-20; Sat, 14 Apr 2018 02:53:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <87h92cp9dh.fsf@wilson.bronger.org> Resent-From: Toon Claes Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Sat, 14 Apr 2018 06:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26298 X-GNU-PR-Package: emacs,gnus X-GNU-PR-Keywords: Original-Received: via spool by 26298-submit@debbugs.gnu.org id=B26298.152368875417532 (code B ref 26298); Sat, 14 Apr 2018 06:53:02 +0000 Original-Received: (at 26298) by debbugs.gnu.org; 14 Apr 2018 06:52:34 +0000 Original-Received: from localhost ([127.0.0.1]:51296 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f7F30-0004Yc-Sq for submit@debbugs.gnu.org; Sat, 14 Apr 2018 02:52:34 -0400 Original-Received: from smtp.soverin.net ([94.130.159.233]:60608 helo=g02sm01.soverin.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f7F2v-0004YF-K1 for 26298@debbugs.gnu.org; Sat, 14 Apr 2018 02:52:29 -0400 Original-Received: from soverin.net by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=iotcl.com; s=default; t=1523688739; bh=ZOH+x4Q+5PwBpAYUUyYCJ4RD45FRjpozWwgp+P/eEqE=; h=From:To:Cc:Subject:References:Date:From; b=u+hETMCnSlRTIFZjCCGYArGO/byL2T7UDdsBQkTCoBe1lQ/cbrZyqGWGRQoeFu14H lTl9lxtCwNkoysckipD31QboHiBbqRSKu6J6jICXyVWPskD6pv5eThvMad5O2PVQoo yPKzQLa3IuPk4wqP3tB4WVcjEp1titd6bOI65zD4= X-Virus-Scanned: clamav-milter 0.99.2 at g02sm01 X-Virus-Status: Clean X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:145326 Archived-At: --=-=-= Content-Type: text/plain Lars Ingebrigtsen writes: > Noam Postavsky writes: > >> --- i/lisp/gnus/mml1991.el >> +++ w/lisp/gnus/mml1991.el >> @@ -277,6 +277,8 @@ mml1991-epg-sign >> (mm-decode-content-transfer-encoding cte))) >> (let* ((pair (mml-secure-epg-sign 'OpenPGP 'clear)) >> (signature (car pair))) >> + (unless (stringp signature) >> + (error "Signature failed")) >> (delete-region (point-min) (point-max)) >> (insert >> (with-temp-buffer > > I've applied this patch to Emacs 27.1. I've built 20c6a516ec (which contains ef2059e877), and now I'm getting "Signature failed" whenever I'm trying to sign an email. Independent if my passphrase was correct or not. As a matter of fact, it no longer giving me the possibility to fill in my passphrase in the minibuffer. So I'm getting a proper error now, but my original problem is not resolved. TBH I'm getting a bit lost in the maze of bugs: - #26298: (this one) - #30363: epa-decrypt-file not using epa-pinentry-mode - #23619: Some epg tests fail Anyway, the patch provided in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=23619#14 does solve my problem. But as Noam mentioned, I am not sure "it's the right thing". -- Toon --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEqpqkV/lEuXKD1KF3MRQ6gtMrOJcFAlrRpSIACgkQMRQ6gtMr OJdMXBAAmP9nzrBqeplY38J/2iurgQIE9abeyUFXcTTqvI38SFtm0b1tklZUgAY8 hHoTPYAW1xnKArqI3+GMYZrBE+i32OuiNJ896e5BCl6tF/l5BdfRsaeUSfjt/2Tn 8jGplD8Suv0AWc3RVNPSnFzVwFoXY1M2sNjCUCc3h6AQHdjg6nXVetYa7wegse8F emkAd6jsZc4yqV/E3fM27TQ5WRWX5gq/o6Aj89Y+cHUD9yGWHEJiciv6D8tga8xG t3eaCfb9i3f7nYGha9zzbpyIFpLWtup8Eg7diOx+h4wvGYFXMsSOFiIUMrOgfIpV kBYsa9AtqtZSU5VnhAcx29+KcmzsScqAQ2afb3e0Aei5nLAn7VMckyfH2+FaxJSX mwsRXG9RbBQgyoLL1WYtcbskemm2xRBHTOJMv1yBxz7TmoAcTOo5hGsUiYlZDa2R xRpkVvUuhDflZLVY30IvKN8IRqqUCt38bDq+waMsCKbDfULDaLVFNNsKiHPY9mEj BtaVWy7Ag068WemLDiQ0sPtrO4DdegBJo7W0bqhBoxsp3dMTEt+TyXpnzcVILcwd 37cN6GtSvybH63vrTgRthnzM7g1QhwSpMMJ2WIizQKVziJmRW4qtv16yLoqcETpa rsPZrI//MTFBHFceZKLFqX/jBfW02p9hMc3rlbpHOefDzAUg838= =OejA -----END PGP SIGNATURE----- --=-=-=--