From: Robert Pluim <rpluim@gmail.com>
To: Kazuhiro Ito <kzhr@d1.dion.ne.jp>
Cc: 40343@debbugs.gnu.org
Subject: bug#40343: 28.0.50; dns-set-servers fails on IPv6 available Windows
Date: Wed, 01 Apr 2020 15:57:50 +0200 [thread overview]
Message-ID: <m2pncrz4td.fsf@gmail.com> (raw)
In-Reply-To: <86zhbvxqx3.wl--xmue@d1.dion.ne.jp> (Kazuhiro Ito's message of "Wed, 01 Apr 2020 22:43:20 +0900")
>>>>> On Wed, 01 Apr 2020 22:43:20 +0900, Kazuhiro Ito <kzhr@d1.dion.ne.jp> said:
Kazuhiro> Additionally, I have
Kazuhiro> question that whether we should consider the case nslookup doesn't
Kazuhiro> return DNS server address, i.e. the case that re-search-forward didn't
Kazuhiro> match anything. In that case, (match-string 1) at next line returns
Kazuhiro> inconstant value. But according to docstring of dns-set-servers,
Kazuhiro> dns-servers should be set to nil.
>>
>> The dns lookup will fail in either case, no? So Iʼm not sure it really
>> matters.
Kazuhiro> For example, when I tested on my standalone Debian (sid) box,
Kazuhiro> evaluating the below code just after starting Emacs returns annoying
Kazuhiro> result.
Kazuhiro> (progn
Kazuhiro> (require 'dns)
Kazuhiro> (dns-set-servers)
Kazuhiro> dns-servers)
-> ("c")
Yes, but the API exposed by dns.el is 'dns-query' (and maybe
'dns-query-cached'). 'dns-set-servers' should probably be called
'dns--set-servers' to indicate that itʼs an internal function.
Kazuhiro> We need to validate dns-servers's value to judge whether
Kazuhiro> dns-set-servers succeeded contorary docstring of dns-set-servers,
Kazuhiro> which says dns-servers is non-nil when dns-set-servers succeeded. I
Kazuhiro> think docstring or actual behavior of dns-set-servers should be fixed.
See previous paragraph: itʼs an internal function.
Kazuhiro> I noticed another problem in dns.el. dns-query function returns
Kazuhiro> message's string ("No DNS server configuration found") when
Kazuhiro> dns-servers is nil.
Yes, it should probably return nil, and this is actually a valid
reason for why 'dns-set-servers' should set dns-servers to nil on
failure. Can you determine why itʼs failing on your Debian box?
Robert
next prev parent reply other threads:[~2020-04-01 13:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-31 8:46 bug#40343: 28.0.50; dns-set-servers fails on IPv6 available Windows Kazuhiro Ito
2020-03-31 9:50 ` Robert Pluim
2020-03-31 11:06 ` Kazuhiro Ito
2020-03-31 13:01 ` Robert Pluim
2020-03-31 14:22 ` Kazuhiro Ito
2020-03-31 14:28 ` Robert Pluim
2020-04-01 13:43 ` Kazuhiro Ito
2020-04-01 13:57 ` Robert Pluim [this message]
2020-04-01 14:55 ` Kazuhiro Ito
2020-04-03 8:42 ` Robert Pluim
2020-04-03 14:08 ` Kazuhiro Ito
2020-04-03 15:19 ` Robert Pluim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2pncrz4td.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=40343@debbugs.gnu.org \
--cc=kzhr@d1.dion.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).