From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Andrii Kolomoiets Newsgroups: gmane.emacs.bugs Subject: bug#41531: 28.0.50; proper Eldoc async support Date: Thu, 04 Jun 2020 19:20:53 +0300 Message-ID: References: <87eeqwm101.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="63676"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (darwin) Cc: mvoteiza@udel.edu, 41531@debbugs.gnu.org, Stefan Monnier , Dmitry Gutov To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 04 18:22:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jgsd8-000GRm-GS for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Jun 2020 18:22:10 +0200 Original-Received: from localhost ([::1]:35390 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jgsd7-0000rA-Bq for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Jun 2020 12:22:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51496) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jgsd0-0000qm-St for bug-gnu-emacs@gnu.org; Thu, 04 Jun 2020 12:22:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35813) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jgsd0-0007b5-KG for bug-gnu-emacs@gnu.org; Thu, 04 Jun 2020 12:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jgsd0-0001su-G3 for bug-gnu-emacs@gnu.org; Thu, 04 Jun 2020 12:22:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrii Kolomoiets Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Jun 2020 16:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41531 X-GNU-PR-Package: emacs Original-Received: via spool by 41531-submit@debbugs.gnu.org id=B41531.15912876687173 (code B ref 41531); Thu, 04 Jun 2020 16:22:02 +0000 Original-Received: (at 41531) by debbugs.gnu.org; 4 Jun 2020 16:21:08 +0000 Original-Received: from localhost ([127.0.0.1]:47359 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jgsc8-0001rd-2G for submit@debbugs.gnu.org; Thu, 04 Jun 2020 12:21:08 -0400 Original-Received: from mail-lj1-f177.google.com ([209.85.208.177]:42733) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jgsc2-0001qm-Pm for 41531@debbugs.gnu.org; Thu, 04 Jun 2020 12:21:06 -0400 Original-Received: by mail-lj1-f177.google.com with SMTP id y11so6400611ljm.9 for <41531@debbugs.gnu.org>; Thu, 04 Jun 2020 09:21:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=a5XQyh4Jm1hMe8Xdtol2G2P1KkSyxrWcA4gLfuCFPq8=; b=Ia3PjM584cX6Y9LmEwPkl8eNikkHZAZwe0n0A08l7eKIhOh/h38p4U1DNIx2xiQpMO yRWGsk7z77cO8GCIFU0OQVbbmS7A853+S/+Xuq36EDsKGLxjZFoUTTqqkfqvIXwSeZZ3 /g9WKrBztDns6iuO1nzblLen2NFrQJ321O7UlO42njNworKBDGYpA570rAkzfTkX2x8w L0U3J96vuME2LiZJIxD4oEFYXRFZcYLU79VMu5/pMZ53UhJ5TaFHfZ3esj8ynp/aEwbj LCS+3g32UHKx4G8D9ZJT8+m6AVs6spHzKJlEqB1G/60ffKpq1dd+IYiXrYU28JuD94o7 WBoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=a5XQyh4Jm1hMe8Xdtol2G2P1KkSyxrWcA4gLfuCFPq8=; b=aQ7UY/XshHKfxgsuDjQ9pihpbfq99n4vIUWGSfM/cYWOC5lWPfhxaeq680Csi6FPYn 1mSBWtF67nGCEbVglb7UYkA0JOwu70Zzo1qZETaE+nfPLZl9Rx6UN5OOXumnw2meEeHm 67WJJ/PZWt24e/kUNXonYNQ6xm341fdipod6m4ZSbMdRTLSCg1clNpJIITECHEIyrn7J ahoUlG7oiu4Lwt23gTr2PkRm3QK5Vsh8CGvG5l+ofUQv9/oe5FG/Jtlx3IM5aVa2Kv6V qKRjkBFnxPN7TfNk362aSwlqxE2skIGP1SzJEsBlgBosCzAzC3yRaGV72pp03h7UVg+g nlOg== X-Gm-Message-State: AOAM530gTfTQ30Fvnwz3joSXLQKAeLIrBWbHtuCJJ0m7+hy2PMJAvWb/ NwTomBsUq6+X6awU2JK24kOAU6gxnmQ= X-Google-Smtp-Source: ABdhPJxC6b6OJoUT1f05daJkBbnO7i0bJB7LOYZQ/zrZlMbNBFiUGf5FwqU23peA3QAfR1GWBK16Jg== X-Received: by 2002:a05:651c:93:: with SMTP id 19mr2614955ljq.245.1591287655744; Thu, 04 Jun 2020 09:20:55 -0700 (PDT) Original-Received: from muffinmac.local ([91.206.110.130]) by smtp.gmail.com with ESMTPSA id f22sm13169ljn.28.2020.06.04.09.20.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jun 2020 09:20:54 -0700 (PDT) In-Reply-To: <87eeqwm101.fsf@gmail.com> ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Wed, 03 Jun 2020 19:56:46 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181516 Archived-At: Jo=C3=A3o T=C3=A1vora writes: > Hello again gang, Hi Jo=C3=A3o, > When applied, these improvements result in a substantial reduction of > Eglot's documentation handling code. Yes, Andrii, that means all our > hand-crafted, hard work of doc handling functions is soon gone, > including the awkward eglot-put-doc-in-help-buffer, > eglot-auto-display-help-buffer and the *eglot-help* buffer. > > Feels sad but also good, because deleted code is good code. And it's > not in vain because your feedback and testing was fundamental here. And > the good news is that the logic problems about blinking and giving > priority to some docs is gone. I for one completely support moving documentation handling code to eldoc. I was planning to remove the eglot-put-doc-in-help-buffer variable in the near future PR as well as the use of the eglot--message function for the documentation display ;-) However, after briefly using new Eldoc and Eglot I found some issues that, I hope, we can fix: 1. Display only first line of the hover info. Again :-) 2. The hover info is sometimes displayed right before the signature info making the echo area to "blink". I suppose this must be fixed on Eglot side by not requesting both the hover and the signature infos at the same time. 3. That IMO useless "...truncated, see *help* buffer" message is moved to Eldoc. Do we really need to show this message every time? That one last line can be used to show additional documentation. Hadn't a chance to take a closer look at the code, so reporting those issues is the most I can do for now. Thanks!