From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#46859: 28.0.50; [PATCH]: Add option to truncate long lines in xref.el Date: Wed, 03 Mar 2021 17:14:43 +0100 Message-ID: References: <87im69uzlt.fsf@mail.linkov.net> <878s74fv27.fsf@mail.linkov.net> Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23960"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 46859@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 03 17:16:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHUAV-00066L-LA for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 03 Mar 2021 17:16:11 +0100 Original-Received: from localhost ([::1]:56386 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHUAU-0002t0-IV for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 03 Mar 2021 11:16:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34914) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHU9V-0002c8-Ks for bug-gnu-emacs@gnu.org; Wed, 03 Mar 2021 11:15:10 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45193) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lHU9O-0005gJ-VL for bug-gnu-emacs@gnu.org; Wed, 03 Mar 2021 11:15:08 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lHU9O-0004LM-RV for bug-gnu-emacs@gnu.org; Wed, 03 Mar 2021 11:15:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Mar 2021 16:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46859 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 46859-submit@debbugs.gnu.org id=B46859.161478808816644 (code B ref 46859); Wed, 03 Mar 2021 16:15:02 +0000 Original-Received: (at 46859) by debbugs.gnu.org; 3 Mar 2021 16:14:48 +0000 Original-Received: from localhost ([127.0.0.1]:56737 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lHU9A-0004KN-C0 for submit@debbugs.gnu.org; Wed, 03 Mar 2021 11:14:48 -0500 Original-Received: from out1.migadu.com ([91.121.223.63]:18591) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lHU98-0004KE-BU for 46859@debbugs.gnu.org; Wed, 03 Mar 2021 11:14:47 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-Reply-To: <878s74fv27.fsf@mail.linkov.net> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: theo@thornhill.no X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201287 Archived-At: Hi Juri, Juri Linkov writes: >>> But maybe your new option would be easier to customize. >> >> Yeah, maybe. However, without benchmarking, it is quite clear that >> adding your option is faster than my patch, since ripgrep has to search >> the whole minified file. I assume it short circuits, so that results >> are delivered quicker to emacs. Maybe this bug can be closed. > > Your new option is still necessary for the default case when > 'xref-search-program' is 'grep' since GNU grep has no option > to truncate output, so xref should do post-processing for grep. Yeah, agreed -- Theo