From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Newsgroups: gmane.emacs.bugs Subject: bug#65344: 28.2; Unable to Edebug cl-flet form which uses argument destructuring Date: Wed, 23 Aug 2023 16:08:24 +0200 Message-ID: References: <5184DD53-F121-405D-AEE9-6E72E17127EA@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33808"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Michael Heerdegen , brandon.irizarry@gmail.com, Michael Albinus , 65344@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 23 16:09:34 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qYoY9-0008i5-RT for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 23 Aug 2023 16:09:33 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qYoXy-0000Oj-Vd; Wed, 23 Aug 2023 10:09:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qYoXc-0000Nr-05 for bug-gnu-emacs@gnu.org; Wed, 23 Aug 2023 10:09:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qYoXa-0007Gv-Mm for bug-gnu-emacs@gnu.org; Wed, 23 Aug 2023 10:08:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qYoXd-00051P-RS for bug-gnu-emacs@gnu.org; Wed, 23 Aug 2023 10:09:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Aug 2023 14:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65344 X-GNU-PR-Package: emacs Original-Received: via spool by 65344-submit@debbugs.gnu.org id=B65344.169279972219275 (code B ref 65344); Wed, 23 Aug 2023 14:09:01 +0000 Original-Received: (at 65344) by debbugs.gnu.org; 23 Aug 2023 14:08:42 +0000 Original-Received: from localhost ([127.0.0.1]:34833 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYoXJ-00050p-Nf for submit@debbugs.gnu.org; Wed, 23 Aug 2023 10:08:41 -0400 Original-Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]:42304) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYoXE-00050V-30 for 65344@debbugs.gnu.org; Wed, 23 Aug 2023 10:08:40 -0400 Original-Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-5298e43bb67so10411733a12.1 for <65344@debbugs.gnu.org>; Wed, 23 Aug 2023 07:08:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692799706; x=1693404506; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WxBaG6xlmJbZ5PsvUR3JXTNW+Z+mfO5xnYdC7f7yyFg=; b=agDujvGs6uUxbXgt+Oz9kbwqFLDgbWYnUeBYOqL93rNmVLIMVbMcw4SqbPfeIywgUN MKo403tVIqvHvYQzEXHKrz235UvD6CQfCmau9e0Up/Fl1MwFAxU+SbWA1OYxXZFdaV+K jo3VZWwGjQlqgW7N8xoDoCZr2lsy827ibOp+MfkjNzlI0X3NfPCYU3OiuC293TNv+u+g eBiwPovMIjyPA+gVLTK7bqmtHTqhWYA2pZ75JATC1keNOycWI7mQQi4PLU/MJpQkRg7e FqEovMkcnlOX2XI+l7TP+D0QEKpPZo2MSrfnVTiiP9L/dHMXnr1oVaXWo05Pjy9qhEU/ B6dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692799706; x=1693404506; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WxBaG6xlmJbZ5PsvUR3JXTNW+Z+mfO5xnYdC7f7yyFg=; b=d5w9mKhb5wFMqWwwsAENdwl4TGQlqj9uGV4y486V3zYBdpICalbAoJD6fYBvS/bA6/ Rya2ufnxi8KHE9V7TSWVBM57sRdXVIv8RTWuD4TYpuIL3SiNPumYUVccq0l6PRzsopAS 0Y11wtfBvSJHdaSNfoiLmgL38//9OaTRORFflqyD6f0LelzFKAju9qZw1M4YWG2BZM8h 0fiKr5kxLYDbEdIIT+pGz5kjneUJfhASU2SGyeA4wp34Xo+51ipBTBmsSYWASrqo2Opw GBNzIBr+mMk8zc0m7lP2ST4OSnJ4O6dmGiRxlrjAZv8N1kOSrB4MqyualAEfWeJXtZ0R 0BOA== X-Gm-Message-State: AOJu0YwMDlRtQAsQtOI/fy0uLEMWHpZTXoUuy0WSPtpyWGCXgv0nCdFl qyHndYgi49cT4xxIJGLWcn1aUOI9Ns+sY55u X-Google-Smtp-Source: AGHT+IEcqZSRSP94eYhOWWL5jF0pVcs85PCEEKLh3Hvu2mBvGRjEF28QvuZ3WWJuQxT+x9DVb7iiAw== X-Received: by 2002:aa7:d3d7:0:b0:521:d2ab:e4df with SMTP id o23-20020aa7d3d7000000b00521d2abe4dfmr14031589edr.19.1692799706220; Wed, 23 Aug 2023 07:08:26 -0700 (PDT) Original-Received: from Mini.fritz.box (p54b0c765.dip0.t-ipconnect.de. [84.176.199.101]) by smtp.gmail.com with ESMTPSA id v13-20020aa7d9cd000000b0052568bf9411sm9271325eds.68.2023.08.23.07.08.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Aug 2023 07:08:25 -0700 (PDT) In-Reply-To: ("Gerd =?UTF-8?Q?M=C3=B6llmann?="'s message of "Wed, 23 Aug 2023 13:10:19 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268245 Archived-At: Gerd M=C3=B6llmann writes: > Mattias Engdeg=C3=A5rd writes: > >>> Gerd, edebug-tests fail on master after your changes (cc0f546825). Woul= d you do something about that? >> >> And cl-macs-tests. > > Strange stuff, I guess I'll need some time to understand what is going > on. As a temporary measure I've reverted my last commit, the reversing > of the &defines. Maybe it's not so temporary after all. The problem seems to be the attempt to first match the spec (&define [&name symbolp "@cl-flet@"] [&name [] gensym] ;Make it unique! def-form)]) with (for example) (fn ((x y)) ...) or (fn (&rest x) ...) Edebug then matches def-form with ((x y)) or (&rest x), and it finds it doesn't match. I would have expected that this leads to backtracking and trying the second alternative of the &or, but that's not happening. So, at the moment we're kinda stuck with the situation that local functions that look like local-functions with empty body, like (cl-flet ((fn (...))) ...) are not instrumented like the cl-flet extension case. That's not a catastrphy, I guess.