From: "Gerd Möllmann" <gerd.moellmann@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: yantar92@posteo.net, 66743@debbugs.gnu.org
Subject: bug#66743: 30.0.50; Crash when dumping reftex
Date: Thu, 26 Oct 2023 10:04:19 +0200 [thread overview]
Message-ID: <m2pm113j3w.fsf@Pro.fritz.box> (raw)
In-Reply-To: <83lebphm4k.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 26 Oct 2023 10:35:23 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Gerd Möllmann <gerd.moellmann@gmail.com>
>> Cc: yantar92@posteo.net, 66743@debbugs.gnu.org
>> Date: Thu, 26 Oct 2023 09:03:33 +0200
>>
>> Gerd Möllmann <gerd.moellmann@gmail.com> writes:
>>
>> > Eli Zaretskii <eliz@gnu.org> writes:
>> >
>> >> Emacs is always dumped with a few buffers, because temacs needs them
>> >> to do the dumping. See this comment text from buffer.c:
>> >>
>> >> Implementation notes: the buffers we carry from temacs are:
>> >> " prin1", "*scratch*", " *Minibuf-0*", "*Messages*", and
>> >> " *code-conversion-work*". They are created by
>> >> init_buffer_once and init_window_once (which are not called
>> >> in the dumped Emacs), and by the first call to coding.c
>> >> routines.
>> >
>> > Thanks.
>> >
>> > So, one idea would be to try and move the creation of these buffers from
>> > the init_*_once functions to the "normal" init functions, and see what
>> > happens. One would also have to take a closer look at coding.c, of course.
>>
>> Actually, this is bug#59029, sort of.
>>
>> TLDR is that the code to dump itrees is there, somewhere in git, but has
>> an infinite recursion bug. So, I guess it should first be tried to
>> revive that code and fix it (tests should also exist, IIUC).
>
> Feel free to do that, of course.
It's only a maybe from me, so far :-). I mainly chimed in because I know
the pdumper from dumping CL packages, and I also know a bit about
itrees.
BTW, it turns out the code is actually already in master
(dump_interval_node), but isn't executed because of the abort.
> However, from where I stand, we should first find and fix the other
> bugs caused by re-dumping, of the kinds described in bugs 66741 and
> 66742 (there are more problems like that). Ideally, we need to
> understand why these problems happen, and develop a protocol for
> initializing things in a way that avoids such problems. Only after
> that should we turn our attention to more specific aspects like itrees
> etc. We should also have some policy for what should never be dumped,
> I think -- those will have to be nullified or deleted before dumping.
Of course.
next prev parent reply other threads:[~2023-10-26 8:04 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 9:46 bug#66743: 30.0.50; Crash when dumping reftex Ihor Radchenko
2023-10-25 12:46 ` Eli Zaretskii
2023-10-25 12:58 ` Ihor Radchenko
2023-10-25 14:44 ` Stefan Kangas
2023-10-26 9:31 ` Ihor Radchenko
2023-10-26 10:01 ` Gerd Möllmann
2023-10-26 11:55 ` Ihor Radchenko
2023-10-26 12:08 ` Eli Zaretskii
2023-10-26 12:14 ` Ihor Radchenko
2023-10-26 13:04 ` Eli Zaretskii
2023-10-26 13:13 ` Ihor Radchenko
2023-10-26 13:18 ` Eli Zaretskii
2023-10-26 13:27 ` Ihor Radchenko
2023-10-26 13:28 ` Eli Zaretskii
2023-10-26 13:48 ` Ihor Radchenko
2023-10-26 15:49 ` Eli Zaretskii
2023-10-27 9:08 ` Ihor Radchenko
2023-10-27 10:38 ` Eli Zaretskii
2023-10-27 10:55 ` Ihor Radchenko
2023-10-27 11:01 ` Eli Zaretskii
2023-10-27 11:09 ` Ihor Radchenko
2023-10-27 12:36 ` Eli Zaretskii
2023-10-27 12:45 ` Ihor Radchenko
2023-10-27 12:53 ` Eli Zaretskii
2023-10-25 16:15 ` Gerd Möllmann
2023-10-25 16:21 ` Eli Zaretskii
2023-10-25 16:37 ` Gerd Möllmann
2023-10-26 7:03 ` Gerd Möllmann
2023-10-26 7:35 ` Eli Zaretskii
2023-10-26 8:04 ` Gerd Möllmann [this message]
2023-10-26 9:38 ` Ihor Radchenko
2023-10-26 9:44 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2pm113j3w.fsf@Pro.fritz.box \
--to=gerd.moellmann@gmail.com \
--cc=66743@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).