bug#3020: 23.0.92; `previous-line' sometimes fails with overlays

bug#3020: 23.0.92; `previous-line' sometimes fails with overlays

[Markus Triska]

When I evaluate the following form in "emacs -Q":

   (progn
     (switch-to-buffer (get-buffer-create "test"))
     (insert "the first line\na ")
     (let ((o (make-overlay (point) (point))))
       (overlay-put
        o 'after-string
        (propertize (concat "very very very very very very very very "
                            "very very very very very very very very "
                            "long line") 'face '(:background "cyan"))))
     (insert "\nand the last line")
     (previous-line))

and then press C-p, point unexpectedly fails to move. However, when I
then press C-a C-n C-p C-p, the second C-p works as expected.


In GNU Emacs 23.0.92.1 (i386-apple-darwin9.6.1, GTK+ Version 2.14.7)
 of 2009-04-16 on mt-imac.local
Windowing system distributor `The X.Org Foundation', version 11.0.10402000
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

bug#3020: 23.0.92; `previous-line' sometimes fails with overlays

[Stephen Berman]

On Thu, 16 Apr 2009 20:34:23 +0200 Markus Triska <markus.triska@gmx.at> wrote:

> When I evaluate the following form in "emacs -Q":
>
>    (progn
>      (switch-to-buffer (get-buffer-create "test"))
>      (insert "the first line\na ")
>      (let ((o (make-overlay (point) (point))))
>        (overlay-put
>         o 'after-string
>         (propertize (concat "very very very very very very very very "
>                             "very very very very very very very very "
>                             "long line") 'face '(:background "cyan"))))
>      (insert "\nand the last line")
>      (previous-line))
>
> and then press C-p, point unexpectedly fails to move. However, when I
> then press C-a C-n C-p C-p, the second C-p works as expected.

Here are some further observations:

- The first C-p does not fail when the propertized string is short
  enough so that when point is at the end of the string it is visually
  below but crucially before any initial segment of the string.  To see
  this with window-width of 85 (else adjust accordingly) replace the
  second string of the concat above by each of the following, evalling
  and trying C-p in between:
      "very very very very very very very "
      "very very very very very very very  "

- The first C-p does not fail when the propertized string is alone on
  the line it starts on, i.e., not preceded by another string on the
  same line.  To see this replace the first inserted string by each of
  the following, evalling and trying C-p in between:
      "the first line\n "
      "the first line\n"

- The condition under which the second C-p works is when point is at a
  lower column number than the column at which the propertized string
  begins.  For example, in the above the propertized string begins at
  column 2, and the second C-p works if point is at column 0 or column 1
  when the movement from below begins; if point is at column 2 or
  higher, the second C-p fails.

- The previous observation recalls a problem with the invisible text
  property I noted in the context of a different, but perhaps related,
  bug; see
  http://thread.gmane.org/gmane.emacs.pretest.bugs/2194/focus=83503

Steve Berman

bug#3020: marked as done (23.0.92; `previous-line' sometimes fails with overlays)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 894 bytes --]


Your message dated Sat, 25 Apr 2009 11:29:21 -0400
with message-id <87y6to21m6.fsf@cyd.mit.edu>
and subject line Re: 23.0.92; `previous-line' sometimes fails with overlays
has caused the Emacs bug report #3020,
regarding 23.0.92; `previous-line' sometimes fails with overlays
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
3020: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3020
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 3288 bytes --]

From: Markus Triska <markus.triska@gmx.at>
To: emacs-pretest-bug@gnu.org
Subject: 23.0.92; `previous-line' sometimes fails with overlays
Date: Thu, 16 Apr 2009 20:34:23 +0200
Message-ID: <m2ocuwmor4.fsf@gmx.at>


When I evaluate the following form in "emacs -Q":

   (progn
     (switch-to-buffer (get-buffer-create "test"))
     (insert "the first line\na ")
     (let ((o (make-overlay (point) (point))))
       (overlay-put
        o 'after-string
        (propertize (concat "very very very very very very very very "
                            "very very very very very very very very "
                            "long line") 'face '(:background "cyan"))))
     (insert "\nand the last line")
     (previous-line))

and then press C-p, point unexpectedly fails to move. However, when I
then press C-a C-n C-p C-p, the second C-p works as expected.


In GNU Emacs 23.0.92.1 (i386-apple-darwin9.6.1, GTK+ Version 2.14.7)
 of 2009-04-16 on mt-imac.local
Windowing system distributor `The X.Org Foundation', version 11.0.10402000
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t




[-- Attachment #3: Type: message/rfc822, Size: 1287 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: Markus Triska <markus.triska@gmx.at>
Cc: 3020-done@emacsbugs.donarmstrong.com, Stephen Berman <stephen.berman@gmx.net>
Subject: Re: 23.0.92; `previous-line' sometimes fails with overlays
Date: Sat, 25 Apr 2009 11:29:21 -0400
Message-ID: <87y6to21m6.fsf@cyd.mit.edu>

> point unexpectedly fails to move. However, when I then press C-a C-n
> C-p C-p, the second C-p works as expected.

I've checked in a fix.  Thanks for noticing the problem.