From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Helmut Eller Newsgroups: gmane.emacs.bugs Subject: bug#25071: 26.0.50; Various Forth related improvements for etags Date: Wed, 30 Nov 2016 17:55:02 +0100 Message-ID: References: <83inr5q9i4.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1480524980 23385 195.159.176.226 (30 Nov 2016 16:56:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 30 Nov 2016 16:56:20 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: 25071@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 30 17:56:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cC8B1-0004gv-29 for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Nov 2016 17:56:11 +0100 Original-Received: from localhost ([::1]:45125 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cC8B5-0006I5-0E for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Nov 2016 11:56:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40926) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cC8Aw-0006FX-DF for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2016 11:56:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cC8As-0005Mg-Cu for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2016 11:56:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60546) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cC8As-0005Mb-95 for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2016 11:56:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cC8As-00030y-2L for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2016 11:56:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Helmut Eller Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Nov 2016 16:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25071 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 25071-submit@debbugs.gnu.org id=B25071.148052491611527 (code B ref 25071); Wed, 30 Nov 2016 16:56:02 +0000 Original-Received: (at 25071) by debbugs.gnu.org; 30 Nov 2016 16:55:16 +0000 Original-Received: from localhost ([127.0.0.1]:47712 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cC8A7-0002zr-Us for submit@debbugs.gnu.org; Wed, 30 Nov 2016 11:55:16 -0500 Original-Received: from mail-wj0-f175.google.com ([209.85.210.175]:33153) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cC8A6-0002zb-Bc for 25071@debbugs.gnu.org; Wed, 30 Nov 2016 11:55:14 -0500 Original-Received: by mail-wj0-f175.google.com with SMTP id xy5so180775994wjc.0 for <25071@debbugs.gnu.org>; Wed, 30 Nov 2016 08:55:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version; bh=L43RqwTT2GBmjThYeByDQACXFXIZCRMSpJduPLWR3Jo=; b=O6zgO9v5w/JKBFSU4xPFaEB5cgUx2a+pEdZLt2Ou23LGEZlTsRSowauxwy1dmlJIIt qIdynQbKhEGnD2nqbPAo8aBa5teJjsonpt24TzVW8uAoK3H9XTqZdgsY2ILEJTN1tP19 5JY/yZ9Ssh1PMayCn54j9LONTl5D5+nbnHB/0i7D+SZWX3mVMeNncAZuREe+v6IxEL36 OSTsnZaD2b+1L+jfnGwf7rH5VgIORmE8yHBGwgU9uTqs8Yqy3bzgPpOtWd2Kr0ECw2rX V++N7GIZdnaRi5tpKYv5vzYllFqDekEykhvRzmKBZ+AvxzVG4x6MNPyd4+B3uwCsQfND szPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version; bh=L43RqwTT2GBmjThYeByDQACXFXIZCRMSpJduPLWR3Jo=; b=LRYbETKBdQgynBQqbwB+E8XB+jBxvPT1huDPbVfYQ3SRaNBFVRKVr7pWZgDb/L4eIA M32VFws9UYYjFN89LAAhjiLLzSdYspdnIiHRLxuG6yhKsPoGg3KXx9gOXa4D6doBydh7 Fc2ncmgjN1XTwOlg9mUzs39AGydmHPIoL93HMpJ5zEFvWb6ChO2wr8ORqezTridO/6lG iAkEycWnyih7nJYOyj0K0tsXXwTFJW2tZaR+3fh1hAycj/AFsPGTTvmdbscMqIgCDvOJ eCZFifzCSytnTCubWv0TjS4Oh74gyP636jyE4xPyD4Kc5hyMQSKflmEmQtLorWUVymB6 jW/g== X-Gm-Message-State: AKaTC00CMfJRtOAVLu4qekIQxppDGBKhASkBRI/EZ2IGR2DwPksEw6g/++9qafuZfCQt3Q== X-Received: by 10.194.248.5 with SMTP id yi5mr29314721wjc.11.1480524906634; Wed, 30 Nov 2016 08:55:06 -0800 (PST) Original-Received: from caladan (dial-181252.pool.broadband44.net. [212.46.181.252]) by smtp.gmail.com with ESMTPSA id 6sm73728269wjt.5.2016.11.30.08.55.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Nov 2016 08:55:06 -0800 (PST) In-Reply-To: <83inr5q9i4.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 30 Nov 2016 17:21:07 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:126319 Archived-At: On Wed, Nov 30 2016, Eli Zaretskii wrote: >> With the patch, etags creates explicit tag names. That works better in >> combination with tag-exact-match-p. > > Can you explain more about this? Explicit tag names bloat the TAGS > files, so other languages don't use that by default, except where > really needed. Yes, the TAGS file becomes at most twice as big. That's a minor disadvantage that I'm happy to trade for even tiny improvements in precision. I also note that, Gforth (the GNU Forth implementation) ships a TAGS file for the built-in definitions with explicit tag names (usually installed in /usr/share/gforth//TAGS). They use the Gforth compiler, not etags, to create this TAGS file. Obviously they aren't bothered by the bloat either. > Could it be that only some tags need to be written as > explicit, e.g. because they contain some special characters? Yes, that's the main reason. E.g. with the old version a source file test.fth with this content: : (foo) 123 ; produced this TAGS file: test.fth,17 : (foo)(foo.1,0 Hmm, it already created explicit tag names before. But with "(foo" as name, which is wrong. The name should be "(foo)". In case your are not familiar with Forth syntax: names in Forth are separated by whitespace and can contain "(", ")", "," or other non-whitespace characters. A word in parentheses like "(foo)" is a widely used naming convention for internal/auxiliary definitions. The old version of etags.c used get_tag which uses notinname to find the end of the name, but that excludes ")", which is wrong for Forth. > Also, it sounds like you send a patch wrt emacs-25 branch; if so, > please rebase on master, since that is where the patch will be pushed > eventually. The test files are in a different place on master. The patch is against master, but I wrote the wrong filenames in the changelog, because I copied part of it from an old commit message. Helmut