From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: charles@aurox.ch (Charles A. Roelli) Newsgroups: gmane.emacs.bugs Subject: bug#28176: 26.0.50; Emacs hangs on entering a specific article in gnus Date: Wed, 23 Aug 2017 21:56:15 +0200 Message-ID: References: <83d17obyyc.fsf@gnu.org> <838ticbv5p.fsf@gnu.org> <83tw0zabb9.fsf@gnu.org> <83k21va05e.fsf@gnu.org> <20170823191050.GA36516@breton.holly.idiocy.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1503518247 10956 195.159.176.226 (23 Aug 2017 19:57:27 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 23 Aug 2017 19:57:27 +0000 (UTC) Cc: sds@gnu.org, 28176@debbugs.gnu.org, npostavs@users.sourceforge.net To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Aug 23 21:57:22 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dkbm4-00029U-NO for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 Aug 2017 21:57:13 +0200 Original-Received: from localhost ([::1]:45453 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dkbmB-00048p-Fy for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 Aug 2017 15:57:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37397) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dkblz-00048O-58 for bug-gnu-emacs@gnu.org; Wed, 23 Aug 2017 15:57:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dkblv-000157-5K for bug-gnu-emacs@gnu.org; Wed, 23 Aug 2017 15:57:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43063) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dkblv-00014z-1N for bug-gnu-emacs@gnu.org; Wed, 23 Aug 2017 15:57:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dkblu-0003LD-QI for bug-gnu-emacs@gnu.org; Wed, 23 Aug 2017 15:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: charles@aurox.ch (Charles A. Roelli) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Aug 2017 19:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28176 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28176-submit@debbugs.gnu.org id=B28176.150351819612797 (code B ref 28176); Wed, 23 Aug 2017 19:57:02 +0000 Original-Received: (at 28176) by debbugs.gnu.org; 23 Aug 2017 19:56:36 +0000 Original-Received: from localhost ([127.0.0.1]:51742 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dkblU-0003KL-8w for submit@debbugs.gnu.org; Wed, 23 Aug 2017 15:56:36 -0400 Original-Received: from sinyavsky.aurox.ch ([37.35.109.145]:41366) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dkblS-0003K8-Ko for 28176@debbugs.gnu.org; Wed, 23 Aug 2017 15:56:35 -0400 Original-Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id 61BCA22505 for <28176@debbugs.gnu.org>; Wed, 23 Aug 2017 19:50:37 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass (1024-bit key) reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= content-transfer-encoding:content-type:content-type:mime-version :references:subject:subject:in-reply-to:to:from:from:message-id :date:date; s=dkim; t=1503517836; x=1504381837; bh=O0hm4mo8JHYF/ UiNnXK9ApmqHa5y/PlOJ0tkj3tACqU=; b=fvEhKl8TK7OGGF/nxG3gFBO3t0zNL F9Zt/o0enyhgYGjaC6FT0G7yRnGVNG5FI/rRQppLUG4sZar5eKtwi2pGWtvKRlqx sph2DMtgoTpjDTpxwbmLXns32fzi4w3KCRt+ZwGIcSICuQHrX5d2IkgxDB6auvxs 3amH+QtnX9+Syg= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Original-Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Ca9CS-CPIEHy for <28176@debbugs.gnu.org>; Wed, 23 Aug 2017 19:50:36 +0000 (UTC) Original-Received: from gray (125.85.192.178.dynamic.wline.res.cust.swisscom.ch [178.192.85.125]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id 2D2B8224FE; Wed, 23 Aug 2017 19:50:35 +0000 (UTC) In-reply-to: <20170823191050.GA36516@breton.holly.idiocy.org> (message from Alan Third on Wed, 23 Aug 2017 20:10:50 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:136122 Archived-At: > Date: Wed, 23 Aug 2017 20:10:50 +0100 > From: Alan Third > > On Wed, Aug 23, 2017 at 04:29:35PM +0200, Charles A. Roelli wrote: > > Seems like this may be a side effect of a recent change adding GIF > > support in macOS (I'm CCing the author, Alan Third). > > I’m quite confused. I tested this against gifs and jpegs, and they > both worked fine. I never tested against pngs as I assumed, being > a single image format like jpeg, it would work the same. It seems that > jpegs are handled differently, though, as I stuck an fprintf in > ns_load_image and it didn’t print anything when I loaded a jpeg. > > Anyway, I’ve pushed a modification which fixes pngs while keeping > animated gifs working. Thanks! > > In nsimage.m:111 (ns_load_image), there is this call to add_to_log: > > > > add_to_log ("Unable to set index %d for image %s", index, img->spec); > > > > but img->spec is a Lisp_Object: > > > > (gdb) ptype img->spec > > type = struct Lisp_Object { > > EMACS_INT i; > > } > > > > Maybe "%s" doesn't cover Lisp_Objects? At any rate, that seems to be > > what the error message is about. > > This looks like it’s the same way it’s handled in image.c, so I don’t > know why it doesn’t work here. > > Unless it’s actually index that’s at fault since it’s *not* a > Lisp_Object? I think you're right. This prevents the PNG error from causing a hang for me (adding a call to make_number): add_to_log ("Unable to set index %d for image %s", make_number (index), img->spec); And *Messages* ends up with the right error: Unable to set index 0 for image (image :type png :data \211PNG^M... (followed by the raw image bytes)