From: charles@aurox.ch (Charles A. Roelli)
To: Alan Third <alan@idiocy.org>
Cc: 28222@debbugs.gnu.org
Subject: bug#28222: [Emacs-diffs] master fdde981 2/3: Fix cross macOS version building (bug#28222)
Date: Thu, 31 Aug 2017 21:09:03 +0200 [thread overview]
Message-ID: <m2o9qva71s.fsf@aurox.ch> (raw)
In-Reply-To: <20170831184709.GA9600@breton.holly.idiocy.org> (message from Alan Third on Thu, 31 Aug 2017 19:47:09 +0100)
> Date: Thu, 31 Aug 2017 19:47:09 +0100
> From: Alan Third <alan@idiocy.org>
>
> On Thu, Aug 31, 2017 at 08:40:47PM +0200, Charles A. Roelli wrote:
> > > Date: Tue, 29 Aug 2017 12:23:31 -0400 (EDT)
> > > From: alan@idiocy.org (Alan Third)
> > >
> > > branch: master
> > > commit fdde98113c5d1c2d4eb5c25fa750c976d90f8555
> > > Author: Alan Third <alan@idiocy.org>
> > > Commit: Alan Third <alan@idiocy.org>
> > >
> > > Fix cross macOS version building (bug#28222)
> > >
> > > * src/macfont.h (CGContextSetFontSmoothingStyle): Function
> > > declaration.
> > > * src/macfont.m (macfont_draw): Limit new code to macOS 10.8 and up.
> >
> > I should have mentioned this before: I tried the patch that implements
> > ns_use_thin_smoothing on 10.6, and it worked well. So it seems that
> > the function is available after all on 10.6+.
>
> Oh, excellent! I’ll remove the 10.8 stuff, then.
>
> I take it the function declaration in macfont.h is required, though?
> It’s needed on 10.12 or else we get a warning.
That's right, the declaration should stay. Thanks for taking care of
this.
next prev parent reply other threads:[~2017-08-31 19:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170829162330.12288.81050@vcs0.savannah.gnu.org>
[not found] ` <20170829162331.5C2602092B@vcs0.savannah.gnu.org>
2017-08-31 18:40 ` bug#28222: [Emacs-diffs] master fdde981 2/3: Fix cross macOS version building (bug#28222) Charles A. Roelli
2017-08-31 18:47 ` Alan Third
2017-08-31 19:09 ` Charles A. Roelli [this message]
2017-08-31 19:47 ` Alan Third
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2o9qva71s.fsf@aurox.ch \
--to=charles@aurox.ch \
--cc=28222@debbugs.gnu.org \
--cc=alan@idiocy.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).