unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: Tobias Bading <tbading@web.de>
Cc: 31223@debbugs.gnu.org
Subject: bug#31223: [PATCH] Fix empty/incorrect GTK menus on HiDPI monitors with window scaling factor > 1
Date: Thu, 28 Nov 2019 10:44:08 +0100	[thread overview]
Message-ID: <m2o8wwgwt3.fsf@gmail.com> (raw)
In-Reply-To: <3d8e4309-c7df-c70a-a47c-36422d6c6ded@web.de> (Tobias Bading's message of "Thu, 28 Nov 2019 10:32:39 +0100")

>>>>> On Thu, 28 Nov 2019 10:32:39 +0100, Tobias Bading <tbading@web.de> said:
    >> If those are all the same bug we should merge them.

    Tobias> Noam Postavsky already did that over a year ago, although I have no idea
    Tobias> what
    Tobias> "merging" means in this bug tracker. The new comments don't appear in the
    Tobias> merged reports and there's no indication as to which report became kind
    Tobias> of the
    Tobias> leading one after the merged. I simply chose 31223 because that's the
    Tobias> one Noam
    Tobias> sent his "merge 23672 28106 31223" command to, if I'm reading it right.

Iʼm seeing your messages and mine in 31223. I donʼt think it matters
which one you choose.

    Tobias> This change in xg_update_frame_menubar is already a part of my patch,
    Tobias> with the
    Tobias> only difference that I replaced the empty line. Or am I reading this hunk
    Tobias> wrong?

Yes, my mistake, I oversnipped the diff.

    >> This seems correct as well. Probably rec.x and rec.y need scaling as
    Tobias> well, for
    >> the multi-monitor case, which will require some cabling for me to test.

    Tobias> Good point. The documentation of gdk_monitor_get_geometry() says

    Tobias> "Retrieves the size and position of an individual monitor within the display
    Tobias> coordinate space. The returned geometry is in "application pixels", not in
    Tobias> "device pixels" (see gdk_monitor_get_scale_factor())."

    Tobias> Unfortunately, I don't have a second monitor at hand to test this.

I do, but not until tonight at the earliest.

Regards

Robert





  reply	other threads:[~2019-11-28  9:44 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-20 11:40 bug#31223: 25.3; New menus are empty with GTK3 Thomas Schneider
     [not found] ` <handler.31223.B.15242361664927.ack@debbugs.gnu.org>
2018-05-01 16:16   ` Thomas Schneider
2018-05-01 16:48     ` Eli Zaretskii
2018-05-01 17:01       ` Thomas Schneider
2018-05-01 17:08         ` Eli Zaretskii
2018-05-01 17:20           ` Thomas Schneider
2018-05-01 18:43             ` Eli Zaretskii
2018-05-03  8:36               ` Thomas Schneider
2018-05-03 17:52                 ` Eli Zaretskii
2018-07-20 22:44         ` Noam Postavsky
2018-05-01 23:18 ` Noam Postavsky
2019-11-27 16:03 ` bug#31223: [PATCH] Fix empty/incorrect GTK menus on HiDPI monitors with window scaling factor > 1 Tobias Bading
2019-11-28  8:20   ` Robert Pluim
2019-11-28  9:32     ` Tobias Bading
2019-11-28  9:44       ` Robert Pluim [this message]
2019-12-02 10:35         ` Robert Pluim
2019-12-02 15:53           ` Eli Zaretskii
2019-12-03  8:22             ` Robert Pluim
2019-12-17 14:43               ` Robert Pluim
2020-01-07 16:15                 ` Robert Pluim
2020-01-07 16:22                   ` Eli Zaretskii
2020-01-07 16:31                     ` Robert Pluim
2019-11-28 12:04       ` Noam Postavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2o8wwgwt3.fsf@gmail.com \
    --to=rpluim@gmail.com \
    --cc=31223@debbugs.gnu.org \
    --cc=tbading@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).