From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#31223: [PATCH] Fix empty/incorrect GTK menus on HiDPI monitors with window scaling factor > 1 Date: Tue, 07 Jan 2020 17:31:19 +0100 Message-ID: References: <0425bcb6-97ee-4845-3571-9db492966a34@web.de> <3d8e4309-c7df-c70a-a47c-36422d6c6ded@web.de> <83v9qylo5v.fsf@gnu.org> <83d0bvck3l.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="250729"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 31223@debbugs.gnu.org, tbading@web.de To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 07 18:07:07 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iosJu-0010bX-6F for geb-bug-gnu-emacs@m.gmane.org; Tue, 07 Jan 2020 18:07:06 +0100 Original-Received: from localhost ([::1]:53524 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iosJs-0003eU-K9 for geb-bug-gnu-emacs@m.gmane.org; Tue, 07 Jan 2020 12:07:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47536) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iorlz-0000Vk-6k for bug-gnu-emacs@gnu.org; Tue, 07 Jan 2020 11:32:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iorlx-0005zr-VN for bug-gnu-emacs@gnu.org; Tue, 07 Jan 2020 11:32:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43153) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iorlx-0005zg-RT for bug-gnu-emacs@gnu.org; Tue, 07 Jan 2020 11:32:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iorlx-00033a-MR for bug-gnu-emacs@gnu.org; Tue, 07 Jan 2020 11:32:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Jan 2020 16:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31223 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: help Original-Received: via spool by 31223-submit@debbugs.gnu.org id=B31223.157841468811697 (code B ref 31223); Tue, 07 Jan 2020 16:32:01 +0000 Original-Received: (at 31223) by debbugs.gnu.org; 7 Jan 2020 16:31:28 +0000 Original-Received: from localhost ([127.0.0.1]:49123 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iorlQ-00032a-DL for submit@debbugs.gnu.org; Tue, 07 Jan 2020 11:31:28 -0500 Original-Received: from mail-wr1-f41.google.com ([209.85.221.41]:35190) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iorlP-00032L-5H for 31223@debbugs.gnu.org; Tue, 07 Jan 2020 11:31:27 -0500 Original-Received: by mail-wr1-f41.google.com with SMTP id g17so101990wro.2 for <31223@debbugs.gnu.org>; Tue, 07 Jan 2020 08:31:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version; bh=owNluiGcQ7rG831IyU7icm7wx5FlTho9VcuN0GLkhjU=; b=Z0ifKGS6u714wSqPOrlEjus7LfConAZn/mKO/66IGZc2G81KUkzlEC3IEWWPq1HXUS 1Q9xmZd5YRXnEeX6APGvA632WAew37lez9tbNsKHWbgCH7hwnrR154rbDvZf2Unq7OV4 B4HvvGUhCt79BX1TSEBsz1YG4vmJagKqulHwkO5t4HodKOs3WlnNlUcy3/Ri0wzCZHYO mEMs85LAIlbOgH0hxHVihn3jXJ/KqSxrRd7qcJdMxTu96RZeevwTCFTsQ10/Fq5PWrKI tMdv1uHHRy8j01VIBsjhkTvqs9zgn3PrKyBcli4WAAFpM53cJlrYJLpeO4xRZ0UruQYd WiWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version; bh=owNluiGcQ7rG831IyU7icm7wx5FlTho9VcuN0GLkhjU=; b=mpAiYQxBit+nEJYpuUKaCfk/hK5bFiHtFmzE1nY+F01MKqc3TsBRtpFFILHEpeBTnm nOn1CrlftvwPAkYL3c/lGde1ier2jqWklAHuDC1praKFH/rkorpGDO8JpNPkLNUPxgjd Pi5ajtQsw6njMM+1PlBifOMOv8R2ZjScK72BpsOQ++BOskkWq9M1yDZMl4vZyaYt/83M p8GYncyNw0yiNpPWtFbBe+mgRmUYLnPHinX8M29vh3A8AArvMwFBPuKjho41ME8YrEmf cLky75tWgyWpzYnQAxJ2rEKFe3igocOlBD4FPalEkaS6fvNYF47I82O2hCgXsDPnSDDH vLXQ== X-Gm-Message-State: APjAAAVOrR5hcTjblvt/Q2mM4te4s1XGhxOlHL6bNRgJhOk9eSWtHjYV c2vcg2tzKhA5xsF8tDv/vRE= X-Google-Smtp-Source: APXvYqyIfkpql6LqLBXLLS1HQlzBc7PEF8ecx95d3MNbgw7vn9ay4Ei951hg1zvHE3RSVj1UMqZD8Q== X-Received: by 2002:a5d:4392:: with SMTP id i18mr115362373wrq.199.1578414681118; Tue, 07 Jan 2020 08:31:21 -0800 (PST) Original-Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id l3sm431927wrt.29.2020.01.07.08.31.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jan 2020 08:31:20 -0800 (PST) In-Reply-To: <83d0bvck3l.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 07 Jan 2020 18:22:22 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:174319 Archived-At: >>>>> On Tue, 07 Jan 2020 18:22:22 +0200, Eli Zaretskii said: >> From: Robert Pluim >> Cc: 31223@debbugs.gnu.org, tbading@web.de >> Date: Tue, 07 Jan 2020 17:15:04 +0100 >> >> >>>>> On Tue, 17 Dec 2019 15:43:50 +0100, Robert Pluim said: Robert> diff --git a/src/xfns.c b/src/xfns.c Robert> index 47aa19607f..51a46bd6db 100644 Robert> --- a/src/xfns.c Robert> +++ b/src/xfns.c Robert> @@ -5091,6 +5091,8 @@ DEFUN ("x-display-monitor-attributes-list", Fx_display_monitor_attributes_list, Robert> #elif defined HAVE_GTK3 Robert> scale = gdk_screen_get_monitor_scale_factor (gscreen, i); Robert> #endif Robert> + rec.x *= scale; Robert> + rec.y *= scale; Robert> rec.width *= scale; Robert> rec.height *= scale; Robert> work.x *= scale; >> >> Eli, is this OK for emacs-27? It will only affect >> display-monitor-attributes-list for people using GTK on multiple >> monitors where one is HiDPI. Eli> Yes, please push to emacs-27, and thanks. Done. Closing. Robert