bug#43948: 28.0.50; [PATHC][NS] Make s-<left/right> to move to beginning/end of line

[Andrii Kolomoiets <andreyk.mad@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 487 bytes --]

Alan Third <alan@idiocy.org> writes:

>> +** On macOS, 's-<left>' and 's-<right> are now bound to
>                                          ^
> Missing quote.

Fixed.
Smells like bug report for electric-pair-mode to pair "'" in text-mode :)

>
>> +'move-beginning-of-line' and 'move-end-of-line' respectively. The former
>> +commands to select previous/next frame are still bound to 's-~' and 's-`'.
>
> I don't think you need the word "former" here. Other than that, LGTM.

And fixed.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-NS-Make-s-left-right-to-move-to-beginning-end-of-lin.patch --]
[-- Type: text/x-patch, Size: 1750 bytes --]

From edb8467d3884067f88c2349cb30bd38a6a3d40b9 Mon Sep 17 00:00:00 2001
From: Andrii Kolomoiets <andreyk.mad@gmail.com>
Date: Mon, 12 Oct 2020 14:24:25 +0300
Subject: [PATCH] NS: Make s-<left/right> to move to beginning/end of line

* lisp/term/ns-win.el: Bind 's-<left>' to 'move-beginning-of-line';
bind 's-<right>' to 'move-end-of-line'.
* etc/NEWS: Mention new bindings.
---
 etc/NEWS            | 5 +++++
 lisp/term/ns-win.el | 5 ++---
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/etc/NEWS b/etc/NEWS
index cc8733c2c0..8cb9ecc102 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -1683,6 +1683,11 @@ image API via 'M-x report-emacs-bug'.
 ---
 ** The user option 'make-pointer-invisible' is now honored on macOS.
 
+--
+** On macOS, 's-<left>' and 's-<right>' are now bound to
+'move-beginning-of-line' and 'move-end-of-line' respectively. The commands
+to select previous/next frame are still bound to 's-~' and 's-`'.
+
 \f
 ----------------------------------------------------------------------
 This file is part of GNU Emacs.
diff --git a/lisp/term/ns-win.el b/lisp/term/ns-win.el
index cc7a3762b4..8273c067f8 100644
--- a/lisp/term/ns-win.el
+++ b/lisp/term/ns-win.el
@@ -148,9 +148,8 @@ global-map
 (define-key global-map [?\s-|] 'shell-command-on-region)
 (define-key global-map [s-kp-bar] 'shell-command-on-region)
 (define-key global-map [?\C-\s- ] 'ns-do-show-character-palette)
-;; (as in Terminal.app)
-(define-key global-map [s-right] 'ns-next-frame)
-(define-key global-map [s-left] 'ns-prev-frame)
+(define-key global-map [s-right] 'move-end-of-line)
+(define-key global-map [s-left] 'move-beginning-of-line)
 
 (define-key global-map [home] 'beginning-of-buffer)
 (define-key global-map [end] 'end-of-buffer)
-- 
2.15.1