From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Newsgroups: gmane.emacs.bugs Subject: bug#58158: 29.0.50; [overlay] Interval tree iteration considered harmful Date: Fri, 30 Sep 2022 07:28:26 +0200 Message-ID: References: <83h70qhez0.fsf@gnu.org> <83edvuhaby.fsf@gnu.org> <831qruh67o.fsf@gnu.org> <83y1u2foli.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5969"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (darwin) Cc: Eli Zaretskii , 58158@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 30 07:29:12 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oe8aF-0001LF-3Z for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 30 Sep 2022 07:29:11 +0200 Original-Received: from localhost ([::1]:35558 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oe8aD-0003YK-P8 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 30 Sep 2022 01:29:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48230) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oe8a6-0003YA-6M for bug-gnu-emacs@gnu.org; Fri, 30 Sep 2022 01:29:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41187) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oe8a5-0004vX-Sx for bug-gnu-emacs@gnu.org; Fri, 30 Sep 2022 01:29:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oe8a5-0004zp-OV for bug-gnu-emacs@gnu.org; Fri, 30 Sep 2022 01:29:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Sep 2022 05:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58158 X-GNU-PR-Package: emacs Original-Received: via spool by 58158-submit@debbugs.gnu.org id=B58158.166451572019177 (code B ref 58158); Fri, 30 Sep 2022 05:29:01 +0000 Original-Received: (at 58158) by debbugs.gnu.org; 30 Sep 2022 05:28:40 +0000 Original-Received: from localhost ([127.0.0.1]:40265 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oe8Zk-0004zE-16 for submit@debbugs.gnu.org; Fri, 30 Sep 2022 01:28:40 -0400 Original-Received: from mail-ej1-f50.google.com ([209.85.218.50]:35794) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oe8Ze-0004yy-Sb for 58158@debbugs.gnu.org; Fri, 30 Sep 2022 01:28:38 -0400 Original-Received: by mail-ej1-f50.google.com with SMTP id sd10so6833454ejc.2 for <58158@debbugs.gnu.org>; Thu, 29 Sep 2022 22:28:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date; bh=nd0/Z0pE+CK4ofum+int/5HYfEIg0SL2BcnyZuTXqUs=; b=qnjMtf3+f71lNaBdmqAVw1/5xBJa8XNGRo/HiITwTP7ZJC4FmCWlBeh60OBhhK4VCa 3LkgPPki5Lp9dGmNPMxteLZuRXLBiwvLKEqrDKaCrkVWM8bbcE7VRgEXQykDsyOc7rG5 AVvSAbUAjl5Nwxi6Ifb6SbZZmfrZCh4ZVIVfo2z+T5ibeA+nFfyqG1k5xNrzrEz0Hn95 rdDvKuQ4P/iGLqv/yATGl79aZArG8EeWzyuLPCWKOhHTzj2upU+XDN07kEiKvb87ZCYB bmZMruwih0qd7Gi6szu7bTmqs1dlyyr9OMnu2OGB278ZgZaBNHY1veZq49Oriz0GyaS4 xtgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date; bh=nd0/Z0pE+CK4ofum+int/5HYfEIg0SL2BcnyZuTXqUs=; b=qFzSJy26238L4xLaN3M8CnWa5sdl9QpRGa5g54cA34iCSID/b6Tbi2fshHwTRT2D9t wuP9sSbEMklRj2svMbvtAb7LmFdqmFsqapD4DSdCHXDRt8Pf4ibcDkzIgTxIeKtrUB6S 2jFnlvRE8G82jyvhl7+URI3kaznyTyGZJGkOjZ4WitTXUVT23/Ip4KZ2sx1Kzhge+Caj 1jqip9GkD05uWFQ6ZYKLnaaP2Qjs3Dd+o2LAi2NLFhMyOyJmCbOSy0Dy1iqoNBFUxKHE LDx30BVbWSCi08zD8L1zYpyRb+tf1beEfk29WNbtd1j7zsoVe7ag9r1P8jsH/jceSTvD Huyg== X-Gm-Message-State: ACrzQf0/8epT14jCVOOo759kmTuMS2NZsc8C0qST0bBMCglsChI3RMJK 2nTNo6tfS303IVE0bvz/TbR6Icoe72Qd4Q== X-Google-Smtp-Source: AMsMyM6hrExa4kyouu6bAw66aNb3Xup4Ar/wcOQK+EOZ0XgbRUn9+ovVKC6hp+IGQn+fJnAXN4EO2w== X-Received: by 2002:a17:907:6e1e:b0:782:19e7:f5e8 with SMTP id sd30-20020a1709076e1e00b0078219e7f5e8mr5204282ejc.215.1664515708601; Thu, 29 Sep 2022 22:28:28 -0700 (PDT) Original-Received: from Mini.fritz.box (pd9e36cee.dip0.t-ipconnect.de. [217.227.108.238]) by smtp.gmail.com with ESMTPSA id kz20-20020a17090777d400b00780982d77d1sm594957ejc.154.2022.09.29.22.28.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Sep 2022 22:28:27 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Thu, 29 Sep 2022 18:09:01 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243969 Archived-At: Stefan Monnier writes: > I changed the code to store the `visited` bit in the work stack, but if > you could rewrite the `interval_generator_next` along the lines of the > code above that would be great. Ok, I'll rewrite that :-). When I understand what that "narrowing" is and how and for what it is used. BTW, what do you think of changing function names to something a bit shorter? I find myself constantly getting confused when reading the code. I think an "itree_" prefix would suffice for non-static functions, and static ones without prefix. Renaming that is hopefully not that much work with LSP. > [ An alternative would be to try and get rid of the `parent` field :-) > ] :-)