From: Helmut Eller <eller.helmut@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 61151@debbugs.gnu.org
Subject: bug#61151: 30.0.50; sqlite-more-p is confusing
Date: Sun, 29 Jan 2023 17:05:07 +0100 [thread overview]
Message-ID: <m2o7qhqqbw.fsf@gmail.com> (raw)
In-Reply-To: <83mt61747b.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 29 Jan 2023 17:25:44 +0200")
On Sun, Jan 29 2023, Eli Zaretskii wrote:
> I'm not sure I understand why you need sqlite-more-p here.
> sqlite-next returns nil when it hits the end, so it should be enough.
> If we document this fact in the doc string of sqlite-next, would that
> be good enough to satisfy your use cases?
Yes, I guess it would be possible to get rid of sqlite-more-p.
However, sqlite-next seems to return nil once, but then it starts over.
E.g this
(let* ((db (sqlite-open))
(stmt (sqlite-select db "values ('a',0), ('b',1)" nil 'set))
(rows '()))
(list
(sqlite-next stmt)
(sqlite-next stmt)
(sqlite-next stmt)
(sqlite-next stmt)))
returns: (("a" 0) ("b" 1) nil ("a" 0))
This "wrap around" behavior is strange.
In summary, I think that sqlite-next should signal and error instead of
returning nil. And sqlite-more-p should be used to detect the end of
the stream. (Theoretically, sqlite-next could then also return zero
length rows, though that's probably not needed in practice.)
Helmut
next prev parent reply other threads:[~2023-01-29 16:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-29 14:52 bug#61151: 30.0.50; sqlite-more-p is confusing Helmut Eller
2023-01-29 15:25 ` Eli Zaretskii
2023-01-29 16:05 ` Helmut Eller [this message]
2023-01-29 16:48 ` Eli Zaretskii
2023-01-29 18:20 ` Helmut Eller
2023-01-29 18:44 ` Eli Zaretskii
2023-01-30 6:57 ` Helmut Eller
2023-02-02 19:49 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2o7qhqqbw.fsf@gmail.com \
--to=eller.helmut@gmail.com \
--cc=61151@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).