bug#11107: 24.0.94; indentation in objc-mode

bug#11107: 24.0.94; indentation in objc-mode

[Leo]

[-- Attachment #1: kk.m --]
[-- Type: text/plain, Size: 1138 bytes --]

-(IBAction)loginClicked:(id)sender
{
    if (![username.text isEqualToString:@""]&&![password.text isEqualToString:@""]&&![companyCode.text isEqualToString:@""]) {
        if ([username.text isMatchedByRegex:@"[a-zA-Z0-9]+"]&&[password.text isMatchedByRegex:@"[a-zA-Z0-9]+"]&&[companyCode.text isMatchedByRegex:@"[a-zA-Z0-9]+"]) {
            ;
        } else {
            UIAlertView *alert = [[[UIAlertView alloc]
                                      initWithTitle:@""
                                            message:@""
                                           delegate:self
                                      cancelButtonTitle:@""
                                      otherButtonTitles:nil] autorelease];
            [alert show];
        }
    } else {
        UIAlertView *alert = [[[UIAlertView alloc]
                                   initWithTitle:@""
                                         message:@""
                                        delegate:self
                                  cancelButtonTitle:@""
                                  otherButtonTitles:nil] autorelease];
        [alert show];
    }
}

[-- Attachment #2: Type: text/plain, Size: 226 bytes --]


1. Emacs -q
2. Open the attach file
3. Eval in the file buffer:
   - (c-set-style "bsd")
   - (setq c-basic-offset 4)

Try indenting the file, you will see : in the message name not aligned
properly as shown in this picture.

[-- Attachment #3: objc-bug.png --]
[-- Type: image/png, Size: 13565 bytes --]

[-- Attachment #4: Type: text/plain, Size: 5 bytes --]


Leo

bug#11107: 24.0.94; indentation in objc-mode

[Alan Mackenzie]

Hello, Leo.

On Wed, Mar 28, 2012 at 09:23:32AM +0800, Leo wrote:
> -(IBAction)loginClicked:(id)sender
> {
>     if (![username.text isEqualToString:@""]&&![password.text isEqualToString:@""]&&![companyCode.text isEqualToString:@""]) {
>         if ([username.text isMatchedByRegex:@"[a-zA-Z0-9]+"]&&[password.text isMatchedByRegex:@"[a-zA-Z0-9]+"]&&[companyCode.text isMatchedByRegex:@"[a-zA-Z0-9]+"]) {
>             ;
>         } else {
>             UIAlertView *alert = [[[UIAlertView alloc]
>                                       initWithTitle:@""
>                                             message:@""
>                                            delegate:self
>                                       cancelButtonTitle:@""
>                                       otherButtonTitles:nil] autorelease];
>             [alert show];
>         }
>     } else {
>         UIAlertView *alert = [[[UIAlertView alloc]
>                                    initWithTitle:@""
>                                          message:@""
>                                         delegate:self
>                                   cancelButtonTitle:@""
>                                   otherButtonTitles:nil] autorelease];
>         [alert show];
>     }
> }


> 1. Emacs -q
> 2. Open the attach file
> 3. Eval in the file buffer:
>    - (c-set-style "bsd")
>    - (setq c-basic-offset 4)

> Try indenting the file, you will see : in the message name not aligned
> properly as shown in this picture.

What is happening here is this:

cancelButtonTitle would, if its : were lined up, not be sufficiently
indented from the enclosing [.  Here "sufficiently indented" is
determined by the variable c-objc-method-arg-min-delta-to-bracket, whose
default value is 2.  On failing that test, the line gets indented
c-basic-offset columns after that [.

The simplest WAY TO FIX THIS is to give a lower value to
c-objc-method-arg-min-delta-to-bracket (honestly, I didn't invent that
name ;-), probably a negative number.  You can set this variable via
M-x customize-variable, or your favourite other method.

There is actually a lineup-function c-lineup-ObjC-method-args which
should do exactly what you want, but sadly it doesn't work at all.  I'll
need to fix it sometime.

########################################################################
OPTIONAL SECTION

If you're interested in what's going on here, do C-c C-o on the
cancelButtonTitle line, then hit <CR>.  You get
(default (c-lineup-ObjC-method-call-colons c-lineup-ObjC-method-call +)).
The "default" means "execute the functions in the following list until
one returns non-nil".  The first one returns nil on the
cancelButtonTitle.  The second one returns 4, the relative indentation
used.

All this is detailed in the CC Mode manual in the chapter "Customizing
indentation" and its subsections, in particular "Line-Up Functions"
together with its subsections.
#########################################################################

-- 
Alan Mackenzie (Nuremberg, Germany).

bug#11107: 24.0.94; indentation in objc-mode

[Leo]

On 2012-03-29 21:35 +0800, Alan Mackenzie wrote:
> What is happening here is this:

Thank you for the excellent explanation. I have closed this nonbug.

Leo