unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Keith David Bershatsky <esq@lawlist.com>
To: Alan Third <alan@idiocy.org>
Cc: 29353@debbugs.gnu.org
Subject: bug#29353: [PATCH] Add window divider faces to NS (bug#29353)
Date: Sun, 19 Nov 2017 22:38:25 -0800	[thread overview]
Message-ID: <m2mv3hsbdq.wl%esq@lawlist.com> (raw)
In-Reply-To: <m2zi7j88ts.wl%esq@lawlist.com>

Yes, this latest patch fixed the issue that I was observing when the width of the dividers is exactly 3.

Thank you again for bringing this feature to OSX/MacOS users.

Greatly appreciated,

Keith

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

DATE:  [11-19-2017 15:23:01] <19 Nov 2017 23:23:01 +0000>
FROM:  Alan Third <alan@idiocy.org>
> 
> * * *
> 
> modified   src/nsterm.m
> @@ -3202,7 +3202,7 @@ Note that CURSOR_WIDTH is meaningful only for (h)bar cursors.
>        [ns_lookup_indexed_color(color_last, f) set];
>        NSRectFill(NSMakeRect (x1 - 1, y0, 1, y1 - y0));
>      }
> -  else if (x1 - x0 > y1 - y0 && y1 - y0 > 3)
> +  else if (x1 - x0 > y1 - y0 && y1 - y0 > 2)
>      /* Horizontal.  */
>      {
>        [ns_lookup_indexed_color(color_first, f) set];
> 
> -- 
> Alan Third





      parent reply	other threads:[~2017-11-20  6:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-18 23:29 bug#29353: OSX/MacOS: Adding support for window-divider-first/last-pixel Keith David Bershatsky
2017-11-19 11:53 ` bug#29353: [PATCH] Add window divider faces to NS (bug#29353) Alan Third
2017-11-19 20:40 ` Keith David Bershatsky
2017-11-19 23:23   ` Alan Third
2017-11-20  8:26     ` martin rudalics
2017-11-19 22:11 ` Keith David Bershatsky
2017-11-19 22:53   ` Alan Third
2017-11-19 23:06 ` Keith David Bershatsky
2017-11-19 23:27   ` Alan Third
2017-11-20  6:31 ` Keith David Bershatsky
2017-11-20 20:41   ` Alan Third
2017-11-20  6:38 ` Keith David Bershatsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2mv3hsbdq.wl%esq@lawlist.com \
    --to=esq@lawlist.com \
    --cc=29353@debbugs.gnu.org \
    --cc=alan@idiocy.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).