From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#38602: 26.3; gnutls-negotiate fails to handle :verify-error being set to t Date: Sun, 29 Dec 2019 22:01:53 +0100 Message-ID: References: <875zijbq2z.fsf@ada> <87pngbpvku.fsf@ada> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="208455"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 38602@debbugs.gnu.org To: Alexis Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Dec 29 22:03:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ilfiR-000s0T-8z for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Dec 2019 22:03:11 +0100 Original-Received: from localhost ([::1]:55014 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ilfiP-0007Aw-Gq for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Dec 2019 16:03:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49567) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ilfiJ-0007Ab-F2 for bug-gnu-emacs@gnu.org; Sun, 29 Dec 2019 16:03:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ilfiI-0006xe-6j for bug-gnu-emacs@gnu.org; Sun, 29 Dec 2019 16:03:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54314) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ilfiI-0006wY-2F for bug-gnu-emacs@gnu.org; Sun, 29 Dec 2019 16:03:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ilfiH-0003yn-UK for bug-gnu-emacs@gnu.org; Sun, 29 Dec 2019 16:03:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Dec 2019 21:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38602 X-GNU-PR-Package: emacs Original-Received: via spool by 38602-submit@debbugs.gnu.org id=B38602.157765332315231 (code B ref 38602); Sun, 29 Dec 2019 21:03:01 +0000 Original-Received: (at 38602) by debbugs.gnu.org; 29 Dec 2019 21:02:03 +0000 Original-Received: from localhost ([127.0.0.1]:60287 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ilfhL-0003xb-Bp for submit@debbugs.gnu.org; Sun, 29 Dec 2019 16:02:03 -0500 Original-Received: from mail-wm1-f67.google.com ([209.85.128.67]:35507) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ilfhJ-0003x5-Mv for 38602@debbugs.gnu.org; Sun, 29 Dec 2019 16:02:02 -0500 Original-Received: by mail-wm1-f67.google.com with SMTP id p17so12790880wmb.0 for <38602@debbugs.gnu.org>; Sun, 29 Dec 2019 13:02:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:gmane-reply-to-list:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=pYO3dN2mKfzswlRrNMKtUjQdTLT6TODSw4xw5PObX5Q=; b=QMnyQAsW2RPezmpuB067j3jHyVCqD+lC6ntxaF4tCkWcI663YnRyR+jdnWYI8S1ci/ vHoA9Gq6XORs+A71ga/0wjlHpM3SyDkU7n6GA7B6DPR7n+PgnD+OG3Qjm6iXHmfP1tJo fWHWIHoHGMS7vqaaSwJTuGQ6JdnhToThbFVvdNsV2OE3iTYmWtpPr58dr7T9h/tavBXt uyjRTM5NtIKG+a9Rd1MLcc+mSa8jbGfHxRDA1fdvuItO3uvnpp+uMzVVcrvqN6QkINEc /bbEzKwTwSuEfFQpj+Cd1td+qEz2OrSGym9au4KXU+JqbueqlKwqUQoebNZte4Yryzvf zE1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=pYO3dN2mKfzswlRrNMKtUjQdTLT6TODSw4xw5PObX5Q=; b=uY3CL1Is6rSR64KT8VHSJYaCOSRgri01dUYBzjhY565pBf29lkVV+i+MnjXeLtloGs JaoUE/5g3+lXo3jPQdd4ejFKZ5mtT08gMyfXuXWfZqtTG1kWxMcpB1XahpG6PxYVlirz 0ZO8OUrRLOThA33WzT45raZwzInztjKpYW9iw4OQLUfs97L92jui8vveWqMSzWCvGK3W RVnVtLV7XvmLwE1B0xasLNYY5bcN+cLPctn0XHL2SAz0Wew/Nwca6OjduBXuiaSKHbhH A7MhlfS2e34koUIgCAqFu/2KTcd1YOeEnZpGRFJWO5v/3/qzqYpAGoSE1LKlAX1IbN25 tomw== X-Gm-Message-State: APjAAAUsIYhHHXkYfJPSIMf54fjv/D8vRvrSxepNRY/ds04J9zLVpvZe oUV+7CxCklxFTeJrqbXrGJ1ZdYnJcBQ= X-Google-Smtp-Source: APXvYqyJfJQpoFC9Fi2395N1cJvUBBtsCSh/1HhvhCTUwnJc9l+jWQbhRUEuZo0vA2BBvw5fykb1fA== X-Received: by 2002:a1c:486:: with SMTP id 128mr31714320wme.163.1577653315553; Sun, 29 Dec 2019 13:01:55 -0800 (PST) Original-Received: from rpluim-mac ([2a01:e34:ecfc:a860:f526:2fc9:7a9e:3937]) by smtp.gmail.com with ESMTPSA id h2sm46957033wrt.45.2019.12.29.13.01.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Dec 2019 13:01:54 -0800 (PST) Gmane-Reply-To-List: yes In-Reply-To: <87pngbpvku.fsf@ada> (Alexis's message of "Thu, 26 Dec 2019 15:19:45 +1100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:173910 Archived-At: >>>>> On Thu, 26 Dec 2019 15:19:45 +1100, Alexis sai= d: Alexis> Robert Pluim writes: >> How about this? Producing a list (:hostname t) is not what you want, >> since that removes the 'check everything' feature of specifying just >> 't'. >>=20 >> diff --git a/lisp/net/gnutls.el b/lisp/net/gnutls.el >> index 9b13adaefe..14368bc298 100644 >> --- a/lisp/net/gnutls.el >> +++ b/lisp/net/gnutls.el >> @@ -345,8 +345,11 @@ gnutls-boot-parameters >> (t nil)))) >> (min-prime-bits (or min-prime-bits >> gnutls-min-prime-bits))) >> - (when verify-hostname-error >> - (push :hostname verify-error)) >> + ;; Only add :hostname if `verify-error' is not t, since t >> + ;; means "include :hostname" Bug#38602. >> + (and verify-hostname-error >> + (not (eq verify-error t)) >> + (push :hostname verify-error)) >> `(:priority ,priority-string >> :hostname ,hostname Alexis> Thank you for your prompt response - sorry to have taken so lon= g to Alexis> get back to you. Alexis> Unfortunately, this diff didn't work for me - it results in the= error: Alexis> STARTTLS negotation failed: GnuTLS error: #, Alexis> nil Hmm, it worked in my testing, but that didn=CA=BCt use jabber.el. I=CA=BCll= see if I can test with jabber.el here, which host are you connecting to? Robert