From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alex Bochannek Newsgroups: gmane.emacs.bugs Subject: bug#43413: 28.0.50; [PATCH] New gnus-score-func to support user-defined scoring functions Date: Thu, 17 Sep 2020 10:41:28 -0700 Message-ID: References: <875z8f9pbs.fsf@gnus.org> <87v9gcphr8.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21628"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (darwin) Cc: 43413@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 17 19:42:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIxvA-0005RT-Sn for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Sep 2020 19:42:12 +0200 Original-Received: from localhost ([::1]:32956 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIxv9-0007tv-Va for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Sep 2020 13:42:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43460) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIxv0-0007rR-TJ for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2020 13:42:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55595) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kIxv0-0002fV-H7 for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2020 13:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kIxv0-0007lA-Ds for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2020 13:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alex Bochannek Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Sep 2020 17:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43413 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed Original-Received: via spool by 43413-submit@debbugs.gnu.org id=B43413.160036450429804 (code B ref 43413); Thu, 17 Sep 2020 17:42:02 +0000 Original-Received: (at 43413) by debbugs.gnu.org; 17 Sep 2020 17:41:44 +0000 Original-Received: from localhost ([127.0.0.1]:38908 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIxui-0007ke-DH for submit@debbugs.gnu.org; Thu, 17 Sep 2020 13:41:44 -0400 Original-Received: from 50-0-39-243.dsl.static.fusionbroadband.com ([50.0.39.243]:55308 helo=mail.lapseofthought.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIxuc-0007kM-BS for 43413@debbugs.gnu.org; Thu, 17 Sep 2020 13:41:42 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by mail.lapseofthought.com (Postfix) with ESMTP id 4BskmC6PL5z3jhwb; Thu, 17 Sep 2020 10:41:31 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at lapseofthought.com Original-Received: from mail.lapseofthought.com ([127.0.0.1]) by localhost (mail.lapseofthought.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id c7SZRtzlDAn2; Thu, 17 Sep 2020 10:41:31 -0700 (PDT) Original-Received: from awb-mbp.local (unknown [IPv6:2601:646:4200:b470:2ce3:5dd8:d854:dc01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by mail.lapseofthought.com (Postfix) with ESMTPSA id 4BskmB6pwSz3jhdp; Thu, 17 Sep 2020 10:41:30 -0700 (PDT) In-Reply-To: <87v9gcphr8.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 17 Sep 2020 17:03:55 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188232 Archived-At: Lars Ingebrigtsen writes: > Alex Bochannek writes: > >> Please ignore the previous patch I sent that used let-forms, I found a >> bug in it. I cleaned it up some more and I am attaching a new >> patch. Thanks again for the feedback! > > Thanks, applied to Emacs 28 with some minor stylistic changes. Well, > they looked minor to me, but I didn't actually test the resulting code, > so you should probably do so. :-) Did some testing and it looks good. Is there a unit test framework I could use for Elisp code, by the way? That could be useful for simple utility functions that just transform some input (e.g., the patch I suggested in #43441.) Thanks! -- Alex.