From: Pankaj Jangid <pankaj@codeisgreat.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 49846@debbugs.gnu.org
Subject: bug#49846: 28.0.50; project-find-regexp results does not open target file
Date: Thu, 05 Aug 2021 09:28:20 +0530 [thread overview]
Message-ID: <m2mtpwh7ab.fsf@codeisgreat.org> (raw)
In-Reply-To: <b6447870-50e4-652a-fa14-ae9131714696@yandex.ru> (Dmitry Gutov's message of "Thu, 5 Aug 2021 06:06:03 +0300")
Dmitry Gutov <dgutov@yandex.ru> writes:
> On 03.08.2021 20:12, Pankaj Jangid wrote:
>> Steps to reproduce:
>> 1. emacs -Q
>> 2. C-x p p (project-switch-project)
>> 3. select project
>> 4. press g (Find Regexp) and search for a term then RET
>> 5. In the results select any file
>> Result: No reference at point
>> Expectation: step-5 should open the file-at-point and point should
>> be
>> placed at a suitable place in the opened file.
>
> To be clear: you position the point on a group name, press RET and see
> this message? That is expected.
>
Okay. I didn’t know this. Has this change in recently? I remember
hitting on the group and opening the target file. But true, with
multiple results in the group that would be confusing.
> If we do end up changing this behavior, what would the "suitable
> place" be? The first match in the group?
There are two options here:
1. We just change the message. Something like: "select a match to open".
2. In addition to above, we may have a customization variable. Something
like - xref-open-first-match
For this bug, (1) should be sufficient.
next prev parent reply other threads:[~2021-08-05 3:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-03 17:12 bug#49846: 28.0.50; project-find-regexp results does not open target file Pankaj Jangid
2021-08-04 20:10 ` Juri Linkov
2021-08-05 3:11 ` Dmitry Gutov
2021-08-05 3:06 ` Dmitry Gutov
2021-08-05 3:58 ` Pankaj Jangid [this message]
2021-08-05 13:13 ` Dmitry Gutov
2021-08-05 14:02 ` Pankaj Jangid
2021-08-05 14:03 ` Dmitry Gutov
2021-08-05 14:27 ` Pankaj Jangid
2021-08-05 23:51 ` Dmitry Gutov
2021-08-06 3:07 ` Pankaj Jangid
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2mtpwh7ab.fsf@codeisgreat.org \
--to=pankaj@codeisgreat.org \
--cc=49846@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).