From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Newsgroups: gmane.emacs.bugs Subject: bug#57309: 29.0.50; Build error "trying to dump non fixed-up eln file" Date: Sun, 21 Aug 2022 09:03:45 +0200 Message-ID: References: <87zgfznjvz.fsf@gnus.org> <87tu67njdq.fsf@gnus.org> <87pmgvniyh.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16664"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (darwin) Cc: 57309@debbugs.gnu.org, Andrea Corallo To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 21 09:04:45 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oPf0l-00049Z-C4 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 Aug 2022 09:04:43 +0200 Original-Received: from localhost ([::1]:41130 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oPf0j-0004UE-Ri for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 Aug 2022 03:04:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50332) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oPf07-0004T9-2G for bug-gnu-emacs@gnu.org; Sun, 21 Aug 2022 03:04:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43996) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oPf06-0003rS-PV for bug-gnu-emacs@gnu.org; Sun, 21 Aug 2022 03:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oPf06-0000t0-Kq for bug-gnu-emacs@gnu.org; Sun, 21 Aug 2022 03:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Aug 2022 07:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57309 X-GNU-PR-Package: emacs Original-Received: via spool by 57309-submit@debbugs.gnu.org id=B57309.16610654333384 (code B ref 57309); Sun, 21 Aug 2022 07:04:02 +0000 Original-Received: (at 57309) by debbugs.gnu.org; 21 Aug 2022 07:03:53 +0000 Original-Received: from localhost ([127.0.0.1]:33744 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oPezx-0000sW-DE for submit@debbugs.gnu.org; Sun, 21 Aug 2022 03:03:53 -0400 Original-Received: from mail-ej1-f51.google.com ([209.85.218.51]:34788) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oPezw-0000sK-Ce for 57309@debbugs.gnu.org; Sun, 21 Aug 2022 03:03:52 -0400 Original-Received: by mail-ej1-f51.google.com with SMTP id vw19so2145891ejb.1 for <57309@debbugs.gnu.org>; Sun, 21 Aug 2022 00:03:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc; bh=pMwXor3UOjphAKKHGpkU7rCaONaKPnjAMfHe0X/tj3I=; b=dXNnmKaL/xIGUuHtStn7PK6Wi734Cp55vguAhurstn9zeh83l+VyTrc0doTx40szg8 YbVwx4R2Q82SoFo8bDay7+0nDaPSK+rurNbzJ17KurRA+M0Q+KtlAgOeysx5TfLLMSbs 2iOP6RYE+h5I1/4dsp0TCqMkOqWLHPTpMGuelXJcAyq96clM+0ojyVhF7gAXrpMCvjse +gYHJ/3WKJPQdsi06j2VJ299TAFeF5vXFT6oL3xxVMAX/fImaPK5KSvcyfkHgqPVbyaJ axox4xCPaqv6zfTzgNNh4YqWjPqLfAoNIy0QVEBjHruA/IEtUxdA/SfVwNjNth4rlQ6Q 32Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc; bh=pMwXor3UOjphAKKHGpkU7rCaONaKPnjAMfHe0X/tj3I=; b=mzqgegrb7Au8ZA/4qGoL+7gLLXY9OpjYxPD4ZSy7P35pvEcQG29PmE3QRipVc9oXD1 tPupTCwqDe7dGPWGgoPwjTTIMUR6pT+LqRZwfU65CgxVNMzbz3MApmz6nlPXYABCG9Ih EaDWeuUdGRawFiPVMt2Vi+yUaE3Ulqzt1sPrJmK5FqNDIgLE1BucmztWASfM+Iv0kfWu lP1IzBKiXIV1BTUdvzjwprLYnaMmO9v8KdG52aaAAh3z3/SMYhiM+wvmdgh+l1I1zbb6 5n+LYFgtvl2u4Lstih40H93z9oni/w4AnKFQfCS1o3J+okHtJvUb/ahaxGWYRKAge20C oz7g== X-Gm-Message-State: ACgBeo2a4jl0E8NVvDbWMuGSzivvsPEJMwn8okztVPIQeXRkMNS3GkUp 8vKeh93P4x/vW2v/KQqXnKg= X-Google-Smtp-Source: AA6agR6VcKoVfNswdO1FMJ6UYZwX0uHdvilpfPcjGhVD8libloc5A+0kfhIkdUO3tagv7BmXP7j7gw== X-Received: by 2002:a17:907:6eaa:b0:730:9fb6:41a5 with SMTP id sh42-20020a1709076eaa00b007309fb641a5mr9286961ejc.675.1661065426304; Sun, 21 Aug 2022 00:03:46 -0700 (PDT) Original-Received: from Mini.fritz.box (p54b0cf60.dip0.t-ipconnect.de. [84.176.207.96]) by smtp.gmail.com with ESMTPSA id j15-20020aa7c0cf000000b0043bbc9503ddsm6019649edp.76.2022.08.21.00.03.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Aug 2022 00:03:45 -0700 (PDT) In-Reply-To: ("Gerd =?UTF-8?Q?M=C3=B6llmann?="'s message of "Sat, 20 Aug 2022 17:08:53 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:240284 Archived-At: Gerd M=C3=B6llmann writes: > Gerd M=C3=B6llmann writes: > And a little bit more... > > The error "trying to..." comes from dump_native_comp_unit, which is > called from dump_vectorlike, which is called from dump_object. Dumped > objects are recorded in a hashtable dump_context::objects_dumped. Now > > (lldb) p ctx->objects_dumped > (Lisp_Object) $294 =3D 0x000000010407373d (struct Lisp_Hash_Table *) $299= =3D 0x0000000104073738 > (lldb) expr -- hash_lookup ($299, lv, 0) > (ptrdiff_t) $300 =3D 2010 > (lldb) p lv > (Lisp_Object) $301 =3D 0x00000001040d0a6d (struct Lisp_Native_Comp_Unit *= ) $306 =3D 0x00000001040d0a68 > > lv is the compilation unit in question which gives the error, and the > dumpcontext says it is already dumped. > > So what now? > > I'd say one can encounter the same Lisp_Object more than once in a dump, > in general. Shouldn't there be some check somewhere in the CU code? > Where is it? Or is this supposed not to happen? If so, how is it > ensured? > > Questions over questions... I think I've at least found where recognizing already dumped objects happens. It's here: static dump_off dump_object (struct dump_context *ctx, Lisp_Object object) { #if CHECK_STRUCTS && !defined (HASH_Lisp_Type_45F0582FD7) # error "Lisp_Type changed. See CHECK_STRUCTS comment in config.h." #endif eassert (!EQ (object, dead_object ())); dump_off offset =3D dump_recall_object (ctx, object); if (offset > 0) return offset; /* Object already dumped. */ dump_recall_object should have returned an offset > 0 the second time the window.eln compilation unit was to be dumped. (I'm almost 100% sure that that's was is happening here because I can find it in the objects_dumped hash table.) Only, I don't see what is going wrong after that. Maybe it is something following the code above. The flags in dump_context for example, I don't really understand. Or is it that dump_object_emacs_ptr returns NULL, and something is happening then, or not happening? Hm.