From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Newsgroups: gmane.emacs.bugs Subject: bug#58042: 29.0.50; ASAN use-after-free in re_match_2_internal Date: Wed, 05 Oct 2022 13:15:49 +0200 Message-ID: References: <83edvnv965.fsf@gnu.org> <83pmf6u76i.fsf@gnu.org> <83mtaau43p.fsf@gnu.org> <83ilkytyif.fsf@gnu.org> <87y1tuv851.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6469"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (darwin) Cc: Eli Zaretskii , 58042@debbugs.gnu.org, Alan Third To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 05 13:17:51 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1og2PP-0001XB-9w for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 Oct 2022 13:17:51 +0200 Original-Received: from localhost ([::1]:52576 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1og2PF-0003oD-72 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 Oct 2022 07:17:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49866) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1og2Nf-0003kE-8S for bug-gnu-emacs@gnu.org; Wed, 05 Oct 2022 07:16:08 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57006) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1og2Nf-0001XP-0H for bug-gnu-emacs@gnu.org; Wed, 05 Oct 2022 07:16:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1og2Ne-0006ri-Rg for bug-gnu-emacs@gnu.org; Wed, 05 Oct 2022 07:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Oct 2022 11:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58042 X-GNU-PR-Package: emacs Original-Received: via spool by 58042-submit@debbugs.gnu.org id=B58042.166496855926359 (code B ref 58042); Wed, 05 Oct 2022 11:16:02 +0000 Original-Received: (at 58042) by debbugs.gnu.org; 5 Oct 2022 11:15:59 +0000 Original-Received: from localhost ([127.0.0.1]:56080 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1og2Nb-0006r4-7O for submit@debbugs.gnu.org; Wed, 05 Oct 2022 07:15:59 -0400 Original-Received: from mail-ed1-f42.google.com ([209.85.208.42]:40872) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1og2NZ-0006qo-6F for 58042@debbugs.gnu.org; Wed, 05 Oct 2022 07:15:57 -0400 Original-Received: by mail-ed1-f42.google.com with SMTP id x59so12522067ede.7 for <58042@debbugs.gnu.org>; Wed, 05 Oct 2022 04:15:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date; bh=KXEy294q45Emy6bD3RWxzbQPERr4doiAkzwHoEgzeSA=; b=Jiqx1/GDU8+YIzCr5+ikh1w1Thdd2yBLPI2h3DEyucksvnQyPu8L8my704FvdKKtWu 9SZ6CSCWaLoiXIbQbZFxcbMtsdz3x98qArBuHv34i5W8GpISjxXP62c+AHWD3NIt9+Vw VNxD58ObWo2A7K6h7djiiB4c6+MgZCWEix757cC+ZWitjTrFPu6wN/M9acMwogVM35im dvNrb2xe+kwHEipEkhebouO3hVpJ/yOfTTX7TW9RDdg0+OOvZ/3q0oFitBud+T9yJYYR TLMWEWUwgB1D/p3ZXP0wlCiAUlb888vbQG8kfpsvZZ3JnUJBVDlTD/lth2stPRNqxSn9 pMzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date; bh=KXEy294q45Emy6bD3RWxzbQPERr4doiAkzwHoEgzeSA=; b=qC0f9pczPbpU6bBcoTJ08y5Ic6mf+hhEoxnblK7gXRwNagYu8HSMdUVlr1nwFvXK7Q AOcX2kSxq0fci6aHc7Jn1O78CMvRq8D/hwc7IdpnD041ynGOXNglIy5GNkDrUEfqJAf6 qLSHvtLmiCGXpBKIgKdH4UCOkZ8u+ZDrVItTwXQTCmFtjMczWZFYGyMWeYYNHSrCln5R hBqTIlhHTIrfl9AndAORJ3RBJh2cT4jac+M/DkAN0R/ENKi7imM7jQFDzy+XKC1+fbjB Nm+AUSuo5bLFhQv3SfO9zCHr1GkxdkOf5pllGyWN+kcQObCxtD4xR9rJ9hvPWuacrEes LhWA== X-Gm-Message-State: ACrzQf3ULMFnjR0/HFU7uQIycFg1TadEwI9ABpqCiyFMMtCJ6EgUb61i iPgt+qNTGFMQ66loQjARFd7wANtqcAOhVw== X-Google-Smtp-Source: AMsMyM6ymGZW5JNxAp7KxFyuWGfvWXrlTc4rfnZbQLoPCCxoojMk2h8uS3pfpVIuEc5VLUnSQOzZ2A== X-Received: by 2002:a50:fe0a:0:b0:458:dce8:2b6b with SMTP id f10-20020a50fe0a000000b00458dce82b6bmr15851350edt.84.1664968551008; Wed, 05 Oct 2022 04:15:51 -0700 (PDT) Original-Received: from Mini.fritz.box (pd9e36cc6.dip0.t-ipconnect.de. [217.227.108.198]) by smtp.gmail.com with ESMTPSA id w13-20020a1709060a0d00b0078b83968ad4sm4845480ejf.24.2022.10.05.04.15.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Oct 2022 04:15:50 -0700 (PDT) In-Reply-To: <87y1tuv851.fsf@yahoo.com> (Po Lu's message of "Wed, 05 Oct 2022 19:10:02 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:244517 Archived-At: Po Lu writes: > I'm going to guess that window_sub_list is returning a window that was > not marked during GC. It's a problem that also exists with my > incremental garbage collector. Does this help? > > diff --git a/src/alloc.c b/src/alloc.c > index 419c5e558b..522925d248 100644 > --- a/src/alloc.c > +++ b/src/alloc.c > @@ -6634,6 +6634,9 @@ mark_window (struct Lisp_Vector *ptr) > mark_glyph_matrix (w->desired_matrix); > } > > + if (w->next) > + mark_window (w->next); > + > /* Filter out killed buffers from both buffer lists > in attempt to help GC to reclaim killed buffers faster. > We can do it elsewhere for live windows, but this is the Indeed, that seems to work!