bug#70357: 30.0.50; loadup.el, load nadvice before seq

["Gerd Möllmann" <gerd.moellmann@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1407 bytes --]

Gerd Möllmann <gerd.moellmann@gmail.com> writes:

> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>
>> A quick fix could be the patch below.
>
> Thanks Stefan. I'm now using your change locally to see if anything
> doesn't work (but I don't expect that).

I have something, but I'm 100% unsure if this has anything to do with
your patch, not the least because I never got so far in the build
before.

This is with MPS-based GC, and a build from git clean -xdf.
bootstrap-emacs.pdmp is built, some Lisp is compiled, and emacs.pdmp is
about to be dumped.

When loading ns-win (compiled), I get

  *** MPS GC start: Generation 0 of a chain has reached capacity: start a minor collection.
  Loading term/ns-win...

  Error: error ("Missing cl-generic dispatcher in the prefilled cache!
  Missing for: ((&context . window-system) cl--generic-eql-generalizer cl--generic-t-generalizer)
  You might need to add: (cl--generic-prefill-dispatchers (&context . window-system) (eql 'x))")
    signal(error ("Missing cl-generic dispatcher in the prefilled cache!\nMissing for: ((&context . window-system) cl--generic-eql-generalizer cl--generic-t-generalizer)\nYou might need to add: (cl--generic-prefill-dispatchers (&context . window-system) (eql 'x))"))

I'm attaching the full backtrace.

As I said, I have no idea yet what that means. I'll try a build without
MPS a bit later.


[-- Attachment #2: build.log --]
[-- Type: text/plain, Size: 14735 bytes --]

Loading international/ucs-normalize...
*** MPS GC start: Generation 0 of a chain has reached capacity: start a minor collection.
Loading term/ns-win...

Error: error ("Missing cl-generic dispatcher in the prefilled cache!
Missing for: ((&context . window-system) cl--generic-eql-generalizer cl--generic-t-generalizer)
You might need to add: (cl--generic-prefill-dispatchers (&context . window-system) (eql 'x))")
  signal(error ("Missing cl-generic dispatcher in the prefilled cache!\nMissing for: ((&context . window-system) cl--generic-eql-generalizer cl--generic-t-generalizer)\nYou might need to add: (cl--generic-prefill-dispatchers (&context . window-system) (eql 'x))"))
  error("Missing cl-generic dispatcher in the prefilled cache!\nMissing for: %S\nYou might need to add: %S" ((&context . window-system) cl--generic-eql-generalizer cl--generic-t-generalizer) (cl--generic-prefill-dispatchers (&context . window-system) (eql 'x)))
  cl--generic-get-dispatcher(((&context . window-system) #s(cl--generic-generalizer cl--generic-eql-generalizer 100 #[385 "\300\2\301BB\207" [gethash (cl--generic-eql-used)] 5 ("emacs-lisp/cl-generic.elc" . 6938)] #[385 "\1\242\300=\205\11\0\1A\207" [eql] 4 ("emacs-lisp/cl-generic.elc" . 6963)]) #s(cl--generic-generalizer cl--generic-t-generalizer 0 #[385 "\300\207" [nil] 3 ("emacs-lisp/cl-generic.elc" . 6938)] #[385 "\300\207" [(t)] 3 ("emacs-lisp/cl-generic.elc" . 6963)])))
  cl--generic-make-next-function(#s(cl--generic window-system-initialization (((&context . window-system) #s(cl--generic-generalizer cl--generic-eql-generalizer 100 #[385 "\300\2\301BB\207" [gethash (cl--generic-eql-used)] 5 ("emacs-lisp/cl-generic.elc" . 6938)] #[385 "\1\242\300=\205\11\0\1A\207" [eql] 4 ("emacs-lisp/cl-generic.elc" . 6963)]) #s(cl--generic-generalizer cl--generic-t-generalizer 0 #[385 "\300\207" [nil] 3 ("emacs-lisp/cl-generic.elc" . 6938)] #[385 "\300\207" [(t)] 3 ("emacs-lisp/cl-generic.elc" . 6963)]))) (#s(cl--generic-method (((&context . window-system) eql 'ns)) nil nil #[256 "\10\203\10\0\306\307!\210\310\11!\21\311 \210\3121\34\0\313\n\314\"0\210\202&\0\315\316\317\320\4\"\321#\266\2\322\323 \206-\0\324\13\314#\210\325\326!\203X\0\327\24\330\15\331\332\16;B#\210\330\15\333\334#\210\330\15\335\336#\210\330\15\337\340\341\340!B#\210\342 \211\203\201\0\211@\211@\343=\203p\0\344\1A!\266\2\202}\0\345\15\346\3@!\344\4A!#\266\2A\202Z\0\210\347\350\351\"\314=\203\231\0\347\350\352\"\314=\203\231\0\353\354\355\"\210\356\347\350\357\"\203\245\0\360\202\246\0\361!\210\16<\362=\203\264\0\353\363\364\"\210\365\350\366\367#\210\370 \210\353\371\372\"\210\314\211\20\207" [ns-initialized command-line-args ns-standard-fontset-spec x-command-line-resources menu-bar-final-items global-map cl--assertion-failed (not ns-initialized) x-handle-args create-default-fontset (error) create-fontset-from-fontset-spec t display-warning initialization format "Creation of the standard fontset failed: %s" :error x-open-connection system-name "" featurep gnustep (buffer services hide-app quit) bindings--define-key [menu-bar help-menu] "Info" [menu-bar quit] (menu-item "Quit" save-buffers-kill-emacs :help "Save unsaved buffers, then exit") [menu-bar hide-app] (menu-item "Hide" ns-do-hide-emacs :help "Hide Emacs") [menu-bar services] "Services" make-sparse-keymap ns-list-services undefined ns-define-service define-key vector get-lisp-resource nil "NXAutoLaunch" "HideOnAutoLaunch" add-hook after-init-hook ns-do-hide-emacs menu-bar-mode "Menus" 1 -1 darwin before-init-hook #[0 "\302\20\303\211\21\207" [locale-coding-system default-process-coding-system utf-8-unix (utf-8-unix . utf-8-unix)] 2] ns-set-resource "ApplePressAndHoldEnabled" "NO" x-apply-session-resources suspend-hook ns-suspend-error menu-bar-help-menu system-type] 8 ("term/ns-win.elc" . 18449)]) #s(cl--generic-method nil nil nil #[256 "\300\207" [nil] 2 ("startup.elc" . 26535)])) nil) (((&context . window-system) #s(cl--generic-generalizer cl--generic-eql-generalizer 100 #[385 "\300\2\301BB\207" [gethash (cl--generic-eql-used)] 5 ("emacs-lisp/cl-generic.elc" . 6938)] #[385 "\1\242\300=\205\11\0\1A\207" [eql] 4 ("emacs-lisp/cl-generic.elc" . 6963)]) #s(cl--generic-generalizer cl--generic-t-generalizer 0 #[385 "\300\207" [nil] 3 ("emacs-lisp/cl-generic.elc" . 6938)] #[385 "\300\207" [(t)] 3 ("emacs-lisp/cl-generic.elc" . 6963)]))) (#s(cl--generic-method (((&context . window-system) eql 'ns)) nil nil #[256 "\10\203\10\0\306\307!\210\310\11!\21\311 \210\3121\34\0\313\n\314\"0\210\202&\0\315\316\317\320\4\"\321#\266\2\322\323 \206-\0\324\13\314#\210\325\326!\203X\0\327\24\330\15\331\332\16;B#\210\330\15\333\334#\210\330\15\335\336#\210\330\15\337\340\341\340!B#\210\342 \211\203\201\0\211@\211@\343=\203p\0\344\1A!\266\2\202}\0\345\15\346\3@!\344\4A!#\266\2A\202Z\0\210\347\350\351\"\314=\203\231\0\347\350\352\"\314=\203\231\0\353\354\355\"\210\356\347\350\357\"\203\245\0\360\202\246\0\361!\210\16<\362=\203\264\0\353\363\364\"\210\365\350\366\367#\210\370 \210\353\371\372\"\210\314\211\20\207" [ns-initialized command-line-args ns-standard-fontset-spec x-command-line-resources menu-bar-final-items global-map cl--assertion-failed (not ns-initialized) x-handle-args create-default-fontset (error) create-fontset-from-fontset-spec t display-warning initialization format "Creation of the standard fontset failed: %s" :error x-open-connection system-name "" featurep gnustep (buffer services hide-app quit) bindings--define-key [menu-bar help-menu] "Info" [menu-bar quit] (menu-item "Quit" save-buffers-kill-emacs :help "Save unsaved buffers, then exit") [menu-bar hide-app] (menu-item "Hide" ns-do-hide-emacs :help "Hide Emacs") [menu-bar services] "Services" make-sparse-keymap ns-list-services undefined ns-define-service define-key vector get-lisp-resource nil "NXAutoLaunch" "HideOnAutoLaunch" add-hook after-init-hook ns-do-hide-emacs menu-bar-mode "Menus" 1 -1 darwin before-init-hook #[0 "\302\20\303\211\21\207" [locale-coding-system default-process-coding-system utf-8-unix (utf-8-unix . utf-8-unix)] 2] ns-set-resource "ApplePressAndHoldEnabled" "NO" x-apply-session-resources suspend-hook ns-suspend-error menu-bar-help-menu system-type] 8 ("term/ns-win.elc" . 18449)]) #s(cl--generic-method nil nil nil #[256 "\300\207" [nil] 2 ("startup.elc" . 26535)])))
  cl--generic-make-function(#s(cl--generic window-system-initialization (((&context . window-system) #s(cl--generic-generalizer cl--generic-eql-generalizer 100 #[385 "\300\2\301BB\207" [gethash (cl--generic-eql-used)] 5 ("emacs-lisp/cl-generic.elc" . 6938)] #[385 "\1\242\300=\205\11\0\1A\207" [eql] 4 ("emacs-lisp/cl-generic.elc" . 6963)]) #s(cl--generic-generalizer cl--generic-t-generalizer 0 #[385 "\300\207" [nil] 3 ("emacs-lisp/cl-generic.elc" . 6938)] #[385 "\300\207" [(t)] 3 ("emacs-lisp/cl-generic.elc" . 6963)]))) (#s(cl--generic-method (((&context . window-system) eql 'ns)) nil nil #[256 "\10\203\10\0\306\307!\210\310\11!\21\311 \210\3121\34\0\313\n\314\"0\210\202&\0\315\316\317\320\4\"\321#\266\2\322\323 \206-\0\324\13\314#\210\325\326!\203X\0\327\24\330\15\331\332\16;B#\210\330\15\333\334#\210\330\15\335\336#\210\330\15\337\340\341\340!B#\210\342 \211\203\201\0\211@\211@\343=\203p\0\344\1A!\266\2\202}\0\345\15\346\3@!\344\4A!#\266\2A\202Z\0\210\347\350\351\"\314=\203\231\0\347\350\352\"\314=\203\231\0\353\354\355\"\210\356\347\350\357\"\203\245\0\360\202\246\0\361!\210\16<\362=\203\264\0\353\363\364\"\210\365\350\366\367#\210\370 \210\353\371\372\"\210\314\211\20\207" [ns-initialized command-line-args ns-standard-fontset-spec x-command-line-resources menu-bar-final-items global-map cl--assertion-failed (not ns-initialized) x-handle-args create-default-fontset (error) create-fontset-from-fontset-spec t display-warning initialization format "Creation of the standard fontset failed: %s" :error x-open-connection system-name "" featurep gnustep (buffer services hide-app quit) bindings--define-key [menu-bar help-menu] "Info" [menu-bar quit] (menu-item "Quit" save-buffers-kill-emacs :help "Save unsaved buffers, then exit") [menu-bar hide-app] (menu-item "Hide" ns-do-hide-emacs :help "Hide Emacs") [menu-bar services] "Services" make-sparse-keymap ns-list-services undefined ns-define-service define-key vector get-lisp-resource nil "NXAutoLaunch" "HideOnAutoLaunch" add-hook after-init-hook ns-do-hide-emacs menu-bar-mode "Menus" 1 -1 darwin before-init-hook #[0 "\302\20\303\211\21\207" [locale-coding-system default-process-coding-system utf-8-unix (utf-8-unix . utf-8-unix)] 2] ns-set-resource "ApplePressAndHoldEnabled" "NO" x-apply-session-resources suspend-hook ns-suspend-error menu-bar-help-menu system-type] 8 ("term/ns-win.elc" . 18449)]) #s(cl--generic-method nil nil nil #[256 "\300\207" [nil] 2 ("startup.elc" . 26535)])) nil))
  cl-generic-define-method(window-system-initialization nil (&context (window-system ns) &optional _display) nil #[256 "\10\203\10\0\306\307!\210\310\11!\21\311 \210\3121\34\0\313\n\314\"0\210\202&\0\315\316\317\320\4\"\321#\266\2\322\323 \206-\0\324\13\314#\210\325\326!\203X\0\327\24\330\15\331\332\16;B#\210\330\15\333\334#\210\330\15\335\336#\210\330\15\337\340\341\340!B#\210\342 \211\203\201\0\211@\211@\343=\203p\0\344\1A!\266\2\202}\0\345\15\346\3@!\344\4A!#\266\2A\202Z\0\210\347\350\351\"\314=\203\231\0\347\350\352\"\314=\203\231\0\353\354\355\"\210\356\347\350\357\"\203\245\0\360\202\246\0\361!\210\16<\362=\203\264\0\353\363\364\"\210\365\350\366\367#\210\370 \210\353\371\372\"\210\314\211\20\207" [ns-initialized command-line-args ns-standard-fontset-spec x-command-line-resources menu-bar-final-items global-map cl--assertion-failed (not ns-initialized) x-handle-args create-default-fontset (error) create-fontset-from-fontset-spec t display-warning initialization format "Creation of the standard fontset failed: %s" :error x-open-connection system-name "" featurep gnustep (buffer services hide-app quit) bindings--define-key [menu-bar help-menu] "Info" [menu-bar quit] (menu-item "Quit" save-buffers-kill-emacs :help "Save unsaved buffers, then exit") [menu-bar hide-app] (menu-item "Hide" ns-do-hide-emacs :help "Hide Emacs") [menu-bar services] "Services" make-sparse-keymap ns-list-services undefined ns-define-service define-key vector get-lisp-resource nil "NXAutoLaunch" "HideOnAutoLaunch" add-hook after-init-hook ns-do-hide-emacs menu-bar-mode "Menus" 1 -1 darwin before-init-hook #[0 "\302\20\303\211\21\207" [locale-coding-system default-process-coding-system utf-8-unix (utf-8-unix . utf-8-unix)] 2] ns-set-resource "ApplePressAndHoldEnabled" "NO" x-apply-session-resources suspend-hook ns-suspend-error menu-bar-help-menu system-type] 8 ("term/ns-win.elc" . 18449)])
  byte-code("\300\301\302\303\302\304%\210\305\306\307\"\210\300\310\302\311\302\312%\210\300\313\302\314\302\315%\207" [cl-generic-define-method window-system-initialization nil (&context (window-system ns) &optional _display) #[256 "\10\203\10\0\306\307!\210\310\11!\21\311 \210\3121\34\0\313\n\314\"0\210\202&\0\315\316\317\320\4\"\321#\266\2\322\323 \206-\0\324\13\314#\210\325\326!\203X\0\327\24\330\15\331\332\16;B#\210\330\15\333\334#\210\330\15\335\336#\210\330\15\337\340\341\340!B#\210\342 \211\203\201\0\211@\211@\343=\203p\0\344\1A!\266\2\202}\0\345\15\346\3@!\344\4A!#\266\2A\202Z\0\210\347\350\351\"\314=\203\231\0\347\350\352\"\314=\203\231\0\353\354\355\"\210\356\347\350\357\"\203\245\0\360\202\246\0\361!\210\16<\362=\203\264\0\353\363\364\"\210\365\350\366\367#\210\370 \210\353\371\372\"\210\314\211\20\207" [ns-initialized command-line-args ns-standard-fontset-spec x-command-line-resources menu-bar-final-items global-map cl--assertion-failed (not ns-initialized) x-handle-args create-default-fontset (error) create-fontset-from-fontset-spec t display-warning initialization format "Creation of the standard fontset failed: %s" :error x-open-connection system-name "" featurep gnustep (buffer services hide-app quit) bindings--define-key [menu-bar help-menu] "Info" [menu-bar quit] (menu-item "Quit" save-buffers-kill-emacs :help "Save unsaved buffers, then exit") [menu-bar hide-app] (menu-item "Hide" ns-do-hide-emacs :help "Hide Emacs") [menu-bar services] "Services" make-sparse-keymap ns-list-services undefined ns-define-service define-key vector get-lisp-resource nil "NXAutoLaunch" "HideOnAutoLaunch" add-hook after-init-hook ns-do-hide-emacs menu-bar-mode "Menus" 1 -1 darwin before-init-hook #[0 "\302\20\303\211\21\207" [locale-coding-systemMissing cl-generic dispatcher in the prefilled cache!
Missing for: ((&context . window-system) cl--generic-eql-generalizer cl--generic-t-generalizer)
You might need to add: (cl--generic-prefill-dispatchers (&context . window-system) (eql 'x))
 default-process-coding-system utf-8-unix (utf-8-unix . utf-8-unix)] 2] ns-set-resource "ApplePressAndHoldEnabled" "NO" x-apply-session-resources suspend-hook ns-suspend-error menu-bar-help-menu system-type] 8 ("term/ns-win.elc" . 18449)] add-to-list display-format-alist (".*" . ns) handle-args-function (args &context (window-system ns)) #[257 "\300\1!\207" [x-handle-args] 3 ("term/ns-win.elc" . 18537)] frame-creation-function (params &context (window-system ns)) #[257 "\300\1!\207" [x-create-frame-with-faces] 3 ("term/ns-win.elc" . 18554)]] 6)
  load("term/ns-win")
  (progn (load "international/mule-util") (load "international/ucs-normalize") (load "term/ns-win"))
  (if (featurep 'charprop) (progn (load "international/mule-util") (load "international/ucs-normalize") (load "term/ns-win")))
  (when (featurep 'charprop) (load "international/mule-util") (load "international/ucs-normalize") (load "term/ns-win"))
  (progn (load "term/common-win") (when (featurep 'charprop) (load "international/mule-util") (load "international/ucs-normalize") (load "term/ns-win")))
  (if (featurep 'ns) (progn (load "term/common-win") (when (featurep 'charprop) (load "international/mule-util") (load "international/ucs-normalize") (load "term/ns-win"))))
  load("loadup.el")
gmake[2]: *** [Makefile:685: emacs.pdmp] Error 255
gmake[1]: *** [Makefile:554: src] Error 2
***
*** "make all" failed with exit status 2.
***
*** You could try to:
*** - run "make bootstrap", which might fix the problem
*** - run "make V=1", which displays the full commands invoked by make,
***   to further investigate the problem
***
gmake[1]: *** [Makefile:418: advice-on-failure] Error 2
gmake: *** [Makefile:374: all] Error 2

real	5:48.60
user	16:52.93
sys	50.872
/Users/gerd/bin/make-emacs --cache-file /var/folders/1d/k_6t25f94sl83szqbf8gpkrh0000gn/T//config.cache.igc --enable-checking --with-native-compilation=no --with-mps=debug CC=clang CFLAGS=-g -O0 complete.

Compilation finished at Mon Apr 15 08:04:40, duration 0:05:49