unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Filippo Argiolas <filippo.argiolas@gmail.com>
To: Yuan Fu <casouri@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>,
	Vincenzo Pupillo <v.pupillo@gmail.com>,
	Stefan Kangas <stefankangas@gmail.com>,
	75012@debbugs.gnu.org
Subject: bug#75012: 31.0.50; Use a different face for storage_class in c-ts-mode doxygen comments
Date: Thu, 26 Dec 2024 08:54:04 +0100	[thread overview]
Message-ID: <m2ldw2517n.fsf@gmail.com> (raw)
In-Reply-To: <FE03A985-EDA5-4612-A6F8-086B6B3334D0@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 967 bytes --]

Yuan Fu <casouri@gmail.com> writes:

>> On Dec 24, 2024, at 11:32 PM, Filippo Argiolas <filippo.argiolas@gmail.com> wrote:
>> 
>> Stefan Kangas <stefankangas@gmail.com> writes:
>> 
>>> Yuan Fu <casouri@gmail.com> writes:
>>> 
>>>> Thanks for the ping. From the screenshot it looks very nice! If no one
>>>> objects I think we should merge this.
>>> 
>>> Sounds good to me.
>> 
>> Great! If you go ahead and install this feel free to take this as a
>> trivial suggestion as I still don't have the signed agreement.
>
> Your patch seems to be within 15 LOC, in that case we can apply it even without the assignment (unless you’ve used the 15 LOC wavier before). Do you want to submit a patch?
>

I have two 'Co-authored' commits, mostly doc changes were I was involved
in the discussion but I wouldn't say I authored, and one 'Suggested by'
trivial bug fix.

I guess I'm still within the trivial realm, patch attached.

Thanks,
Filippo


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Improve-doxygen-comments-font-lock-rules-in-c-ts-mod.patch --]
[-- Type: text/x-patch, Size: 1208 bytes --]

From 09b26c95fce881a375393864c9487c1f4d45f05a Mon Sep 17 00:00:00 2001
From: Filippo Argiolas <filippo.argiolas@gmail.com>
Date: Thu, 26 Dec 2024 08:06:55 +0100
Subject: [PATCH] Improve doxygen comments font lock rules in c-ts modes

* lisp/progmodes/c-ts-common.el
(c-ts-mode-doxygen-comment-font-lock-settings): Add rules for type,
storageclass and note/warning/error tags.  (Bug#75012)

Copyright-paperwork-exempt: yes
---
 lisp/progmodes/c-ts-common.el | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/lisp/progmodes/c-ts-common.el b/lisp/progmodes/c-ts-common.el
index 25b386cbaa7..7a0b2660095 100644
--- a/lisp/progmodes/c-ts-common.el
+++ b/lisp/progmodes/c-ts-common.el
@@ -397,7 +397,12 @@ c-ts-mode-doxygen-comment-font-lock-settings
    :override t
    :feature 'keyword
    '((tag_name) @font-lock-constant-face
-     (storageclass) @font-lock-constant-face)
+     (type) @font-lock-type-face
+     (emphasis) @bold
+     ((tag_name) @bold (:match ".note" @bold))
+     ((tag_name) @warning (:match ".warning" @warning))
+     ((tag_name) @error (:match ".error" @error))
+     (storageclass) @font-lock-keyword-face)
 
    :language 'doxygen
    :override t
-- 
2.47.0


      reply	other threads:[~2024-12-26  7:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-21 18:21 bug#75012: 31.0.50; Use a different face for storage_class in c-ts-mode doxygen comments Filippo Argiolas
2024-12-21 21:18 ` Vincenzo Pupillo
2024-12-22  6:20   ` Eli Zaretskii
2024-12-24  0:48     ` Yuan Fu
2024-12-24  2:37       ` Stefan Kangas
2024-12-25  7:32         ` Filippo Argiolas
2024-12-25  8:29           ` Yuan Fu
2024-12-26  7:54             ` Filippo Argiolas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2ldw2517n.fsf@gmail.com \
    --to=filippo.argiolas@gmail.com \
    --cc=75012@debbugs.gnu.org \
    --cc=casouri@gmail.com \
    --cc=eliz@gnu.org \
    --cc=stefankangas@gmail.com \
    --cc=v.pupillo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).