From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nikolaj Schumacher Newsgroups: gmane.emacs.bugs Subject: bug#423: flymake faces hard to read on dark backgrounds Date: Sun, 15 Jun 2008 23:00:15 +0200 Message-ID: Reply-To: Nikolaj Schumacher , 423@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1213565245 3200 80.91.229.12 (15 Jun 2008 21:27:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 15 Jun 2008 21:27:25 +0000 (UTC) To: bug-gnu-emacs@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 15 23:28:09 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1K7zlg-0005jn-0o for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 Jun 2008 23:28:08 +0200 Original-Received: from localhost ([127.0.0.1]:59346 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K7zkr-0007qN-Q9 for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 Jun 2008 17:27:17 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K7zkn-0007qI-AG for bug-gnu-emacs@gnu.org; Sun, 15 Jun 2008 17:27:13 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K7zkk-0007p9-Ol for bug-gnu-emacs@gnu.org; Sun, 15 Jun 2008 17:27:11 -0400 Original-Received: from [199.232.76.173] (port=55955 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K7zkk-0007p6-KB for bug-gnu-emacs@gnu.org; Sun, 15 Jun 2008 17:27:10 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:51935) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1K7zkk-0000Wu-9t for bug-gnu-emacs@gnu.org; Sun, 15 Jun 2008 17:27:10 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m5FLR85m026572; Sun, 15 Jun 2008 14:27:08 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m5FLA4HY022056; Sun, 15 Jun 2008 14:10:04 -0700 X-Loop: don@donarmstrong.com Resent-From: Nikolaj Schumacher Original-Sender: n_schumacher@web.de Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sun, 15 Jun 2008 21:10:04 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 423 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by submit@emacsbugs.donarmstrong.com id=B.121356362819532 (code B ref -1); Sun, 15 Jun 2008 21:10:04 +0000 Original-Received: (at submit) by emacsbugs.donarmstrong.com; 15 Jun 2008 21:00:28 +0000 Original-Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m5FL0KUA019397 for ; Sun, 15 Jun 2008 14:00:21 -0700 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K7zKl-0003WG-Vn for bug-gnu-emacs@gnu.org; Sun, 15 Jun 2008 17:00:20 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K7zKk-0003Vd-Fk for bug-gnu-emacs@gnu.org; Sun, 15 Jun 2008 17:00:19 -0400 Original-Received: from [199.232.76.173] (port=45996 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K7zKk-0003VX-8A for bug-gnu-emacs@gnu.org; Sun, 15 Jun 2008 17:00:18 -0400 Original-Received: from fmmailgate01.web.de ([217.72.192.221]:43663) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1K7zKj-0005qa-Qf for bug-gnu-emacs@gnu.org; Sun, 15 Jun 2008 17:00:18 -0400 Original-Received: from smtp05.web.de (fmsmtp05.dlan.cinetic.de [172.20.4.166]) by fmmailgate01.web.de (Postfix) with ESMTP id B851BE42A2E3 for ; Sun, 15 Jun 2008 23:00:16 +0200 (CEST) Original-Received: from [77.189.15.115] (helo=thursday) by smtp05.web.de with asmtp (WEB.DE 4.109 #226) id 1K7zKi-0004hQ-00 for bug-gnu-emacs@gnu.org; Sun, 15 Jun 2008 23:00:16 +0200 User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2.50 (darwin) X-Sender: n_schumacher@web.de X-Provags-ID: V01U2FsdGVkX1/zwNC3Dk/eHpE0w9XFy83XMKia4D5orbph8ZUZ t9Rc+caR9vmmC6bV8AULvIDQp4OyCxAzgMX2qWyDDarR5YbRkR s6kP1oVK2mICDR/CUWUA== X-detected-kernel: by monty-python.gnu.org: Linux 2.4-2.6 X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Resent-Date: Sun, 15 Jun 2008 17:27:11 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:18415 Archived-At: --=-=-= Hello, flymake-errline and flymake-warnline faces are very hard to read on dark backgrounds. regards, Nikolaj Schumacher --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=emacs-flymake-face-colors.patch Content-Description: patch diff -du /Users/nik/emacs/var/backup/\!Applications\!Emacs.app\!Contents\!Resources\!share\!emacs\!22.2.50\!lisp\!progmodes\!flymake.el.\~1\~ /Applications/Emacs.app/Contents/Resources/share/emacs/22.2.50/lisp/progmodes/flymake.el --- lisp/progmodes/flymake.el 2008-06-12 23:22:42.000000000 +0200 +++ lisp/progmodes/flymake.el 2008-06-15 22:28:02.000000000 +0200 @@ -799,15 +799,15 @@ has-flymake-overlays)) (defface flymake-errline - ;;+ '((((class color)) (:foreground "OrangeRed" :bold t :underline t)) - ;;+ '((((class color)) (:underline "OrangeRed")) - '((((class color)) (:background "LightPink")) + '((((background dark)) (:background "Firebrick4")) + (((background light)) (:background "LightPink")) (t (:bold t))) "Face used for marking error lines." :group 'flymake) (defface flymake-warnline - '((((class color)) (:background "LightBlue2")) + '((((background dark)) (:background "DarkBlue")) + (((background light)) (:background "LightBlue2")) (t (:bold t))) "Face used for marking warning lines." :group 'flymake) Diff finished. Sun Jun 15 22:28:11 2008 --=-=-=--