bug#6098: 23.1; gud-break doesn't deal with Python modules

bug#6098: 23.1; gud-break doesn't deal with Python modules

[David Abrahams]

Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the bug-gnu-emacs@gnu.org mailing list,
and to the gnu.emacs.bug news group.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

1. Create the following directory hierarchy:

       /tmp/fu

       /tmp/fu/probe (executable)
           #!/bin/sh
           python -m pdb /tmp/fu/tst.py

       /tmp/fu/bar/__init__.py
           import bar.baz

       /tmp/fu/bar/baz.py
           print 'hello'

2. `M-x pdb RET /tmp/fu/probe RET'

3. `import sys RET'

4. `p sys.path'

5. Note that /tmp/fu is the first directory in sys.path

6. `C-x C-f /tmp/fu/bar/baz.py'

7. `M-x gud-break'

You'll see “pdbtrack: Traceback cue not found” in *Messages* and
“***  'bar.py' not found from sys.path” in *gud*.  No breakpoint is
set.  However, the module is available on sys.path as bar.baz

If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
/Applications/Emacs.app/Contents/Resources/etc/DEBUG for instructions.


In GNU Emacs 23.1.1 (i386-apple-darwin9.8.0, NS apple-appkit-949.54)
 of 2009-08-16 on black.local
Windowing system distributor `Apple', version 10.3.1038
configured using `configure  '--with-ns''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: nil
  value of $XMODIFIERS: nil
  locale-coding-system: nil
  default-enable-multibyte-characters: t

Major mode: Debugger

Minor modes in effect:
  diff-auto-refine-mode: t
  show-paren-mode: t
  global-auto-revert-mode: t
  delete-selection-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
C-x C-f / t m p / x <return> M-x M-p C-g M-x p d b 
<return> C-a C-k . / p r o b e 2 <return> i m p o r 
t SPC s y s <return> p r i n t SPC s y s . p a t h 
<return> C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p 
C-p C-p C-p C-x C-p C-x C-b C-x C-b C-x C-b C-x C-b 
C-x C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n 
C-n C-n C-n C-n C-x C-f f u / _ _ <tab> <return> C-x 
C-f C-g C-x SPC C-x C-p C-x C-b C-x C-b C-x C-b C-x 
C-n C-x C-f b a r <tab> <return> C-x SPC C-x C-p C-p 
C-p C-p C-p M-x r e p o r t - e m a <tab> <return> 
C-g C-g C-x C-n C-h k C-x SPC C-x C-p C-x C-k C-n C-n 
C-n C-n C-n M-x M-p <return>

Recent messages:
Quit [2 times]
Mark set
pdbtrack: Traceback cue not found [2 times]
Quit
Command: break __init__.py:1
pdbtrack: Traceback cue not found
Command: break bar.py:1
pdbtrack: Traceback cue not found
Quit [2 times]
Type C-x 4 C-o RET to restore the other window.

-- 
Dave Abrahams           Meet me at BoostCon: http://www.boostcon.com
BoostPro Computing
http://www.boostpro.com

bug#6098: Fix for broken breakpoint handling in gud pdb

[Syver Enstad]

Patch for gud.el version 23.1 line 1636

The point of this patch is to give pdb full paths so that one can set 
breakpoints
in files outside the current directory.

This is acheived by addding the %d specification to the command.


--- /tmp/original.el    2011-03-18 17:55:30.131681523 +0100
+++ /tmp/improved.el    2011-03-18 17:55:14.870401366 +0100
@@ -1633,8 +1633,8 @@
    (gud-common-init command-line nil 'gud-pdb-marker-filter)
    (set (make-local-variable 'gud-minor-mode) 'pdb)

-  (gud-def gud-break  "break %f:%l"  "\C-b" "Set breakpoint at current 
line.")
-  (gud-def gud-remove "clear %f:%l"  "\C-d" "Remove breakpoint at 
current line")
+  (gud-def gud-break  "break %d%f:%l"  "\C-b" "Set breakpoint at 
current line.")
+  (gud-def gud-remove "clear %d%f:%l"  "\C-d" "Remove breakpoint at 
current line")
    (gud-def gud-step   "step"         "\C-s" "Step one source line with 
display.")
    (gud-def gud-next   "next"         "\C-n" "Step one line (skip 
functions).")
    (gud-def gud-cont   "continue"     "\C-r" "Continue with display.")

bug#6098: Fix for broken breakpoint handling in gud pdb

[Chong Yidong]

Syver Enstad <syver.enstad@cisco.com> writes:

> Patch for gud.el version 23.1 line 1636
>
> The point of this patch is to give pdb full paths so that one can set
> breakpoints
> in files outside the current directory.
>
> This is acheived by addding the %d specification to the command.

Your patch has been committed to trunk.  Thanks.

bug#6098: Someone obviously tried to fix this upstream...

[Dave Abrahams]

Currently the code reads as follows:

    (gud-def gud-break  "break %d%f:%l"  "\C-b" "Set breakpoint at current line.")
    (gud-def gud-remove "clear %d%f:%l"  "\C-d" "Remove breakpoint at current line")

However, tests show that it doesn't work without the directory separator
"/" after "%d" on both lines.

-- 
Dave Abrahams
BoostPro Computing
http://www.boostpro.com

bug#6098: Someone obviously tried to fix this upstream...

[Andreas Schwab]

Dave Abrahams <dave@boostpro.com> writes:

> Currently the code reads as follows:
>
>     (gud-def gud-break  "break %d%f:%l"  "\C-b" "Set breakpoint at current line.")
>     (gud-def gud-remove "clear %d%f:%l"  "\C-d" "Remove breakpoint at current line")
>
> However, tests show that it doesn't work without the directory separator
> "/" after "%d" on both lines.

%d always expands to a string with a trailing slash.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."