From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: charles@aurox.ch (Charles A. Roelli) Newsgroups: gmane.emacs.bugs Subject: bug#25784: 25.2; mouse-1 binding in debbugs-gnu.el Date: Mon, 20 Feb 2017 09:55:53 +0100 Message-ID: References: <87k28npqay.fsf@linux-m68k.org> <87d1eds2ed.fsf@detlef> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1487581039 14146 195.159.176.226 (20 Feb 2017 08:57:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 20 Feb 2017 08:57:19 +0000 (UTC) Cc: Andreas Schwab , 25784-done@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Feb 20 09:57:13 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cfjmQ-0002hn-TK for geb-bug-gnu-emacs@m.gmane.org; Mon, 20 Feb 2017 09:57:11 +0100 Original-Received: from localhost ([::1]:36764 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cfjmT-0001oI-F4 for geb-bug-gnu-emacs@m.gmane.org; Mon, 20 Feb 2017 03:57:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52393) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cfjmN-0001mW-8D for bug-gnu-emacs@gnu.org; Mon, 20 Feb 2017 03:57:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cfjmI-0003in-Co for bug-gnu-emacs@gnu.org; Mon, 20 Feb 2017 03:57:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48652) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cfjmI-0003hz-6K for bug-gnu-emacs@gnu.org; Mon, 20 Feb 2017 03:57:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cfjmH-000156-Qu for bug-gnu-emacs@gnu.org; Mon, 20 Feb 2017 03:57:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: charles@aurox.ch (Charles A. Roelli) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 Feb 2017 08:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25784 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25784-done@debbugs.gnu.org id=D25784.14875809674090 (code D ref 25784); Mon, 20 Feb 2017 08:57:01 +0000 Original-Received: (at 25784-done) by debbugs.gnu.org; 20 Feb 2017 08:56:07 +0000 Original-Received: from localhost ([127.0.0.1]:46850 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cfjlP-00013u-Ed for submit@debbugs.gnu.org; Mon, 20 Feb 2017 03:56:07 -0500 Original-Received: from sinyavsky.aurox.ch ([37.35.109.145]:46880) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cfjlN-00013P-78 for 25784-done@debbugs.gnu.org; Mon, 20 Feb 2017 03:56:05 -0500 Original-Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id 4B91922366 for <25784-done@debbugs.gnu.org>; Mon, 20 Feb 2017 08:52:58 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass (1024-bit key) reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= content-type:content-type:mime-version:message-id:in-reply-to :date:date:references:subject:subject:to:from:from; s=dkim; t= 1487580776; x=1488444777; bh=DIrD6q+7C8Ov5w+FVXCHzVNZZp8w9JqlFBx jsjNWjQI=; b=jprTwxhSvDLXgPtZPxeY5BZIiblOEfL6oJM33h1toeTjNWT6WZn Ubxxzk9LyIt62dH+w8EIrWDiWH5q1vGKSCLfvTVToGHs4vGbqBJ8oMJRgSv/XK7x bi5+UdH58dNX2VhFrPT1+Z9Ri3ToXTVnrIs8ktfzZKTCTsl7/cJ+a2uY= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Original-Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id BXwDgPJ-Y2Ex for <25784-done@debbugs.gnu.org>; Mon, 20 Feb 2017 08:52:56 +0000 (UTC) Original-Received: from gray (54.4.4.85.dynamic.wline.res.cust.swisscom.ch [85.4.4.54]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id 96FDB22357; Mon, 20 Feb 2017 08:52:53 +0000 (UTC) In-Reply-To: <87d1eds2ed.fsf@detlef> (Michael Albinus's message of "Mon, 20 Feb 2017 09:16:26 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:129569 Archived-At: Thanks for looking into this, Michael. I realize now that this change only makes sense if mouse-2 sets point when clicked, as it does in Gnus. I think what follows is the correct way to do it, and it works as expected. --- debbugs-0.12/debbugs-gnu.el.~1~ 2016-10-31 22:02:05.000000000 +0100 +++ debbugs-0.12/debbugs-gnu.el 2017-02-19 12:56:02.000000000 +0100 @@ -909,7 +909,6 @@ (menu-map (make-sparse-keymap))) (set-keymap-parent map tabulated-list-mode-map) (define-key map "\r" 'debbugs-gnu-select-report) - (define-key map [mouse-1] 'debbugs-gnu-select-report) (define-key map [mouse-2] 'debbugs-gnu-select-report) (define-key map "g" 'debbugs-gnu-rescan) (define-key map "R" 'debbugs-gnu-show-all-blocking-reports) @@ -1347,9 +1346,10 @@ (format "Re: bug#%d: %s" id (cdr (assq 'subject status)))) (debbugs-gnu-summary-mode 1))) -(defun debbugs-gnu-select-report () +(defun debbugs-gnu-select-report (&optional event) "Select the report on the current line." - (interactive) + (interactive "e") + (when event (mouse-set-point event)) ;; We open the report messages. (let* ((status (debbugs-gnu-current-status)) (id (cdr (assq 'id status))) @@ -1587,7 +1587,6 @@ (let ((map (make-sparse-keymap))) (set-keymap-parent map tabulated-list-mode-map) (define-key map "\r" 'debbugs-gnu-select-usertag) - (define-key map [mouse-1] 'debbugs-gnu-select-usertag) (define-key map [mouse-2] 'debbugs-gnu-select-usertag) map)) @@ -1665,9 +1664,10 @@ (set-buffer-modified-p nil) (goto-char (point-min))))) -(defun debbugs-gnu-select-usertag () +(defun debbugs-gnu-select-usertag (&optional event) "Select the user tag on the current line." - (interactive) + (interactive "e") + (when event (mouse-set-point event)) ;; We open the bug reports. (let ((args (get-text-property (line-beginning-position) 'tabulated-list-id))) (when args (apply 'debbugs-gnu args))))