unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#28818: kmacro stepping: void-variable kmacro-step-edit-active
@ 2017-10-13 18:36 Charles A. Roelli
  2017-10-13 19:07 ` Eli Zaretskii
  0 siblings, 1 reply; 5+ messages in thread
From: Charles A. Roelli @ 2017-10-13 18:36 UTC (permalink / raw)
  To: 28818

From the pretest 26.0.90:

C-x b RET 			> switch to *scratch*
F3 abc F4			> define a simple kmacro
C-x C-k SPC			> edit it
SPC SPC SPC			> run through it

Error in post-command-hook (kmacro-step-edit-post-command):
(void-variable kmacro-step-edit-active)





^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#28818: kmacro stepping: void-variable kmacro-step-edit-active
  2017-10-13 18:36 bug#28818: kmacro stepping: void-variable kmacro-step-edit-active Charles A. Roelli
@ 2017-10-13 19:07 ` Eli Zaretskii
  2017-10-15 18:40   ` Charles A. Roelli
  0 siblings, 1 reply; 5+ messages in thread
From: Eli Zaretskii @ 2017-10-13 19:07 UTC (permalink / raw)
  To: Charles A. Roelli; +Cc: 28818

> Date: Fri, 13 Oct 2017 20:36:16 +0200
> From: charles@aurox.ch (Charles A. Roelli)
> 
> From the pretest 26.0.90:
> 
> C-x b RET 			> switch to *scratch*
> F3 abc F4			> define a simple kmacro
> C-x C-k SPC			> edit it
> SPC SPC SPC			> run through it
> 
> Error in post-command-hook (kmacro-step-edit-post-command):
> (void-variable kmacro-step-edit-active)

Does the below fix this?

diff --git a/lisp/kmacro.el b/lisp/kmacro.el
index 582a58e..4abc571 100644
--- a/lisp/kmacro.el
+++ b/lisp/kmacro.el
@@ -937,7 +937,7 @@ kmacro-edit-lossage
 
 ;;; Single-step editing of keyboard macros
 
-(defvar kmacro-step-edit-active)  	 ;; step-editing active
+(defvar kmacro-step-edit-active nil)  	 ;; step-editing active
 (defvar kmacro-step-edit-new-macro)  	 ;; storage for new macro
 (defvar kmacro-step-edit-inserting)  	 ;; inserting into macro
 (defvar kmacro-step-edit-appending)  	 ;; append to end of macro





^ permalink raw reply related	[flat|nested] 5+ messages in thread

* bug#28818: kmacro stepping: void-variable kmacro-step-edit-active
  2017-10-13 19:07 ` Eli Zaretskii
@ 2017-10-15 18:40   ` Charles A. Roelli
  2017-10-16 16:38     ` Eli Zaretskii
  0 siblings, 1 reply; 5+ messages in thread
From: Charles A. Roelli @ 2017-10-15 18:40 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 28818

> Date: Fri, 13 Oct 2017 22:07:34 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> 
> > Date: Fri, 13 Oct 2017 20:36:16 +0200
> > From: charles@aurox.ch (Charles A. Roelli)
> > 
> > From the pretest 26.0.90:
> > 
> > C-x b RET 			> switch to *scratch*
> > F3 abc F4			> define a simple kmacro
> > C-x C-k SPC			> edit it
> > SPC SPC SPC			> run through it
> > 
> > Error in post-command-hook (kmacro-step-edit-post-command):
> > (void-variable kmacro-step-edit-active)
> 
> Does the below fix this?
> 
> diff --git a/lisp/kmacro.el b/lisp/kmacro.el
> index 582a58e..4abc571 100644
> --- a/lisp/kmacro.el
> +++ b/lisp/kmacro.el
> @@ -937,7 +937,7 @@ kmacro-edit-lossage
>  
>  ;;; Single-step editing of keyboard macros
>  
> -(defvar kmacro-step-edit-active)  	 ;; step-editing active
> +(defvar kmacro-step-edit-active nil)  	 ;; step-editing active
>  (defvar kmacro-step-edit-new-macro)  	 ;; storage for new macro
>  (defvar kmacro-step-edit-inserting)  	 ;; inserting into macro
>  (defvar kmacro-step-edit-appending)  	 ;; append to end of macro

Yes it does.  Thanks.





^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#28818: kmacro stepping: void-variable kmacro-step-edit-active
  2017-10-15 18:40   ` Charles A. Roelli
@ 2017-10-16 16:38     ` Eli Zaretskii
  2017-10-16 18:39       ` Charles A. Roelli
  0 siblings, 1 reply; 5+ messages in thread
From: Eli Zaretskii @ 2017-10-16 16:38 UTC (permalink / raw)
  To: Charles A. Roelli; +Cc: 28818

merge 18708 28818
close 28818
thanks

> Date: Sun, 15 Oct 2017 20:40:49 +0200
> From: charles@aurox.ch (Charles A. Roelli)
> CC: 28818@debbugs.gnu.org
> 
> > Does the below fix this?
> > 
> > diff --git a/lisp/kmacro.el b/lisp/kmacro.el
> > index 582a58e..4abc571 100644
> > --- a/lisp/kmacro.el
> > +++ b/lisp/kmacro.el
> > @@ -937,7 +937,7 @@ kmacro-edit-lossage
> >  
> >  ;;; Single-step editing of keyboard macros
> >  
> > -(defvar kmacro-step-edit-active)  	 ;; step-editing active
> > +(defvar kmacro-step-edit-active nil)  	 ;; step-editing active
> >  (defvar kmacro-step-edit-new-macro)  	 ;; storage for new macro
> >  (defvar kmacro-step-edit-inserting)  	 ;; inserting into macro
> >  (defvar kmacro-step-edit-appending)  	 ;; append to end of macro
> 
> Yes it does.  Thanks.

Thanks, pushed.  As a nice bonus, one more kmacro test now succeeds,
as this bug is a duplicate of bug#18708.





^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#28818: kmacro stepping: void-variable kmacro-step-edit-active
  2017-10-16 16:38     ` Eli Zaretskii
@ 2017-10-16 18:39       ` Charles A. Roelli
  0 siblings, 0 replies; 5+ messages in thread
From: Charles A. Roelli @ 2017-10-16 18:39 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 28818

> Date: Mon, 16 Oct 2017 19:38:28 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> 
> merge 18708 28818
> close 28818
> thanks
> 
> > Date: Sun, 15 Oct 2017 20:40:49 +0200
> > From: charles@aurox.ch (Charles A. Roelli)
> > CC: 28818@debbugs.gnu.org
> > 
> > > Does the below fix this?
> > > 
> > > diff --git a/lisp/kmacro.el b/lisp/kmacro.el
> > > index 582a58e..4abc571 100644
> > > --- a/lisp/kmacro.el
> > > +++ b/lisp/kmacro.el
> > > @@ -937,7 +937,7 @@ kmacro-edit-lossage
> > >  
> > >  ;;; Single-step editing of keyboard macros
> > >  
> > > -(defvar kmacro-step-edit-active)  	 ;; step-editing active
> > > +(defvar kmacro-step-edit-active nil)  	 ;; step-editing active
> > >  (defvar kmacro-step-edit-new-macro)  	 ;; storage for new macro
> > >  (defvar kmacro-step-edit-inserting)  	 ;; inserting into macro
> > >  (defvar kmacro-step-edit-appending)  	 ;; append to end of macro
> > 
> > Yes it does.  Thanks.
> 
> Thanks, pushed.  As a nice bonus, one more kmacro test now succeeds,
> as this bug is a duplicate of bug#18708.

Good catch!  Thanks for your help with this.





^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2017-10-16 18:39 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-13 18:36 bug#28818: kmacro stepping: void-variable kmacro-step-edit-active Charles A. Roelli
2017-10-13 19:07 ` Eli Zaretskii
2017-10-15 18:40   ` Charles A. Roelli
2017-10-16 16:38     ` Eli Zaretskii
2017-10-16 18:39       ` Charles A. Roelli

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).