From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: charles@aurox.ch (Charles A. Roelli) Newsgroups: gmane.emacs.bugs Subject: bug#31240: 26.1; mouse-save-then-kill does not kill rectangles Date: Sun, 23 Sep 2018 12:16:52 +0200 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1537697595 20746 195.159.176.226 (23 Sep 2018 10:13:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 23 Sep 2018 10:13:15 +0000 (UTC) Cc: 31240@debbugs.gnu.org To: Federico Tedin Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 23 12:13:10 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g41Nx-0005B0-62 for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 Sep 2018 12:13:05 +0200 Original-Received: from localhost ([::1]:39995 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g41Q3-0004h1-Cf for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 Sep 2018 06:15:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40668) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g41Px-0004fh-GJ for bug-gnu-emacs@gnu.org; Sun, 23 Sep 2018 06:15:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g41Pr-0006SA-RI for bug-gnu-emacs@gnu.org; Sun, 23 Sep 2018 06:15:09 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46050) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g41Pq-0006RW-7L for bug-gnu-emacs@gnu.org; Sun, 23 Sep 2018 06:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1g41Pq-0003A9-1d for bug-gnu-emacs@gnu.org; Sun, 23 Sep 2018 06:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: charles@aurox.ch (Charles A. Roelli) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Sep 2018 10:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31240 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31240-submit@debbugs.gnu.org id=B31240.153769767512110 (code B ref 31240); Sun, 23 Sep 2018 10:15:02 +0000 Original-Received: (at 31240) by debbugs.gnu.org; 23 Sep 2018 10:14:35 +0000 Original-Received: from localhost ([127.0.0.1]:50308 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g41PP-00039G-7H for submit@debbugs.gnu.org; Sun, 23 Sep 2018 06:14:35 -0400 Original-Received: from sinyavsky.aurox.ch ([37.35.109.145]:47527) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g41PM-000391-I2 for 31240@debbugs.gnu.org; Sun, 23 Sep 2018 06:14:33 -0400 Original-Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id 0C21F2286D for <31240@debbugs.gnu.org>; Sun, 23 Sep 2018 10:18:16 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= references:subject:subject:in-reply-to:to:from:from:message-id :date:date; s=dkim; t=1537697894; x=1538561895; bh=hIRVNrDPSehrv 3J3Dn2+Xno11OPspB/+F8XTAsIFE28=; b=kDmcBpC3EDW1nSU2FP8LAFyndVpd1 2KHTKcOmFhSPQnwCAinnddezjlfCcpTgxt/R7jHEgpv8RKTi+p6d4tIqHeHLaOPU fwup5mezFH39p9yJn8QTphJw5c5dsB5omJyFZrYW0UVBnOUfI8uGhHl99k7S3/mu SBRjXWymtXBsjc= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Original-Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id z2LJoXGOcn_1 for <31240@debbugs.gnu.org>; Sun, 23 Sep 2018 10:18:14 +0000 (UTC) Original-Received: from gray (unknown [IPv6:2a02:1205:c693:2d60:c62c:3ff:fe30:b864]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id C1C5922849; Sun, 23 Sep 2018 10:18:14 +0000 (UTC) In-reply-to: (message from Federico Tedin on Sat, 22 Sep 2018 17:05:19 -0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:150569 Archived-At: > From: Federico Tedin > Date: Sat, 22 Sep 2018 17:05:19 -0300 > > After reading more of the code in mouse.el, I found that > mouse-save-then-kill is the only function that allows using the mouse > to set/resize rectangular regions. I'm attaching a patch that fixes > all three use cases for this function: setting the region initially, > resizing the region, and killing the region. I've also made sure it > works correctly when mouse-drag-copy-region is set to t. Hope it helps. Thanks, this looks good. I think we also need a similar change for function "mouse-drag-and-drop-region", which is used when the variable of the same name is non-nil. For example, the following recipe exposes it: M-x set-variable RET mouse-drag-and-drop-region RET t RET M-< C-SPC M-f C-n C-x SPC Drag the rectangle region with the mouse, and its shape is ignored Hopefully we can apply the same kind of change in that function too.