From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#39865: 28.0.50; Emacs crash Date: Tue, 10 Mar 2020 16:15:09 +0100 Message-ID: References: <83fteryy4o.fsf@gnu.org> <837dzyuf20.fsf@gnu.org> <83a74tbc9v.fsf@gnu.org> <83tv2w9sa3.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="83392"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 39865@debbugs.gnu.org, viniciusjl@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 10 16:25:52 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jBglU-000LaD-9O for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 10 Mar 2020 16:25:52 +0100 Original-Received: from localhost ([::1]:35610 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBglT-0005sY-BW for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 10 Mar 2020 11:25:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35428) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBgbz-00083P-J0 for bug-gnu-emacs@gnu.org; Tue, 10 Mar 2020 11:16:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jBgby-00058C-EN for bug-gnu-emacs@gnu.org; Tue, 10 Mar 2020 11:16:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47137) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jBgby-00057g-8Q for bug-gnu-emacs@gnu.org; Tue, 10 Mar 2020 11:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jBgby-0002OG-3r for bug-gnu-emacs@gnu.org; Tue, 10 Mar 2020 11:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 10 Mar 2020 15:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39865 X-GNU-PR-Package: emacs Original-Received: via spool by 39865-submit@debbugs.gnu.org id=B39865.15838533219120 (code B ref 39865); Tue, 10 Mar 2020 15:16:02 +0000 Original-Received: (at 39865) by debbugs.gnu.org; 10 Mar 2020 15:15:21 +0000 Original-Received: from localhost ([127.0.0.1]:53104 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jBgbI-0002N2-Og for submit@debbugs.gnu.org; Tue, 10 Mar 2020 11:15:21 -0400 Original-Received: from mail-wm1-f53.google.com ([209.85.128.53]:54433) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jBgbH-0002Mp-Be for 39865@debbugs.gnu.org; Tue, 10 Mar 2020 11:15:19 -0400 Original-Received: by mail-wm1-f53.google.com with SMTP id n8so1827276wmc.4 for <39865@debbugs.gnu.org>; Tue, 10 Mar 2020 08:15:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=VT3AodG83IFXYEQ3BMKWHDsWywvuEIHC5BLqv0qZTQM=; b=G730e3qDgvsb1fsv08bFqRogBpEbM8W6IES5bj8Hq7+fwEpmrlvTFH/qwEsZ81VdWF HvbuV+CMKp9QlT6zVmYdJwWEmzPBQWTCJ8es2tiKCjMiag/YDvHOZuUO+XL64uhSi2Hk 5MB3SO7ZxoSFlXmk9uBP/s0oZ65WEgZ2VqfdvgXsL4o70NZvlYofscBDC747QLsvXtlj Ozg49tFxQjnCmvgXZsW6VLQdQAHJLImNHOklVOcWH8RgkB1DvOYGCXJqUa+rjMsEzoNM EQZBzwqA2RQTplyRAD/vc78DSXKXSzuOMaYB4FvRc+pPRGYMIgZ5XgweBs9HEF+qYVs3 SFeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=VT3AodG83IFXYEQ3BMKWHDsWywvuEIHC5BLqv0qZTQM=; b=TnMB7uvGy6m5gUEPNLgKfPXnn68qlbrHWJQnifPCqdc4HV6KHBOG83SvT2nCXL8XCO SpYqrPGogczT23Rx6wajndqVCqXi6ATbw/9dn7DruG606Zf0hRlG6NCNYDfUrVJk4lHW A7U3ootsitv8vCFgotkU9WdC4Ae8ISw7aLyuURm20+jqvTDKMWmFZMu5ea7oYXAjEGAs 3ttCrQWNfA5jbwTTXSrDdik2Sr4HtueJDgUTaPNO2ut/z5p+0+eFvHvVfJhJ77ASwUaa nkkHV0D2dvQQr2izMD2LKFsY1Czd0KtZ6V8l+E/Kj8ZuhFG3OBcM7ej/XYtcy8dzsK3O GBAQ== X-Gm-Message-State: ANhLgQ3lPqdA0CjZAc5iIMJzByeHyNILdRbR5Vzv8kF/hqT5uC547KPT xZadzCj7qJXt7PkJ7AFAOI6sh1DV X-Google-Smtp-Source: ADFU+vsU83Gr40a4h0A/VyZe4SijGIcjrSvVbpNF8VdBalggYijBHXYckgcqXBDJLNIPD8Y1FSPmZA== X-Received: by 2002:a1c:8108:: with SMTP id c8mr2632925wmd.50.1583853312121; Tue, 10 Mar 2020 08:15:12 -0700 (PDT) Original-Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id f6sm4271583wmh.29.2020.03.10.08.15.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2020 08:15:10 -0700 (PDT) In-Reply-To: <83tv2w9sa3.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 10 Mar 2020 16:52:04 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:177144 Archived-At: >>>>> On Tue, 10 Mar 2020 16:52:04 +0200, Eli Zaretskii said: >> From: Robert Pluim >> Cc: Vinicius Jos=C3=A9 Latorre , >> 39865@debbugs.gnu.org >> Date: Tue, 10 Mar 2020 15:29:44 +0100 >>=20 >> >> I think that emacs should be more robust about this and do not cr= ash for any bad value. >>=20 Eli> I agree. It is not a bad value, we just couldn't yet find a way of Eli> switching the font-backend. >>=20 >> Eli, would you accept a patch for emacs-27 that signals a user-error >> if trying to set a font-backend that=CA=BCs not supported by the run= ning >> emacs? Or that ignores it (with a message)? Eli> In general, yes; but I'd need to see the patch. diff --git a/src/frame.c b/src/frame.c index 51fc78ab70..3b0174cea9 100644 --- a/src/frame.c +++ b/src/frame.c @@ -4090,6 +4090,21 @@ gui_set_frame_parameters (struct frame *f, Lisp_Obje= ct alist) } else { + if (EQ (prop, Qfont_backend)) + { + Lisp_Object tail =3D val; + Lisp_Object backend; + FOR_EACH_TAIL_SAFE (tail) + { + backend =3D XCAR (tail); + if (! c_symbol_p (XSYMBOL (backend))) + { + AUTO_STRING (format, "Unsupported font-backend: \"%s= \""); + xsignal1 (Quser_error, CALLN (Fformat, format, backe= nd)); + } + } + } + register Lisp_Object param_index, old_value; =20 old_value =3D get_frame_param (f, prop); Eli> AFAIU, the problem in this case wasn't that the backend wasn't Eli> supported, it was that it was changed in the middle of a session. Setting font-backend to a supported value with default-frame-alist in .emacs should work, and does for me in master, at least switching from 'ftcrhb' to 'ftcr'. Switching from 'ftcrhb' to 'xft' crashes. Hmm, switching to 'x' also crashes. But I can create a new frame with 'x' as font-backend. Robert