From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alex Bochannek Newsgroups: gmane.emacs.bugs Subject: bug#73827: [ELPA] [PATCH] register-list fails on "Unprintable entity" registers Date: Tue, 15 Oct 2024 16:14:54 -0700 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35481"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: 73827@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 16 01:26:09 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t0qvY-00092c-QN for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 16 Oct 2024 01:26:08 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t0qvE-00016A-0G; Tue, 15 Oct 2024 19:25:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t0qvB-00015n-Fc for bug-gnu-emacs@gnu.org; Tue, 15 Oct 2024 19:25:45 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t0qvB-0005R7-7Z for bug-gnu-emacs@gnu.org; Tue, 15 Oct 2024 19:25:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:Subject; bh=bDsUPd3dqopEBT42JviI15YHbQ/1AwLdKDNnNw7b9ds=; b=ojK7GKSDpVWv+EflYcsyAo7UJVrxuDy7Ih0Z4JAkQ8jT4/H7421XG8N+04AV23WseqkoJadJbpJoYZe1RPugVthOtR3JdqvJCQKHc7PXnEJS+Zus5+rwBvMJgGOKkMXCKuontDA8Q4Ndep2IvhW+H2vEvwQkl/Fe1x/mzBfXb1ZehsCVrb7+87XGoSkFferpvatj8E+stY3tVvo/NCAt9ttiZFwiRepiyy22HBUx7kWtGM+gXYaTi1+HFl+9TZyZGrCIw0E0QYT8ex4VuFOPE0jABlqBPi00dWg0TK9ybM4D42i6Fmy85bRvpPf7fIQ4JaMSHJRmnrRVt3eLUXcjCw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t0qvS-0003KC-VJ for bug-gnu-emacs@gnu.org; Tue, 15 Oct 2024 19:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alex Bochannek Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Oct 2024 23:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 73827 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.172903471912295 (code B ref -1); Tue, 15 Oct 2024 23:26:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 15 Oct 2024 23:25:19 +0000 Original-Received: from localhost ([127.0.0.1]:57807 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t0quk-0003CE-7y for submit@debbugs.gnu.org; Tue, 15 Oct 2024 19:25:18 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:38464) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t0quh-0003C2-Ry for submit@debbugs.gnu.org; Tue, 15 Oct 2024 19:25:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t0quO-0000yI-Ok for bug-gnu-emacs@gnu.org; Tue, 15 Oct 2024 19:24:56 -0400 Original-Received: from ns.lapseofthought.com ([50.0.39.240] helo=mail.lapseofthought.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t0quM-0005BM-Rn for bug-gnu-emacs@gnu.org; Tue, 15 Oct 2024 19:24:56 -0400 Original-Received: from awb-mbp-m3.local (unknown [IPv6:2601:646:4200:73a0:25db:c231:73d0:4c41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.lapseofthought.com (Postfix) with ESMTPSA id 4XSqgg51dZz3pfcw for ; Tue, 15 Oct 2024 16:14:55 -0700 (PDT) Authentication-Results: ORIGINATING; auth=pass smtp.auth=alex smtp.mailfrom=alex@bochannek.com Received-SPF: pass client-ip=50.0.39.240; envelope-from=alex@bochannek.com; helo=mail.lapseofthought.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:293649 Archived-At: --=-=-= Content-Type: text/plain Hello! I have not submitted patches against an ELPA package before, so I hope this format is OK. I tried to follow the instruction on pulling ELPA from Git, but the make step failed for me. The register-list mode throws an error on start-up when there are unknown register types in the register-alist. This can happen with window configurations and saved session state after a restart. The reason for this is a simple line flip in the register-list-get-type function. --=-=-= Content-Type: text/x-patch Content-Disposition: inline --- /Users/awb/.emacs.d/elpa/register-list-0.1/register-list.el.~1~ 2023-01-10 19:36:23 +++ /Users/awb/.emacs.d/elpa/register-list-0.1/register-list.el 2024-10-15 15:49:37 @@ -483,8 +483,8 @@ (t "error")) (cond ((window-configuration-p (car key)) "W") ((frame-configuration-p (car key)) "F") - ((stringp (car key)) "R") ((string= "Unprintable entity" (car key)) "?") + ((stringp (car key)) "R") (t "error")))) ;;; Edit key/value of the register --=-=-= Content-Type: text/plain Apologies again for the format of this submission. If someone could point me at instructions for how to make your life easier next time, I'd appreciate it. Thanks! -- Alex. --=-=-=--