From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.bugs Subject: bug#7908: png-1.5 fix for emacs-23.2 and HEAD Date: Sun, 30 Jan 2011 01:00:45 +0100 Message-ID: References: <20110124125437.GS16230@danbala.tuwien.ac.at> <83d3nmyz76.fsf@gnu.org> <20110124215940.GH16230@danbala.tuwien.ac.at> <838vy9zlpa.fsf@gnu.org> <87ei80em65.fsf@stupidchicken.com> <83ei7vhl2y.fsf@gnu.org> <837hdnheid.fsf@gnu.org> <87ipx7y35f.fsf@stupidchicken.com> <831v3vh6tq.fsf@gnu.org> <83zkqjfq0d.fsf@gnu.org> <87fwsbqwlf.fsf@stupidchicken.com> <87hbcribvo.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1296346208 12179 80.91.229.12 (30 Jan 2011 00:10:08 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 30 Jan 2011 00:10:08 +0000 (UTC) Cc: 7908@debbugs.gnu.org, tk@giga.or.at To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jan 30 01:09:57 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PjKrc-000838-DB for geb-bug-gnu-emacs@m.gmane.org; Sun, 30 Jan 2011 01:09:56 +0100 Original-Received: from localhost ([127.0.0.1]:47476 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PjKrb-0001JF-EH for geb-bug-gnu-emacs@m.gmane.org; Sat, 29 Jan 2011 19:09:55 -0500 Original-Received: from [140.186.70.92] (port=46787 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PjKrW-0001J0-Qy for bug-gnu-emacs@gnu.org; Sat, 29 Jan 2011 19:09:52 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PjKrV-0003V8-QK for bug-gnu-emacs@gnu.org; Sat, 29 Jan 2011 19:09:50 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:50692) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PjKrV-0003V4-Ol for bug-gnu-emacs@gnu.org; Sat, 29 Jan 2011 19:09:49 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1PjKbG-0001oo-Hz; Sat, 29 Jan 2011 18:53:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andreas Schwab Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 Jan 2011 23:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7908 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 7908-submit@debbugs.gnu.org id=B7908.12963451546953 (code B ref 7908); Sat, 29 Jan 2011 23:53:02 +0000 Original-Received: (at 7908) by debbugs.gnu.org; 29 Jan 2011 23:52:34 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PjKan-0001o5-UO for submit@debbugs.gnu.org; Sat, 29 Jan 2011 18:52:34 -0500 Original-Received: from mail-out.m-online.net ([212.18.0.9]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PjKak-0001nq-Jr for 7908@debbugs.gnu.org; Sat, 29 Jan 2011 18:52:31 -0500 Original-Received: from frontend1.mail.m-online.net (unknown [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id AEC731C1DA16; Sun, 30 Jan 2011 01:00:46 +0100 (CET) Original-Received: from localhost (dynscan1.mnet-online.de [192.168.8.164]) by mail.m-online.net (Postfix) with ESMTP id 606071C0013D; Sun, 30 Jan 2011 01:00:46 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Original-Received: from mail.mnet-online.de ([192.168.8.180]) by localhost (dynscan1.mail.m-online.net [192.168.8.164]) (amavisd-new, port 10024) with ESMTP id jVX7AB+BmfwT; Sun, 30 Jan 2011 01:00:45 +0100 (CET) Original-Received: from igel.home (ppp-88-217-117-157.dynamic.mnet-online.de [88.217.117.157]) by mail.mnet-online.de (Postfix) with ESMTP; Sun, 30 Jan 2011 01:00:45 +0100 (CET) Original-Received: by igel.home (Postfix, from userid 501) id 1479DCA2A0; Sun, 30 Jan 2011 01:00:45 +0100 (CET) X-Yow: I'm EMOTIONAL now because I have MERCHANDISING CLOUT!! In-Reply-To: <87hbcribvo.fsf@stupidchicken.com> (Chong Yidong's message of "Sat, 29 Jan 2011 17:27:39 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2.92 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sat, 29 Jan 2011 18:53:02 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:43749 Archived-At: Chong Yidong writes: > Andreas Schwab writes: > >>> Aha, I think it makes sense. Since DEF_IMGLIB_FN defines a return type >>> of int, whereas fn_png_set_longjmp_fn actually returns a (jmp_buf *), we >>> do indeed need to perform the extra cast. >> >> You can't expect this to work, though. > > Hmm, true. So maybe something like this instead? I've checked in a proper fix, though I can't test it. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."